diff --git a/ui/admin/app/components/form/account/oidc/index.hbs b/ui/admin/app/components/form/account/oidc/index.hbs index 706858b92..2d01efbcf 100644 --- a/ui/admin/app/components/form/account/oidc/index.hbs +++ b/ui/admin/app/components/form/account/oidc/index.hbs @@ -10,58 +10,48 @@ @showEditToggle={{if @model.isNew false true}} as |form| > - + + {{t 'form.type.label'}} + {{#unless @model.isNew}} - - - - + + + {{t 'form.issuer.label'}} + + + + {{t 'form.subject.label'}} + + + + {{t 'form.email.label'}} + + + + {{t 'form.full_name.label'}} + {{/unless}} - + {{t 'form.name.label'}} + {{t 'form.name.help'}} {{#if @model.errors.name}} - + {{#each @model.errors.name as |error|}} - {{error.message}} + {{error.message}} {{/each}} - + {{/if}} - + {{#if @model.isNew}} - + {{t 'form.issuer.label'}} {{#if @model.errors.issuer}} - + {{#each @model.errors.issuer as |error|}} - {{error.message}} + {{error.message}} {{/each}} - + {{/if}} - + - + {{t 'form.subject.label'}} {{#if @model.errors.subject}} - + {{#each @model.errors.subject as |error|}} - {{error.message}} + {{error.message}} {{/each}} - + {{/if}} - + {{/if}} {{#if (can 'save model' @model)}} diff --git a/ui/admin/app/components/form/account/password/index.hbs b/ui/admin/app/components/form/account/password/index.hbs index bc1a2bcd9..0487dbcfb 100644 --- a/ui/admin/app/components/form/account/password/index.hbs +++ b/ui/admin/app/components/form/account/password/index.hbs @@ -10,37 +10,35 @@ @showEditToggle={{if @model.isNew false true}} as |form| > - + + {{t 'form.type.label'}} + - + {{t 'form.name.label'}} + {{t 'form.name.help'}} {{#if @model.errors.name}} - + {{#each @model.errors.name as |error|}} - {{error.message}} + {{error.message}} {{/each}} - + {{/if}} - + @@ -55,43 +53,45 @@ {{/if}} - + {{t 'form.login_name.label'}} {{#if @model.errors.login_name}} - + {{#each @model.errors.login_name as |error|}} - {{error.message}} + {{error.message}} {{/each}} - + {{/if}} - + {{#if @model.isNew}} - + {{t 'form.password.label'}} {{#if @model.errors.password}} - + {{#each @model.errors.password as |error|}} - {{error.message}} + {{error.message}} {{/each}} - + {{/if}} - + {{/if}} {{#if (can 'save model' @model)}} diff --git a/ui/admin/tests/acceptance/accounts/create-test.js b/ui/admin/tests/acceptance/accounts/create-test.js index a5cc8ec3c..809db716d 100644 --- a/ui/admin/tests/acceptance/accounts/create-test.js +++ b/ui/admin/tests/acceptance/accounts/create-test.js @@ -134,18 +134,18 @@ module('Acceptance | accounts | create', function (hooks) { const accountsCount = this.server.db.accounts.length; await visit(urls.newAccount); await fillIn('[name="name"]', 'Account name'); - await click('form button:not([type="submit"])'); - assert.strictEqual(this.server.db.accounts.length, accountsCount); + await click('.rose-form-actions [type="button"]'); assert.strictEqual(currentURL(), urls.accounts); + assert.strictEqual(this.server.db.accounts.length, accountsCount); }); test('can cancel a new LDAP account creation', async function (assert) { const accountsCount = this.server.db.accounts.length; await visit(urls.newAccount); await fillIn('[name="name"]', 'Account name'); - await click('form button:not([type="submit"])'); - assert.strictEqual(this.server.db.accounts.length, accountsCount); + await click('.rose-form-actions [type="button"]'); assert.strictEqual(currentURL(), urls.accounts); + assert.strictEqual(this.server.db.accounts.length, accountsCount); }); test('saving a new account with invalid fields displays error messages', async function (assert) { @@ -178,7 +178,7 @@ module('Acceptance | accounts | create', function (hooks) { 'Displays primary error message.', ); assert.strictEqual( - find('.rose-form-error-message').textContent.trim(), + find('[data-test-error-message-name]').textContent.trim(), 'Name is required.', 'Displays field-level errors.', ); diff --git a/ui/admin/tests/acceptance/accounts/update-test.js b/ui/admin/tests/acceptance/accounts/update-test.js index b25e18446..a3ef29512 100644 --- a/ui/admin/tests/acceptance/accounts/update-test.js +++ b/ui/admin/tests/acceptance/accounts/update-test.js @@ -158,7 +158,7 @@ module('Acceptance | accounts | update', function (hooks) { 'Displays primary error message.', ); assert.strictEqual( - find('.rose-form-error-message').textContent.trim(), + find('[data-test-error-message-name]').textContent.trim(), 'Name is required.', 'Displays field-level errors.', );