From 825c9556b6ac6658a52a0fdd14e23b273e08640f Mon Sep 17 00:00:00 2001 From: Cameron Perera Date: Thu, 11 Jul 2024 12:29:43 -0500 Subject: [PATCH] =?UTF-8?q?refactor:=20=F0=9F=92=A1=20remove=20worker=20ta?= =?UTF-8?q?gs=20from=20detail=20view=20of=20worker=20(#2380)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * refactor: 💡 remove worker tags from detail view of worker ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-13890 * refactor: 💡 remove unused styles ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-13890 * style: 💄 fix lint error ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-13890 * style: 💄 fix stylelint rules ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-13890 --- ui/admin/app/components/form/worker/index.hbs | 24 ------------------- ui/admin/app/styles/app.scss | 9 +------ .../tests/acceptance/workers/create-test.js | 2 +- 3 files changed, 2 insertions(+), 33 deletions(-) diff --git a/ui/admin/app/components/form/worker/index.hbs b/ui/admin/app/components/form/worker/index.hbs index 026935c8c..9f82da988 100644 --- a/ui/admin/app/components/form/worker/index.hbs +++ b/ui/admin/app/components/form/worker/index.hbs @@ -50,30 +50,6 @@ {{/if}} - - {{t 'resources.worker.form.worker_tags.label'}} - {{t 'resources.worker.form.worker_tags.help'}} - - - <:body as |B|> - {{#each-in @model.config_tags as |key value|}} - - - - - - - - - {{/each-in}} - - - - - {{t 'form.address.label'}} {{t 'form.worker_address.help'}} diff --git a/ui/admin/app/styles/app.scss b/ui/admin/app/styles/app.scss index dd792a8cd..b4492e557 100644 --- a/ui/admin/app/styles/app.scss +++ b/ui/admin/app/styles/app.scss @@ -732,14 +732,7 @@ } } } - - &.config-tags { - .hds-table__td:last-child { - // remove width from last cell - width: unset; - } - /* stylelint-enable selector-class-pattern */ - } + /* stylelint-enable selector-class-pattern */ } .auth-methods-list-alert { diff --git a/ui/admin/tests/acceptance/workers/create-test.js b/ui/admin/tests/acceptance/workers/create-test.js index 4955adc72..233eab219 100644 --- a/ui/admin/tests/acceptance/workers/create-test.js +++ b/ui/admin/tests/acceptance/workers/create-test.js @@ -122,7 +122,7 @@ module('Acceptance | workers | create', function (hooks) { assert.dom(`[href="${newWorkerURL}"]`).isNotVisible(); }); - test('saving a new user with invalid fields displays error messages', async function (assert) { + test('saving a new worker with invalid fields displays error messages', async function (assert) { this.server.post('/workers:create:worker-led', () => { return new Response( 500,