From 83fa213854f65b3992a0bfab0e7622da11ab294f Mon Sep 17 00:00:00 2001
From: Lauren <lauren.burwell@hashicorp.com>
Date: Tue, 25 Feb 2025 13:16:41 -0500
Subject: [PATCH] =?UTF-8?q?refactor:=20=F0=9F=92=85=20=20Aliases:=20read-t?=
 =?UTF-8?q?est=20(#2691)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* refactor: 💡 Read aliases test suite

Refactor tests for read aliases test suite

✅ Closes: ICU-15455

* replace with alert toast body, replace with this.server.schema

* revert change

* revert oidc test

* revert roles, create-test

* add const to commonSelectors file, revert selectors file

* rename selector

* use TABLE_RESOURCE_LINK common selector

* fix test failure
---
 ui/admin/tests/acceptance/aliases/read-test.js | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/ui/admin/tests/acceptance/aliases/read-test.js b/ui/admin/tests/acceptance/aliases/read-test.js
index 13817733f..481d35d73 100644
--- a/ui/admin/tests/acceptance/aliases/read-test.js
+++ b/ui/admin/tests/acceptance/aliases/read-test.js
@@ -17,8 +17,6 @@ module('Acceptance | aliases | read', function (hooks) {
   setupMirage(hooks);
   setupIndexedDb(hooks);
 
-  const TABLE_LINK_SELECTOR = '.hds-table__tbody tr:first-child a';
-
   const instances = {
     scopes: {
       global: null,
@@ -51,26 +49,26 @@ module('Acceptance | aliases | read', function (hooks) {
     await authenticateSession({ username: 'admin' });
   });
 
-  test('visiting a alias', async function (assert) {
+  test('visiting an alias', async function (assert) {
     await visit(urls.globalScope);
     await a11yAudit();
 
-    await click(`[href="${urls.aliases}"]`);
+    await click(commonSelectors.HREF(urls.aliases));
     await a11yAudit();
-    await click(`[href="${urls.alias}"]`);
+    await click(commonSelectors.HREF(urls.alias));
     await a11yAudit();
 
     assert.strictEqual(currentURL(), urls.alias);
   });
 
-  test('cannot navigate to a alias without proper authorization', async function (assert) {
+  test('cannot navigate to an alias without proper authorization', async function (assert) {
     await visit(urls.globalScope);
     instances.alias.authorized_actions =
       instances.alias.authorized_actions.filter((item) => item !== 'read');
 
-    await click(`[href="${urls.aliases}"]`);
+    await click(commonSelectors.HREF(urls.aliases));
 
-    assert.dom(TABLE_LINK_SELECTOR).doesNotExist();
+    assert.dom(commonSelectors.TABLE_RESOURCE_LINK(urls.alias)).doesNotExist();
   });
 
   test('visiting an unknown alias displays 404 message', async function (assert) {