From 84f9c2febcfaba04f84f22b862498f4f7fcbc494 Mon Sep 17 00:00:00 2001
From: Susmitha Girumala <susmitha@hashicorp.com>
Date: Wed, 27 Jan 2021 12:16:57 -0500
Subject: [PATCH] chore: Add env var based signing check for desktop client

---
 .../electron-app/config/forge.config.js       | 38 +++++++++++++++++++
 ui/desktop/electron-app/package.json          | 29 +-------------
 2 files changed, 39 insertions(+), 28 deletions(-)
 create mode 100644 ui/desktop/electron-app/config/forge.config.js

diff --git a/ui/desktop/electron-app/config/forge.config.js b/ui/desktop/electron-app/config/forge.config.js
new file mode 100644
index 000000000..2690c6028
--- /dev/null
+++ b/ui/desktop/electron-app/config/forge.config.js
@@ -0,0 +1,38 @@
+const process = require('process');
+
+module.exports = {
+  hooks: {
+    prePackage: (forgeConfig) => {
+      if (process.env.BOUNDARY_DESKTOP_SIGNING_IDENTITY) {
+        forgeConfig.osxSign = {
+          identity: process.env.BOUNDARY_DESKTOP_SIGNING_IDENTITY,
+          hardenedRuntime: true,
+          "gatekeeper-assess": false,
+          entitlements: "config/macos/entitlements.plist",
+          "entitlements-inherit": "config/macos/entitlements.plist",
+          "signature-flags": "library"
+        }
+      } else {
+        console.warn('Could not find signing identity. Skipping signing.');
+      }
+    }
+  },
+  packagerConfig: {
+    ignore: [
+      "/ember-test(/|$)",
+      "/tests(/|$)"
+    ],
+    name: "Boundary Desktop",
+    appBundleId: "com.electron.boundary",
+    appVersion: "0.0.1",
+    appCopyright: "Copyright © 2021 HashiCorp, Inc."
+  },
+  makers: [
+    {
+      name: "@electron-forge/maker-dmg",
+      config: {
+        name: "Boundary Desktop"
+      }
+    }
+  ]
+}
diff --git a/ui/desktop/electron-app/package.json b/ui/desktop/electron-app/package.json
index 66fd2a81a..be09b0414 100644
--- a/ui/desktop/electron-app/package.json
+++ b/ui/desktop/electron-app/package.json
@@ -16,34 +16,7 @@
   },
   "keywords": [],
   "config": {
-    "forge": {
-      "packagerConfig": {
-        "ignore": [
-          "/ember-test(/|$)",
-          "/tests(/|$)"
-        ],
-        "name": "Boundary Desktop",
-        "appBundleId": "com.electron.boundary",
-        "appVersion": "0.0.1",
-        "appCopyright": "Copyright © 2021 HashiCorp, Inc.",
-        "osxSign": {
-          "identity": "Developer ID Application: Hashicorp, Inc. (D38WU7D763)",
-          "hardenedRuntime": true,
-          "gatekeeper-assess": false,
-          "entitlements": "config/macos/entitlements.plist",
-          "entitlements-inherit": "config/macos/entitlements.plist",
-          "signature-flags": "library"
-        }
-      },
-      "makers": [
-        {
-          "name": "@electron-forge/maker-dmg",
-          "config": {
-            "name": "Boundary Desktop"
-          }
-        }
-      ]
-    }
+    "forge": "config/forge.config.js"
   },
   "dependencies": {
     "axios": "^0.21.1",