From 8c01ec2f20d2eac44c771572ae0277bb3fb9332e Mon Sep 17 00:00:00 2001 From: Cameron Perera Date: Fri, 31 Mar 2023 14:10:36 -0500 Subject: [PATCH] =?UTF-8?q?feat:=20=F0=9F=8E=B8=20update=20player=20to=20a?= =?UTF-8?q?llow=20routing=20to=20provided=20route=20(#173)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ✅ Closes: ICU-8381 --- .../components/session-recording/player/index.hbs | 3 ++- .../channels-by-connection/channel.hbs | 6 +++++- .../channels-by-connection/channel-test.js | 12 +++++++++++- .../components/session-recording/player-test.js | 2 +- 4 files changed, 19 insertions(+), 4 deletions(-) diff --git a/ui/admin/app/components/session-recording/player/index.hbs b/ui/admin/app/components/session-recording/player/index.hbs index e3244d9bd..eed4493a5 100644 --- a/ui/admin/app/components/session-recording/player/index.hbs +++ b/ui/admin/app/components/session-recording/player/index.hbs @@ -3,7 +3,8 @@
diff --git a/ui/admin/app/templates/scopes/scope/session-recordings/session-recording/channels-by-connection/channel.hbs b/ui/admin/app/templates/scopes/scope/session-recordings/session-recording/channels-by-connection/channel.hbs index f2054ee48..db8e1ca49 100644 --- a/ui/admin/app/templates/scopes/scope/session-recordings/session-recording/channels-by-connection/channel.hbs +++ b/ui/admin/app/templates/scopes/scope/session-recordings/session-recording/channels-by-connection/channel.hbs @@ -13,7 +13,11 @@ - + diff --git a/ui/admin/tests/acceptance/session-recordings/session-recording/channels-by-connection/channel-test.js b/ui/admin/tests/acceptance/session-recordings/session-recording/channels-by-connection/channel-test.js index a971cdb27..3d0decb09 100644 --- a/ui/admin/tests/acceptance/session-recordings/session-recording/channels-by-connection/channel-test.js +++ b/ui/admin/tests/acceptance/session-recordings/session-recording/channels-by-connection/channel-test.js @@ -1,5 +1,5 @@ import { module, test } from 'qunit'; -import { visit, currentURL } from '@ember/test-helpers'; +import { visit, currentURL, click } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; import { authenticateSession } from 'ember-simple-auth/test-support'; @@ -59,5 +59,15 @@ module( await visit(urls.connectionRecording); assert.strictEqual(currentURL(), urls.connectionRecording); }); + + test('user can navigate back to session recording screen', async function (assert) { + assert.expect(1); + // Visit channel + await visit(urls.connectionRecording); + // click "Back to channels" link in player header + await click('.session-recording-player-header > a'); + + assert.strictEqual(currentURL(), urls.sessionRecording); + }); } ); diff --git a/ui/admin/tests/integration/components/session-recording/player-test.js b/ui/admin/tests/integration/components/session-recording/player-test.js index fc93a81f5..9380b7e36 100644 --- a/ui/admin/tests/integration/components/session-recording/player-test.js +++ b/ui/admin/tests/integration/components/session-recording/player-test.js @@ -26,7 +26,7 @@ module('Integration | Component | session-recording/player', function (hooks) { [3.63678, "o", "t"]`; await render(hbs` - + `); assert.dom(this.element).hasText('Back to channels --:----:--');