From 41b3a996171542eb53db507977dfc068cc108f77 Mon Sep 17 00:00:00 2001 From: Randall Morey Date: Tue, 25 Jan 2022 09:13:09 -0500 Subject: [PATCH 1/4] =?UTF-8?q?refactor:=20=F0=9F=92=A1=20remove=20renderT?= =?UTF-8?q?emplate=20usage=20from=20roles=20resource?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../roles/role/actions/index.hbs} | 0 .../roles/role/header/index.hbs} | 0 .../roles/role/nav/index.hbs} | 0 .../app/routes/scopes/scope/roles/role.js | 24 --- .../scopes/scope/roles/role/add-principals.js | 24 --- .../routes/scopes/scope/roles/role/grants.js | 16 -- .../scopes/scope/roles/role/principals.js | 14 -- .../app/templates/scopes/scope/roles/role.hbs | 24 +-- .../scope/roles/role/add-principals.hbs | 32 +++- .../roles/role/add-principals/-header.hbs | 5 - .../scopes/scope/roles/role/grants.hbs | 47 ++++- .../scope/roles/role/grants/-header.hbs | 12 -- .../scopes/scope/roles/role/index.hbs | 34 +++- .../scopes/scope/roles/role/principals.hbs | 180 +++++++++++------- .../scope/roles/role/principals/-header.hbs | 12 -- 15 files changed, 201 insertions(+), 223 deletions(-) rename ui/admin/app/{templates/scopes/scope/roles/role/-actions.hbs => components/roles/role/actions/index.hbs} (100%) rename ui/admin/app/{templates/scopes/scope/roles/role/-header.hbs => components/roles/role/header/index.hbs} (100%) rename ui/admin/app/{templates/scopes/scope/roles/role/-navigation.hbs => components/roles/role/nav/index.hbs} (100%) delete mode 100644 ui/admin/app/templates/scopes/scope/roles/role/add-principals/-header.hbs delete mode 100644 ui/admin/app/templates/scopes/scope/roles/role/grants/-header.hbs delete mode 100644 ui/admin/app/templates/scopes/scope/roles/role/principals/-header.hbs diff --git a/ui/admin/app/templates/scopes/scope/roles/role/-actions.hbs b/ui/admin/app/components/roles/role/actions/index.hbs similarity index 100% rename from ui/admin/app/templates/scopes/scope/roles/role/-actions.hbs rename to ui/admin/app/components/roles/role/actions/index.hbs diff --git a/ui/admin/app/templates/scopes/scope/roles/role/-header.hbs b/ui/admin/app/components/roles/role/header/index.hbs similarity index 100% rename from ui/admin/app/templates/scopes/scope/roles/role/-header.hbs rename to ui/admin/app/components/roles/role/header/index.hbs diff --git a/ui/admin/app/templates/scopes/scope/roles/role/-navigation.hbs b/ui/admin/app/components/roles/role/nav/index.hbs similarity index 100% rename from ui/admin/app/templates/scopes/scope/roles/role/-navigation.hbs rename to ui/admin/app/components/roles/role/nav/index.hbs diff --git a/ui/admin/app/routes/scopes/scope/roles/role.js b/ui/admin/app/routes/scopes/scope/roles/role.js index 23ff8220c..54c98ec4c 100644 --- a/ui/admin/app/routes/scopes/scope/roles/role.js +++ b/ui/admin/app/routes/scopes/scope/roles/role.js @@ -16,28 +16,4 @@ export default class ScopesScopeRolesRoleRoute extends Route { adapterOptions: { scopeID }, }); } - - /** - * Renders the role specific templates for header, navigation, - * and actions page sections. - * @override - */ - renderTemplate() { - super.renderTemplate(...arguments); - - this.render('scopes/scope/roles/role/-header', { - into: 'scopes/scope/roles/role', - outlet: 'header', - }); - - this.render('scopes/scope/roles/role/-navigation', { - into: 'scopes/scope/roles/role', - outlet: 'navigation', - }); - - this.render('scopes/scope/roles/role/-actions', { - into: 'scopes/scope/roles/role', - outlet: 'actions', - }); - } } diff --git a/ui/admin/app/routes/scopes/scope/roles/role/add-principals.js b/ui/admin/app/routes/scopes/scope/roles/role/add-principals.js index c6dcf8b50..1d29243d7 100644 --- a/ui/admin/app/routes/scopes/scope/roles/role/add-principals.js +++ b/ui/admin/app/routes/scopes/scope/roles/role/add-principals.js @@ -28,30 +28,6 @@ export default class ScopesScopeRolesRoleAddPrincipalsRoute extends Route { }); } - /** - * Renders the add-principals-specific header template. - * Empties the actions and navigation outlets and renders a custom empty header. - * @override - */ - renderTemplate() { - super.renderTemplate(...arguments); - - this.render('scopes/scope/roles/role/add-principals/-header', { - into: 'scopes/scope/roles/role', - outlet: 'header', - }); - - this.render('-empty', { - into: 'scopes/scope/roles/role', - outlet: 'navigation', - }); - - this.render('-empty', { - into: 'scopes/scope/roles/role', - outlet: 'actions', - }); - } - // =actions /** diff --git a/ui/admin/app/routes/scopes/scope/roles/role/grants.js b/ui/admin/app/routes/scopes/scope/roles/role/grants.js index 11cfa1516..76d7c7ef3 100644 --- a/ui/admin/app/routes/scopes/scope/roles/role/grants.js +++ b/ui/admin/app/routes/scopes/scope/roles/role/grants.js @@ -10,22 +10,6 @@ export default class ScopesScopeRolesRoleGrantsRoute extends Route { @service intl; @service notify; - // =methods - - /** - * Renders the grants-specific header template. - * Empties the actions and navigation outlets and renders a custom empty header. - * @override - */ - renderTemplate() { - super.renderTemplate(...arguments); - - this.render('scopes/scope/roles/role/grants/-header', { - into: 'scopes/scope/roles/role', - outlet: 'header', - }); - } - // =actions /** diff --git a/ui/admin/app/routes/scopes/scope/roles/role/principals.js b/ui/admin/app/routes/scopes/scope/roles/role/principals.js index 6c3b38925..17172e0f8 100644 --- a/ui/admin/app/routes/scopes/scope/roles/role/principals.js +++ b/ui/admin/app/routes/scopes/scope/roles/role/principals.js @@ -45,20 +45,6 @@ export default class ScopesScopeRolesRolePrincipalsRoute extends Route { }); } - /** - * Renders the principals-specific header template. - * Empties the actions and navigation outlets and renders a custom empty header. - * @override - */ - renderTemplate() { - super.renderTemplate(...arguments); - - this.render('scopes/scope/roles/role/principals/-header', { - into: 'scopes/scope/roles/role', - outlet: 'header', - }); - } - // =actions /** diff --git a/ui/admin/app/templates/scopes/scope/roles/role.hbs b/ui/admin/app/templates/scopes/scope/roles/role.hbs index 33d5e4cdc..7d32ecb0d 100644 --- a/ui/admin/app/templates/scopes/scope/roles/role.hbs +++ b/ui/admin/app/templates/scopes/scope/roles/role.hbs @@ -1,25 +1,3 @@ {{page-title @model.displayName}} - - - - - - - - {{outlet 'header'}} - - - - {{outlet 'actions'}} - - - - {{outlet 'navigation'}} - - - - {{outlet}} - - - \ No newline at end of file +{{outlet}} \ No newline at end of file diff --git a/ui/admin/app/templates/scopes/scope/roles/role/add-principals.hbs b/ui/admin/app/templates/scopes/scope/roles/role/add-principals.hbs index 059142299..c454c543a 100644 --- a/ui/admin/app/templates/scopes/scope/roles/role/add-principals.hbs +++ b/ui/admin/app/templates/scopes/scope/roles/role/add-principals.hbs @@ -1,9 +1,27 @@ {{page-title (t 'resources.role.principal.actions.add-principals')}} - \ No newline at end of file + + + + + + + +

+ {{t 'resources.role.principal.messages.add-principals.title'}} + +

+

{{t 'resources.role.principal.messages.add-principals.description'}}

+
+ + + + + +
\ No newline at end of file diff --git a/ui/admin/app/templates/scopes/scope/roles/role/add-principals/-header.hbs b/ui/admin/app/templates/scopes/scope/roles/role/add-principals/-header.hbs deleted file mode 100644 index 8264b0ae5..000000000 --- a/ui/admin/app/templates/scopes/scope/roles/role/add-principals/-header.hbs +++ /dev/null @@ -1,5 +0,0 @@ -

- {{t 'resources.role.principal.messages.add-principals.title'}} - -

-

{{t 'resources.role.principal.messages.add-principals.description'}}

\ No newline at end of file diff --git a/ui/admin/app/templates/scopes/scope/roles/role/grants.hbs b/ui/admin/app/templates/scopes/scope/roles/role/grants.hbs index 79ccf9ede..a93aaacf7 100644 --- a/ui/admin/app/templates/scopes/scope/roles/role/grants.hbs +++ b/ui/admin/app/templates/scopes/scope/roles/role/grants.hbs @@ -1,9 +1,42 @@ {{page-title (t 'resources.role.grant.title_plural')}} - \ No newline at end of file + + + + + + + +

+ {{t 'resources.role.title'}} + +

+

{{t 'resources.role.grant.description'}}

+ + {{@model.id}} + +
+ + + + + + + + + + + + + +
\ No newline at end of file diff --git a/ui/admin/app/templates/scopes/scope/roles/role/grants/-header.hbs b/ui/admin/app/templates/scopes/scope/roles/role/grants/-header.hbs deleted file mode 100644 index 4097a2ecf..000000000 --- a/ui/admin/app/templates/scopes/scope/roles/role/grants/-header.hbs +++ /dev/null @@ -1,12 +0,0 @@ -

- {{t 'resources.role.title'}} - -

-

{{t 'resources.role.grant.description'}}

- - {{@model.id}} - \ No newline at end of file diff --git a/ui/admin/app/templates/scopes/scope/roles/role/index.hbs b/ui/admin/app/templates/scopes/scope/roles/role/index.hbs index 99dc29cc6..8edae91b9 100644 --- a/ui/admin/app/templates/scopes/scope/roles/role/index.hbs +++ b/ui/admin/app/templates/scopes/scope/roles/role/index.hbs @@ -1,6 +1,28 @@ - \ No newline at end of file + + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/ui/admin/app/templates/scopes/scope/roles/role/principals.hbs b/ui/admin/app/templates/scopes/scope/roles/role/principals.hbs index 567a95200..0dd8125f2 100644 --- a/ui/admin/app/templates/scopes/scope/roles/role/principals.hbs +++ b/ui/admin/app/templates/scopes/scope/roles/role/principals.hbs @@ -1,79 +1,113 @@ {{page-title (t 'resources.role.principal.title_plural')}} -{{#if @model.principals}} + - - - - {{t 'form.name.label'}} - {{t 'form.type.label'}} - {{t 'form.id.label'}} - {{t 'titles.actions'}} - - - - {{#each @model.principals as |principal|}} - - - {{principal.model.displayName}} - {{#if principal.model.accountName}} -
{{principal.model.accountName}} - {{/if}} -
- - {{t (concat 'resources.role.principal.types.' principal.type)}} - - - - {{principal.model.id}} - - - - {{#if (can 'removePrincipals role' @model.role)}} - - - {{t 'actions.remove'}} - - - {{/if}} - -
- {{/each}} -
-
+ + + -{{else}} - - - +

+ {{t 'resources.role.title'}} + +

+

{{t 'resources.role.principal.description'}}

+ - - {{t 'resources.role.principal.messages.welcome.description'}} - - - - {{t 'resources.role.principal.actions.add-principals'}} - -
-
+ {{@model.role.id}} + + -{{/if}} \ No newline at end of file + + + + + + + + + + {{#if @model.principals}} + + + + + {{t 'form.name.label'}} + {{t 'form.type.label'}} + {{t 'form.id.label'}} + {{t 'titles.actions'}} + + + + {{#each @model.principals as |principal|}} + + + {{principal.model.displayName}} + {{#if principal.model.accountName}} +
{{principal.model.accountName}} + {{/if}} +
+ + {{t (concat 'resources.role.principal.types.' principal.type)}} + + + + {{principal.model.id}} + + + + {{#if (can 'removePrincipals role' @model.role)}} + + + {{t 'actions.remove'}} + + + {{/if}} + +
+ {{/each}} +
+
+ + {{else}} + + + + + {{t 'resources.role.principal.messages.welcome.description'}} + + + + {{t 'resources.role.principal.actions.add-principals'}} + + + + + {{/if}} +
+ +
\ No newline at end of file diff --git a/ui/admin/app/templates/scopes/scope/roles/role/principals/-header.hbs b/ui/admin/app/templates/scopes/scope/roles/role/principals/-header.hbs deleted file mode 100644 index 3f483d4d2..000000000 --- a/ui/admin/app/templates/scopes/scope/roles/role/principals/-header.hbs +++ /dev/null @@ -1,12 +0,0 @@ -

- {{t 'resources.role.title'}} - -

-

{{t 'resources.role.principal.description'}}

- - {{@model.role.id}} - \ No newline at end of file From 2febf3ac3c3f44f432ab6e119281be024693c40d Mon Sep 17 00:00:00 2001 From: Randall Morey Date: Tue, 25 Jan 2022 09:40:30 -0500 Subject: [PATCH 2/4] =?UTF-8?q?refactor:=20=F0=9F=92=A1=20remove=20renderT?= =?UTF-8?q?emplate=20usage=20from=20groups=20resource?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../groups/group/actions/index.hbs} | 0 .../groups/group/header/index.hbs} | 0 .../groups/group/nav/index.hbs} | 0 .../app/routes/scopes/scope/groups/group.js | 23 --- .../scopes/scope/groups/group/add-members.js | 23 --- .../templates/scopes/scope/groups/group.hbs | 24 +-- .../scopes/scope/groups/group/add-members.hbs | 30 +++- .../groups/group/add-members/-header.hbs | 5 - .../scopes/scope/groups/group/index.hbs | 32 +++- .../scopes/scope/groups/group/members.hbs | 158 ++++++++++-------- 10 files changed, 142 insertions(+), 153 deletions(-) rename ui/admin/app/{templates/scopes/scope/groups/group/-actions.hbs => components/groups/group/actions/index.hbs} (100%) rename ui/admin/app/{templates/scopes/scope/groups/group/-header.hbs => components/groups/group/header/index.hbs} (100%) rename ui/admin/app/{templates/scopes/scope/groups/group/-navigation.hbs => components/groups/group/nav/index.hbs} (100%) delete mode 100644 ui/admin/app/templates/scopes/scope/groups/group/add-members/-header.hbs diff --git a/ui/admin/app/templates/scopes/scope/groups/group/-actions.hbs b/ui/admin/app/components/groups/group/actions/index.hbs similarity index 100% rename from ui/admin/app/templates/scopes/scope/groups/group/-actions.hbs rename to ui/admin/app/components/groups/group/actions/index.hbs diff --git a/ui/admin/app/templates/scopes/scope/groups/group/-header.hbs b/ui/admin/app/components/groups/group/header/index.hbs similarity index 100% rename from ui/admin/app/templates/scopes/scope/groups/group/-header.hbs rename to ui/admin/app/components/groups/group/header/index.hbs diff --git a/ui/admin/app/templates/scopes/scope/groups/group/-navigation.hbs b/ui/admin/app/components/groups/group/nav/index.hbs similarity index 100% rename from ui/admin/app/templates/scopes/scope/groups/group/-navigation.hbs rename to ui/admin/app/components/groups/group/nav/index.hbs diff --git a/ui/admin/app/routes/scopes/scope/groups/group.js b/ui/admin/app/routes/scopes/scope/groups/group.js index 0d9ad56bf..75a1c70d2 100644 --- a/ui/admin/app/routes/scopes/scope/groups/group.js +++ b/ui/admin/app/routes/scopes/scope/groups/group.js @@ -12,27 +12,4 @@ export default class ScopesScopeGroupsGroupRoute extends Route { model({ group_id }) { return this.store.findRecord('group', group_id, { reload: true }); } - - /** - * Renders the route-set specific page sections - * @override - */ - renderTemplate() { - super.renderTemplate(...arguments); - - this.render('scopes/scope/groups/group/-header', { - into: 'scopes/scope/groups/group', - outlet: 'header', - }); - - this.render('scopes/scope/groups/group/-actions', { - into: 'scopes/scope/groups/group', - outlet: 'actions', - }); - - this.render('scopes/scope/groups/group/-navigation', { - into: 'scopes/scope/groups/group', - outlet: 'navigation', - }); - } } diff --git a/ui/admin/app/routes/scopes/scope/groups/group/add-members.js b/ui/admin/app/routes/scopes/scope/groups/group/add-members.js index fda2aaaed..7629c17d9 100644 --- a/ui/admin/app/routes/scopes/scope/groups/group/add-members.js +++ b/ui/admin/app/routes/scopes/scope/groups/group/add-members.js @@ -34,29 +34,6 @@ export default class ScopesScopeGroupsGroupAddMembersRoute extends Route { }); } - /** - * Renders the route-set specific page sections - * @override - */ - renderTemplate() { - super.renderTemplate(...arguments); - - this.render('scopes/scope/groups/group/add-members/-header', { - into: 'scopes/scope/groups/group', - outlet: 'header', - }); - - this.render('-empty', { - into: 'scopes/scope/groups/group', - outlet: 'actions', - }); - - this.render('-empty', { - into: 'scopes/scope/groups/group', - outlet: 'navigation', - }); - } - // =actions /** diff --git a/ui/admin/app/templates/scopes/scope/groups/group.hbs b/ui/admin/app/templates/scopes/scope/groups/group.hbs index 837d1f984..7d32ecb0d 100644 --- a/ui/admin/app/templates/scopes/scope/groups/group.hbs +++ b/ui/admin/app/templates/scopes/scope/groups/group.hbs @@ -1,25 +1,3 @@ {{page-title @model.displayName}} - - - - - - - - {{outlet 'header'}} - - - - {{outlet 'navigation'}} - - - - {{outlet 'actions'}} - - - - {{outlet}} - - - \ No newline at end of file +{{outlet}} \ No newline at end of file diff --git a/ui/admin/app/templates/scopes/scope/groups/group/add-members.hbs b/ui/admin/app/templates/scopes/scope/groups/group/add-members.hbs index a85c01185..3013ba2f7 100644 --- a/ui/admin/app/templates/scopes/scope/groups/group/add-members.hbs +++ b/ui/admin/app/templates/scopes/scope/groups/group/add-members.hbs @@ -1,8 +1,26 @@ {{page-title (t 'resources.group.messages.add-members.title')}} - \ No newline at end of file + + + + + + + +

+ {{t 'resources.group.messages.add-members.title'}} + +

+

{{t 'resources.group.messages.add-members.description'}}

+
+ + + + + +
\ No newline at end of file diff --git a/ui/admin/app/templates/scopes/scope/groups/group/add-members/-header.hbs b/ui/admin/app/templates/scopes/scope/groups/group/add-members/-header.hbs deleted file mode 100644 index 71181a8df..000000000 --- a/ui/admin/app/templates/scopes/scope/groups/group/add-members/-header.hbs +++ /dev/null @@ -1,5 +0,0 @@ -

- {{t 'resources.group.messages.add-members.title'}} - -

-

{{t 'resources.group.messages.add-members.description'}}

\ No newline at end of file diff --git a/ui/admin/app/templates/scopes/scope/groups/group/index.hbs b/ui/admin/app/templates/scopes/scope/groups/group/index.hbs index 6a89a496d..d5da2abf3 100644 --- a/ui/admin/app/templates/scopes/scope/groups/group/index.hbs +++ b/ui/admin/app/templates/scopes/scope/groups/group/index.hbs @@ -1,5 +1,27 @@ - \ No newline at end of file + + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/ui/admin/app/templates/scopes/scope/groups/group/members.hbs b/ui/admin/app/templates/scopes/scope/groups/group/members.hbs index 9df657c32..b4c479eda 100644 --- a/ui/admin/app/templates/scopes/scope/groups/group/members.hbs +++ b/ui/admin/app/templates/scopes/scope/groups/group/members.hbs @@ -1,75 +1,97 @@ {{page-title (t 'resources.group.messages.members.title')}} -{{#if @model.members}} + - - - - {{t 'form.name.label'}} - {{t 'form.id.label'}} - {{t 'titles.actions'}} - - - - {{#each @model.members as |member|}} - - - {{member.displayName}} - {{#if member.accountName}} -
{{member.accountName}} - {{/if}} -
- - - {{member.id}} - - - - {{#if (can 'removeMembers group' @model.group)}} - - + + + + + + + + + + + + + + + + + {{#if @model.members}} + + + + + {{t 'form.name.label'}} + {{t 'form.id.label'}} + {{t 'titles.actions'}} + + + + {{#each @model.members as |member|}} + + + {{member.displayName}} + {{#if member.accountName}} +
{{member.accountName}} + {{/if}} +
+ + - {{t 'actions.remove'}} -
-
- {{/if}} -
-
- {{/each}} -
-
+ {{member.id}} + + + + {{#if (can 'removeMembers group' @model.group)}} + + + {{t 'actions.remove'}} + + + {{/if}} + + + {{/each}} + + -{{else}} + {{else}} - - - - {{t 'resources.group.messages.members.description'}} - - - - {{t 'resources.group.actions.add-members'}} - - - + + + + {{t 'resources.group.messages.members.description'}} + + + + {{t 'resources.group.actions.add-members'}} + + + -{{/if}} \ No newline at end of file + {{/if}} + + +
\ No newline at end of file From ef018aac59b50d2bfce46e679b64f662c823e36f Mon Sep 17 00:00:00 2001 From: Randall Morey Date: Tue, 25 Jan 2022 10:18:10 -0500 Subject: [PATCH 3/4] =?UTF-8?q?refactor:=20=F0=9F=92=A1=20remove=20renderT?= =?UTF-8?q?emplate=20usage=20from=20creds=20resources?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../credential-store/actions/index.hbs} | 0 .../credential-store/header/index.hbs} | 0 .../credential-store/nav/index.hbs} | 0 .../credential-library.js | 13 ++ .../scopes/scope/credential-stores/new.js | 18 ++ .../credential-stores/credential-store.js | 23 -- .../credential-store/credential-libraries.js | 2 +- .../credential-library.js | 32 --- .../credential-libraries/new.js | 27 --- .../credential-stores/credential-store.hbs | 23 +- .../credential-library/-actions.hbs | 15 -- .../credential-library/-header.hbs | 12 - .../credential-library/-navigation.hbs | 7 - .../credential-library/index.hbs | 62 ++++- .../credential-libraries/index.hbs | 216 ++++++++++-------- .../credential-libraries/new.hbs | 25 +- .../credential-libraries/new/-header.hbs | 3 - .../credential-store/index.hbs | 31 ++- 18 files changed, 257 insertions(+), 252 deletions(-) rename ui/admin/app/{templates/scopes/scope/credential-stores/credential-store/-actions.hbs => components/credential-stores/credential-store/actions/index.hbs} (100%) rename ui/admin/app/{templates/scopes/scope/credential-stores/credential-store/-header.hbs => components/credential-stores/credential-store/header/index.hbs} (100%) rename ui/admin/app/{templates/scopes/scope/credential-stores/credential-store/-navigation.hbs => components/credential-stores/credential-store/nav/index.hbs} (100%) create mode 100644 ui/admin/app/controllers/scopes/scope/credential-stores/credential-store/credential-libraries/credential-library.js create mode 100644 ui/admin/app/controllers/scopes/scope/credential-stores/new.js delete mode 100644 ui/admin/app/templates/scopes/scope/credential-stores/credential-store/credential-libraries/credential-library/-actions.hbs delete mode 100644 ui/admin/app/templates/scopes/scope/credential-stores/credential-store/credential-libraries/credential-library/-header.hbs delete mode 100644 ui/admin/app/templates/scopes/scope/credential-stores/credential-store/credential-libraries/credential-library/-navigation.hbs delete mode 100644 ui/admin/app/templates/scopes/scope/credential-stores/credential-store/credential-libraries/new/-header.hbs diff --git a/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/-actions.hbs b/ui/admin/app/components/credential-stores/credential-store/actions/index.hbs similarity index 100% rename from ui/admin/app/templates/scopes/scope/credential-stores/credential-store/-actions.hbs rename to ui/admin/app/components/credential-stores/credential-store/actions/index.hbs diff --git a/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/-header.hbs b/ui/admin/app/components/credential-stores/credential-store/header/index.hbs similarity index 100% rename from ui/admin/app/templates/scopes/scope/credential-stores/credential-store/-header.hbs rename to ui/admin/app/components/credential-stores/credential-store/header/index.hbs diff --git a/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/-navigation.hbs b/ui/admin/app/components/credential-stores/credential-store/nav/index.hbs similarity index 100% rename from ui/admin/app/templates/scopes/scope/credential-stores/credential-store/-navigation.hbs rename to ui/admin/app/components/credential-stores/credential-store/nav/index.hbs diff --git a/ui/admin/app/controllers/scopes/scope/credential-stores/credential-store/credential-libraries/credential-library.js b/ui/admin/app/controllers/scopes/scope/credential-stores/credential-store/credential-libraries/credential-library.js new file mode 100644 index 000000000..ec222f462 --- /dev/null +++ b/ui/admin/app/controllers/scopes/scope/credential-stores/credential-store/credential-libraries/credential-library.js @@ -0,0 +1,13 @@ +import Controller from '@ember/controller'; + +export default class ScopesScopeCredentialStoresCredentialStoreCredentialLibrariesCredentialLibraryController extends Controller { + // =attributes + + /** + * A model breadcrumb + * @type {string} + */ + get breadCrumb() { + return this.model.displayName; + } +} diff --git a/ui/admin/app/controllers/scopes/scope/credential-stores/new.js b/ui/admin/app/controllers/scopes/scope/credential-stores/new.js new file mode 100644 index 000000000..3f50abb13 --- /dev/null +++ b/ui/admin/app/controllers/scopes/scope/credential-stores/new.js @@ -0,0 +1,18 @@ +import Controller from '@ember/controller'; +import { inject as service } from '@ember/service'; + +export default class ScopesScopeCredentialStoresNewController extends Controller { + // =services + + @service intl; + + // =attributes + + /** + * Breadcrumb for new route + * @type {string} + */ + get breadCrumb() { + return this.intl.t('titles.new'); + } +} diff --git a/ui/admin/app/routes/scopes/scope/credential-stores/credential-store.js b/ui/admin/app/routes/scopes/scope/credential-stores/credential-store.js index 046b8a01c..e995f11b0 100644 --- a/ui/admin/app/routes/scopes/scope/credential-stores/credential-store.js +++ b/ui/admin/app/routes/scopes/scope/credential-stores/credential-store.js @@ -8,27 +8,4 @@ export default class ScopesScopeCredentialStoresCredentialStoreRoute extends Rou async model({ credential_store_id }) { return this.store.findRecord('credential-store', credential_store_id); } - - /** - * Render credential store header, navigation and actions page sections. - * @override - */ - renderTemplate() { - super.renderTemplate(...arguments); - - this.render('scopes/scope/credential-stores/credential-store/-header', { - into: 'scopes/scope/credential-stores/credential-store', - outlet: 'header', - }); - - this.render('scopes/scope/credential-stores/credential-store/-navigation', { - into: 'scopes/scope/credential-stores/credential-store', - outlet: 'navigation', - }); - - this.render('scopes/scope/credential-stores/credential-store/-actions', { - into: 'scopes/scope/credential-stores/credential-store', - outlet: 'actions', - }); - } } diff --git a/ui/admin/app/routes/scopes/scope/credential-stores/credential-store/credential-libraries.js b/ui/admin/app/routes/scopes/scope/credential-stores/credential-store/credential-libraries.js index a8f8db78a..09eec86c6 100644 --- a/ui/admin/app/routes/scopes/scope/credential-stores/credential-store/credential-libraries.js +++ b/ui/admin/app/routes/scopes/scope/credential-stores/credential-store/credential-libraries.js @@ -81,7 +81,7 @@ export default class ScopesScopeCredentialStoresCredentialStoreCredentialLibrari @confirm('questions.delete-confirm') @notifyError(({ message }) => message, { catch: true }) @notifySuccess('notifications.delete-success') - async delete(credentialLibrary) { + async deleteCredentialLibrary(credentialLibrary) { await credentialLibrary.destroyRecord(); await this.router.replaceWith( 'scopes.scope.credential-stores.credential-store.credential-libraries' diff --git a/ui/admin/app/routes/scopes/scope/credential-stores/credential-store/credential-libraries/credential-library.js b/ui/admin/app/routes/scopes/scope/credential-stores/credential-store/credential-libraries/credential-library.js index 45f5953fb..00b935f23 100644 --- a/ui/admin/app/routes/scopes/scope/credential-stores/credential-store/credential-libraries/credential-library.js +++ b/ui/admin/app/routes/scopes/scope/credential-stores/credential-store/credential-libraries/credential-library.js @@ -14,36 +14,4 @@ export default class ScopesScopeCredentialStoresCredentialStoreCredentialLibrari reload: true, }); } - - /** - * Renders the credential library specific templates for header, navigation, and action page sections. - * @override - */ - renderTemplate() { - super.renderTemplate(...arguments); - - this.render( - 'scopes/scope/credential-stores/credential-store/credential-libraries/credential-library/-header', - { - into: 'scopes/scope/credential-stores/credential-store', - outlet: 'header', - } - ); - - this.render( - 'scopes/scope/credential-stores/credential-store/credential-libraries/credential-library/-navigation', - { - into: 'scopes/scope/credential-stores/credential-store', - outlet: 'navigation', - } - ); - - this.render( - 'scopes/scope/credential-stores/credential-store/credential-libraries/credential-library/-actions', - { - into: 'scopes/scope/credential-stores/credential-store', - outlet: 'actions', - } - ); - } } diff --git a/ui/admin/app/routes/scopes/scope/credential-stores/credential-store/credential-libraries/new.js b/ui/admin/app/routes/scopes/scope/credential-stores/credential-store/credential-libraries/new.js index c9ccc770c..d6c3db15b 100644 --- a/ui/admin/app/routes/scopes/scope/credential-stores/credential-store/credential-libraries/new.js +++ b/ui/admin/app/routes/scopes/scope/credential-stores/credential-store/credential-libraries/new.js @@ -16,31 +16,4 @@ export default class ScopesScopeCredentialStoresCredentialStoreCredentialLibrari credential_store_id, }); } - - /** - * Renders new credential library specific templates for header, navigation, - * and action page sections. - * @override - */ - renderTemplate() { - super.renderTemplate(...arguments); - - this.render( - 'scopes/scope/credential-stores/credential-store/credential-libraries/new/-header', - { - into: 'scopes/scope/credential-stores/credential-store', - outlet: 'header', - } - ); - - this.render('_empty', { - into: 'scopes/scope/credential-stores/credential-store', - outlet: 'navigation', - }); - - this.render('_empty', { - into: 'scopes/scope/credential-stores/credential-store', - outlet: 'actions', - }); - } } diff --git a/ui/admin/app/templates/scopes/scope/credential-stores/credential-store.hbs b/ui/admin/app/templates/scopes/scope/credential-stores/credential-store.hbs index efc46641a..7d32ecb0d 100644 --- a/ui/admin/app/templates/scopes/scope/credential-stores/credential-store.hbs +++ b/ui/admin/app/templates/scopes/scope/credential-stores/credential-store.hbs @@ -1,24 +1,3 @@ {{page-title @model.displayName}} - - - - - - - - {{outlet 'header'}} - - - - {{outlet 'navigation'}} - - - - {{outlet 'actions'}} - - - - {{outlet}} - - \ No newline at end of file +{{outlet}} \ No newline at end of file diff --git a/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/credential-libraries/credential-library/-actions.hbs b/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/credential-libraries/credential-library/-actions.hbs deleted file mode 100644 index 4399f847b..000000000 --- a/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/credential-libraries/credential-library/-actions.hbs +++ /dev/null @@ -1,15 +0,0 @@ -{{#if (can 'delete model' @model)}} - - - {{t 'resources.credential-library.actions.delete'}} - - -{{/if}} \ No newline at end of file diff --git a/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/credential-libraries/credential-library/-header.hbs b/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/credential-libraries/credential-library/-header.hbs deleted file mode 100644 index 229448ada..000000000 --- a/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/credential-libraries/credential-library/-header.hbs +++ /dev/null @@ -1,12 +0,0 @@ -

- {{t 'resources.credential-library.title'}} - -

-

{{t 'resources.credential-library.description'}}

- - {{@model.id}} - \ No newline at end of file diff --git a/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/credential-libraries/credential-library/-navigation.hbs b/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/credential-libraries/credential-library/-navigation.hbs deleted file mode 100644 index d5bb5cf63..000000000 --- a/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/credential-libraries/credential-library/-navigation.hbs +++ /dev/null @@ -1,7 +0,0 @@ - - - {{t 'titles.details'}} - - \ No newline at end of file diff --git a/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/credential-libraries/credential-library/index.hbs b/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/credential-libraries/credential-library/index.hbs index 648221a43..fe4f7069e 100644 --- a/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/credential-libraries/credential-library/index.hbs +++ b/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/credential-libraries/credential-library/index.hbs @@ -1,5 +1,57 @@ - \ No newline at end of file + + + + + + + +

+ {{t 'resources.credential-library.title'}} + +

+

{{t 'resources.credential-library.description'}}

+ + {{@model.id}} + +
+ + + + + {{t 'titles.details'}} + + + + + + {{#if (can 'delete model' @model)}} + + + {{t 'resources.credential-library.actions.delete'}} + + + {{/if}} + + + + + +
\ No newline at end of file diff --git a/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/credential-libraries/index.hbs b/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/credential-libraries/index.hbs index 8f1b0ba98..d231ca381 100644 --- a/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/credential-libraries/index.hbs +++ b/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/credential-libraries/index.hbs @@ -1,102 +1,128 @@ -{{#if @model}} + - - - - {{t 'form.name.label'}} - {{t 'form.type.label'}} - {{t 'form.id.label'}} - - - - {{#each @model as |credentialLibrary|}} - - - {{#if (can 'read model' credentialLibrary)}} - - {{credentialLibrary.displayName}} - - {{else}} - {{credentialLibrary.displayName}} - {{/if}} -

{{credentialLibrary.description}}

-
- - {{t - (concat - 'resources.credential-library.types.' credentialLibrary.type - ) - }} - - - - {{credentialLibrary.id}} - - -
- {{/each}} -
-
+ + + -{{else}} + + + - - - - {{#if - (can - 'list collection' - this.credentialStore - collection='credential-libraries' - ) - }} - {{! can list (at least): show default welcome message}} - {{t 'resources.credential-library.description'}} + + + - {{else if (can - 'create collection' - this.credentialStore - collection='credential-libraries' - )}} - {{! can create (only): show create-but-not-list welcome message}} - {{t - 'descriptions.create-but-not-list' - resource=(t 'resources.credential-library.title_plural') - }} - {{else}} - {{! can neither list nor create }} - {{t - 'descriptions.neither-list-nor-create' - resource=(t 'resources.credential-library.title_plural') - }} - {{/if}} + + + - - {{#if - (can - 'create collection' - this.credentialStore - collection='credential-libraries' - ) - }} - + {{#if @model}} + + + + + {{t 'form.name.label'}} + {{t 'form.type.label'}} + {{t 'form.id.label'}} + + + + {{#each @model as |credentialLibrary|}} + + + {{#if (can 'read model' credentialLibrary)}} + + {{credentialLibrary.displayName}} + + {{else}} + {{credentialLibrary.displayName}} + {{/if}} +

{{credentialLibrary.description}}

+
+ + {{t + (concat + 'resources.credential-library.types.' + credentialLibrary.type + ) + }} + + + + {{credentialLibrary.id}} + + +
+ {{/each}} +
+
+ + {{else}} + + + - - {{t 'titles.new'}} -
- {{/if}} -
-
+ + {{#if + (can + 'list collection' + this.credentialStore + collection='credential-libraries' + ) + }} + {{! can list (at least): show default welcome message}} + {{t 'resources.credential-library.description'}} -{{/if}} \ No newline at end of file + {{else if (can + 'create collection' + this.credentialStore + collection='credential-libraries' + )}} + {{! can create (only): show create-but-not-list welcome message}} + {{t + 'descriptions.create-but-not-list' + resource=(t 'resources.credential-library.title_plural') + }} + {{else}} + {{! can neither list nor create }} + {{t + 'descriptions.neither-list-nor-create' + resource=(t 'resources.credential-library.title_plural') + }} + {{/if}} + + + {{#if + (can + 'create collection' + this.credentialStore + collection='credential-libraries' + ) + }} + + + {{t 'titles.new'}} + + {{/if}} + + + + {{/if}} + +
\ No newline at end of file diff --git a/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/credential-libraries/new.hbs b/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/credential-libraries/new.hbs index 5d03e5b9f..818471682 100644 --- a/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/credential-libraries/new.hbs +++ b/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/credential-libraries/new.hbs @@ -1,7 +1,22 @@ {{page-title (t 'titles.new')}} - \ No newline at end of file + + + + + + + +

+ {{t 'titles.new'}} +

+
+ + + + +
\ No newline at end of file diff --git a/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/credential-libraries/new/-header.hbs b/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/credential-libraries/new/-header.hbs deleted file mode 100644 index 51755b136..000000000 --- a/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/credential-libraries/new/-header.hbs +++ /dev/null @@ -1,3 +0,0 @@ -

- {{t 'titles.new'}} -

\ No newline at end of file diff --git a/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/index.hbs b/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/index.hbs index aaa14a18c..78a8548a2 100644 --- a/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/index.hbs +++ b/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/index.hbs @@ -1,5 +1,26 @@ - \ No newline at end of file + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file From a0a8aae13946077d0d720dfc72084d9a7054d74a Mon Sep 17 00:00:00 2001 From: Carlos Alcaide Corvo Date: Tue, 25 Jan 2022 08:22:26 -0800 Subject: [PATCH 4/4] =?UTF-8?q?chore:=20=F0=9F=A4=96=20Add=20follow-redire?= =?UTF-8?q?cts=20to=20resoltuions?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add follow-redirect to resolutions to avoid security vulnerability --- package.json | 3 ++- yarn.lock | 8 ++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index fff545633..ccb63380a 100755 --- a/package.json +++ b/package.json @@ -84,7 +84,8 @@ "ansi-regex": "^5.0.1", "ember-cli-babel": "^7.26.8", "jsonpointer": "5.0.0", - "json-schema": "^0.4.0" + "json-schema": "^0.4.0", + "follow-redirects": "^1.14.7" }, "config": { "commitizen": { diff --git a/yarn.lock b/yarn.lock index b013ddba4..71c3884be 100644 --- a/yarn.lock +++ b/yarn.lock @@ -13135,10 +13135,10 @@ focus-trap@^6.4.0: dependencies: tabbable "^5.2.1" -follow-redirects@^1.0.0: - version "1.14.1" - resolved "https://registry.yarnpkg.com/follow-redirects/-/follow-redirects-1.14.1.tgz#d9114ded0a1cfdd334e164e6662ad02bfd91ff43" - integrity sha512-HWqDgT7ZEkqRzBvc2s64vSZ/hfOceEol3ac/7tKwzuvEyWx3/4UegXh5oBOIotkGsObyk3xznnSRVADBgWSQVg== +follow-redirects@^1.0.0, follow-redirects@^1.14.7: + version "1.14.7" + resolved "https://registry.yarnpkg.com/follow-redirects/-/follow-redirects-1.14.7.tgz#2004c02eb9436eee9a21446a6477debf17e81685" + integrity sha512-+hbxoLbFMbRKDwohX8GkTataGqO6Jb7jGwpAlwgy2bIz25XtRm7KEzJM76R1WiNT5SwZkX4Y75SwBolkpmE7iQ== for-in@^1.0.2: version "1.0.2"