From 8f60066cc8d89aa0e4467395171cb74826ed1e4a Mon Sep 17 00:00:00 2001 From: dharini Date: Thu, 3 Mar 2022 14:17:11 -0800 Subject: [PATCH] =?UTF-8?q?fix:=20=F0=9F=90=9B=20remove=20sync=5Finterval?= =?UTF-8?q?=5Fseconds=20attribute=20from=20static=20type?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- addons/api/addon/serializers/host-set.js | 1 + addons/api/mirage/factories/host-set.js | 6 +++++- addons/api/tests/unit/serializers/host-set-test.js | 2 -- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/addons/api/addon/serializers/host-set.js b/addons/api/addon/serializers/host-set.js index bc56b304e..b90c607bc 100644 --- a/addons/api/addon/serializers/host-set.js +++ b/addons/api/addon/serializers/host-set.js @@ -55,6 +55,7 @@ export default class HostSetSerializer extends ApplicationSerializer { // Delete unnecessary fields for static type delete serialized.attributes; delete serialized.preferred_endpoints; + delete serialized.sync_interval_seconds; return serialized; } diff --git a/addons/api/mirage/factories/host-set.js b/addons/api/mirage/factories/host-set.js index 86c1bd8a0..c417c067c 100644 --- a/addons/api/mirage/factories/host-set.js +++ b/addons/api/mirage/factories/host-set.js @@ -29,7 +29,11 @@ export default factory.extend({ return result; } }, - sync_interval_seconds: () => datatype.number(), + sync_interval_seconds() { + if (this.type === 'plugin') { + return datatype.number(); + } + }, // AWS specific filters() { if (this.plugin?.name === 'aws') { diff --git a/addons/api/tests/unit/serializers/host-set-test.js b/addons/api/tests/unit/serializers/host-set-test.js index 6dbfafff7..6a3df242b 100644 --- a/addons/api/tests/unit/serializers/host-set-test.js +++ b/addons/api/tests/unit/serializers/host-set-test.js @@ -12,14 +12,12 @@ module('Unit | Serializer | host set', function (hooks) { compositeType: 'static', description: 'Description', host_catalog_id: '123', - sync_interval_seconds: 1, version: 1, }); assert.deepEqual(record.serialize(), { name: 'Host Set 1', description: 'Description', host_catalog_id: '123', - sync_interval_seconds: 1, version: 1, }); });