From 93fd52954f2f4127ba749591e480772b618a068a Mon Sep 17 00:00:00 2001
From: Randall Morey <randall@randallmorey.com>
Date: Mon, 14 Feb 2022 11:50:39 -0500
Subject: [PATCH] =?UTF-8?q?chore:=20=F0=9F=A4=96=20explicitly=20set=20secr?=
 =?UTF-8?q?ets=20to=20null=20when=20missing?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 addons/api/addon/serializers/application.js            | 2 +-
 addons/api/tests/unit/serializers/host-catalog-test.js | 8 ++++++++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/addons/api/addon/serializers/application.js b/addons/api/addon/serializers/application.js
index 0b20dd128..8f519e8e2 100644
--- a/addons/api/addon/serializers/application.js
+++ b/addons/api/addon/serializers/application.js
@@ -264,7 +264,7 @@ export default class ApplicationSerializer extends RESTSerializer {
         options: { isNestedSecret },
       } = attribute;
       const value = hash.secrets?.[name];
-      if (isNestedSecret) hash[name] = value;
+      if (isNestedSecret) hash[name] = value || null;
     });
     return hash;
   }
diff --git a/addons/api/tests/unit/serializers/host-catalog-test.js b/addons/api/tests/unit/serializers/host-catalog-test.js
index 8b1af8c94..2811dea39 100644
--- a/addons/api/tests/unit/serializers/host-catalog-test.js
+++ b/addons/api/tests/unit/serializers/host-catalog-test.js
@@ -190,6 +190,10 @@ module('Unit | Serializer | host catalog', function (hooks) {
           description: 'Test description',
           authorized_actions: ['no-op'],
           type: 'static',
+          access_key_id: null,
+          secret_access_key: null,
+          secret_id: null,
+          secret_value: null,
         },
         relationships: {},
       },
@@ -245,6 +249,8 @@ module('Unit | Serializer | host catalog', function (hooks) {
           region: 'Illinois',
           access_key_id: '0xF3B0a6f8',
           secret_access_key: 'zq{2:IVc8@W^',
+          secret_id: null,
+          secret_value: null,
         },
         relationships: {},
       },
@@ -304,6 +310,8 @@ module('Unit | Serializer | host catalog', function (hooks) {
           client_id: 'client',
           tenant_id: 'tenant',
           subscription_id: 'subscription',
+          access_key_id: null,
+          secret_access_key: null,
         },
         relationships: {},
       },