Types for aws host catalogs (#2514)

assume role dynamic AWS credentials

addons/api/tests/unit/serializers/host-catalog-test.js

@@ -5,6 +5,11 @@
 
 import { module, test } from 'qunit';
 import { setupTest } from 'ember-qunit';
+import {
+  TYPE_HOST_CATALOG_PLUGIN_AWS,
+  TYPE_CREDENTIAL_STATIC,
+  TYPE_CREDENTIAL_DYNAMIC,
+} from 'api/models/host-catalog';
 
 module('Unit | Serializer | host catalog', function (hooks) {
   setupTest(hooks);
@@ -31,15 +36,104 @@ module('Unit | Serializer | host catalog', function (hooks) {
     assert.deepEqual(record.serialize(), expectedResult);
   });
 
-  test('it serializes a new aws plugin as expected, ignoring azure fields', async function (assert) {
+  test('it serializes a new aws static plugin as expected', async function (assert) {
     const store = this.owner.lookup('service:store');
     const record = store.createRecord('host-catalog', {
-      compositeType: 'aws',
+      compositeType: TYPE_HOST_CATALOG_PLUGIN_AWS,
+      credentialType: TYPE_CREDENTIAL_STATIC,
       name: 'AWS',
       description: 'this is a Aws plugin host-catalog',
       disable_credential_rotation: true,
       worker_filter: 'workerfilter',
       // these are AWS fields and should be included
+      region: 'west',
+      access_key_id: 'foobars',
+      secret_access_key: 'testing',
+      // these are Azure fields and should be excluded
+      tenant_id: 'a1b2c3',
+      client_id: 'a1b2c3',
+      subscription_id: 'a1b2c3',
+      secret_id: 'a1b2c3',
+      secret_value: 'a1b2c3',
+      role_arn: 'test',
+      role_external_id: 'test',
+      role_session_name: 'test',
+      role_tags: [
+        { key: 'Project', value: 'Automation' },
+        { key: 'foo', value: 'bar' },
+      ],
+    });
+    const expectedResult = {
+      name: 'AWS',
+      description: 'this is a Aws plugin host-catalog',
+      type: 'plugin',
+      worker_filter: 'workerfilter',
+      attributes: {
+        disable_credential_rotation: true,
+        region: 'west',
+      },
+      secrets: {
+        access_key_id: 'foobars',
+        secret_access_key: 'testing',
+      },
+    };
+    assert.deepEqual(record.serialize(), expectedResult);
+  });
+
+  test('it serializes a new aws dynamic plugin as expected', async function (assert) {
+    const store = this.owner.lookup('service:store');
+    const record = store.createRecord('host-catalog', {
+      compositeType: TYPE_HOST_CATALOG_PLUGIN_AWS,
+      name: 'AWS',
+      credentialType: TYPE_CREDENTIAL_DYNAMIC,
+      description: 'this is a Aws plugin host-catalog',
+      disable_credential_rotation: true,
+      worker_filter: 'workerfilter',
+      // these are AWS fields and should be included
+      region: 'west',
+      access_key_id: 'foobars',
+      secret_access_key: 'testing',
+      // these are Azure fields and should be excluded
+      tenant_id: 'a1b2c3',
+      client_id: 'a1b2c3',
+      subscription_id: 'a1b2c3',
+      secret_id: 'a1b2c3',
+      secret_value: 'a1b2c3',
+      role_arn: 'test',
+      role_external_id: 'test',
+      role_session_name: 'test',
+      role_tags: [
+        { key: 'Project', value: 'Automation' },
+        { key: 'foo', value: 'bar' },
+      ],
+    });
+    const expectedResult = {
+      name: 'AWS',
+      description: 'this is a Aws plugin host-catalog',
+      type: 'plugin',
+      worker_filter: 'workerfilter',
+      attributes: {
+        disable_credential_rotation: true,
+        region: 'west',
+        role_external_id: 'test',
+        role_session_name: 'test',
+        role_arn: 'test',
+        role_tags: { Project: 'Automation', foo: 'bar' },
+      },
+    };
+    assert.deepEqual(record.serialize(), expectedResult);
+  });
+
+  test('it serializes a new aws static plugin as expected, ignoring azure fields', async function (assert) {
+    const store = this.owner.lookup('service:store');
+    const record = store.createRecord('host-catalog', {
+      compositeType: TYPE_HOST_CATALOG_PLUGIN_AWS,
+      name: 'AWS',
+      credentialType: TYPE_CREDENTIAL_STATIC,
+      description: 'this is a Aws plugin host-catalog',
+      disable_credential_rotation: true,
+      worker_filter: 'workerfilter',
+      // these are AWS fields and should be included
       region: 'spain',
       access_key_id: 'foobars',
       secret_access_key: 'testing',
@@ -109,6 +203,7 @@ module('Unit | Serializer | host catalog', function (hooks) {
       data: {
         id: '1',
         type: 'host-catalog',
+        credentialType: 'static',
         attributes: {
           type: 'plugin',
           name: 'aws',