From 9a43c74e608b57070a37a9e68c800faa9b0803dd Mon Sep 17 00:00:00 2001
From: Lisbet Alvarez <107949262+lisbet-alvarez@users.noreply.github.com>
Date: Thu, 4 Apr 2024 17:22:04 -0700
Subject: [PATCH] =?UTF-8?q?refactor:=20=F0=9F=92=A1=20add=20active=20sessi?=
 =?UTF-8?q?ons=20column=20to=20targets=20table=20(#2196)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* refactor: 💡 add active sessions column to targets table

✅ Closes: https://hashicorp.atlassian.net/browse/ICU-13085

* test: 💍 add test case

✅ Closes: https://hashicorp.atlassian.net/browse/ICU-13085
---
 .../templates/scopes/scope/sessions/index.hbs |  2 +-
 .../templates/scopes/scope/targets/index.hbs  | 25 ++++++++-
 .../tests/acceptance/targets/list-test.js     | 56 ++++++++++++-------
 3 files changed, 61 insertions(+), 22 deletions(-)

diff --git a/ui/admin/app/templates/scopes/scope/sessions/index.hbs b/ui/admin/app/templates/scopes/scope/sessions/index.hbs
index 528e5ac6e..d4a631e47 100644
--- a/ui/admin/app/templates/scopes/scope/sessions/index.hbs
+++ b/ui/admin/app/templates/scopes/scope/sessions/index.hbs
@@ -92,7 +92,7 @@
           @valign='middle'
         >
           <:body as |B|>
-            <B.Tr>
+            <B.Tr data-test-sessions-table-row={{B.data.id}}>
               <B.Td>
                 <Hds::Copy::Snippet
                   data-test-session={{B.data.id}}
diff --git a/ui/admin/app/templates/scopes/scope/targets/index.hbs b/ui/admin/app/templates/scopes/scope/targets/index.hbs
index b09726036..f65bedbc0 100644
--- a/ui/admin/app/templates/scopes/scope/targets/index.hbs
+++ b/ui/admin/app/templates/scopes/scope/targets/index.hbs
@@ -66,6 +66,7 @@
           @columns={{array
             (hash label=(t 'form.name.label'))
             (hash label=(t 'form.type.label'))
+            (hash label=(t 'resources.target.titles.active-sessions'))
             (hash label=(t 'form.id.label'))
           }}
           @model={{@model.targets}}
@@ -74,7 +75,7 @@
         >
           <:body as |B|>
             {{#if (feature-flag 'ssh-target')}}
-              <B.Tr>
+              <B.Tr data-test-targets-table-row={{B.data.id}}>
                 <B.Td>
                   {{#if (can 'read model' B.data)}}
                     <LinkTo
@@ -95,6 +96,16 @@
                     />
                   {{/if}}
                 </B.Td>
+                <B.Td>
+                  {{#if B.data.isActive}}
+                    <Hds::Link::Standalone
+                      @text={{t 'actions.yes'}}
+                      @route='scopes.scope.sessions.index'
+                      @query={{hash targets=(array B.data.id)}}
+                      @icon='info'
+                    />
+                  {{/if}}
+                </B.Td>
                 <B.Td>
                   <Hds::Copy::Snippet
                     @textToCopy={{B.data.id}}
@@ -104,7 +115,7 @@
               </B.Tr>
             {{else}}
               {{#if B.data.isTCP}}
-                <B.Tr>
+                <B.Tr data-test-targets-table-row={{B.data.id}}>
                   <B.Td>
                     {{#if (can 'read model' B.data)}}
                       <LinkTo
@@ -127,6 +138,16 @@
                       />
                     {{/if}}
                   </B.Td>
+                  <B.Td>
+                    {{#if B.data.isActive}}
+                      <Hds::Link::Standalone
+                        @text={{t 'actions.yes'}}
+                        @route='scopes.scope.sessions.index'
+                        @query={{hash targets=(array B.data.id)}}
+                        @icon='info'
+                      />
+                    {{/if}}
+                  </B.Td>
                   <B.Td>
                     <Hds::Copy::Snippet
                       @textToCopy={{B.data.id}}
diff --git a/ui/admin/tests/acceptance/targets/list-test.js b/ui/admin/tests/acceptance/targets/list-test.js
index d80e4d6e7..86c829053 100644
--- a/ui/admin/tests/acceptance/targets/list-test.js
+++ b/ui/admin/tests/acceptance/targets/list-test.js
@@ -4,7 +4,13 @@
  */
 
 import { module, test } from 'qunit';
-import { visit, click, fillIn, waitUntil, findAll } from '@ember/test-helpers';
+import {
+  visit,
+  click,
+  fillIn,
+  waitFor,
+  currentRouteName,
+} from '@ember/test-helpers';
 import { setupApplicationTest } from 'ember-qunit';
 import setupMirage from 'ember-cli-mirage/test-support/setup-mirage';
 import { setupIndexedDb } from 'api/test-support/helpers/indexed-db';
@@ -15,6 +21,7 @@ import {
   //invalidateSession,
 } from 'ember-simple-auth/test-support';
 import { TYPE_TARGET_TCP, TYPE_TARGET_SSH } from 'api/models/target';
+import { STATUS_SESSION_ACTIVE } from 'api/models/session';
 
 module('Acceptance | targets | list', function (hooks) {
   setupApplicationTest(hooks);
@@ -23,16 +30,14 @@ module('Acceptance | targets | list', function (hooks) {
 
   const SEARCH_INPUT_SELECTOR = '.search-filtering [type="search"]';
   const NO_RESULTS_MSG_SELECTOR = '[data-test-no-target-results]';
-  const TYPE_FILTER_DROPDOWN_SELECTOR =
-    '.search-filtering [name="type"] button';
-  const TCP_TYPE_FILTER_OPTION_SELECTOR =
-    '.search-filtering [name="type"] [data-test-checkbox="tcp"]';
+  const FILTER_DROPDOWN_SELECTOR = (name) =>
+    `.search-filtering [name="${name}"] button`;
   const FILTER_APPLY_BUTTON_SELECTOR =
     '.search-filtering [data-test-dropdown-apply-button]';
-  const ACTIVE_SESSIONS_FILTER_DROPDOWN_SELECTOR =
-    '.search-filtering [name="active-sessions"] button';
-  const YES_FILTER_OPTION_SELECTOR =
-    '.search-filtering [name="active-sessions"] [data-test-checkbox="yes"]';
+  const ACTIVE_SESSIONS_SELECTOR = (id) =>
+    `tbody [data-test-targets-table-row="${id}"] .hds-table__td:nth-child(3) a`;
+  const SESSIONS_ID_SELECTOR = (id) =>
+    `tbody [data-test-sessions-table-row="${id}"] .hds-table__td:first-child`;
 
   const instances = {
     scopes: {
@@ -42,6 +47,7 @@ module('Acceptance | targets | list', function (hooks) {
     },
     tcpTarget: null,
     sshTarget: null,
+    session: null,
   };
 
   const urls = {
@@ -71,6 +77,11 @@ module('Acceptance | targets | list', function (hooks) {
       type: TYPE_TARGET_SSH,
       scope: instances.scopes.project,
     });
+    instances.session = this.server.create('session', {
+      targetId: instances.sshTarget.id,
+      scope: instances.scopes.project,
+      status: STATUS_SESSION_ACTIVE,
+    });
     urls.orgScope = `/scopes/${instances.scopes.org.id}/scopes`;
     urls.projectScope = `/scopes/${instances.scopes.project.id}`;
     urls.targets = `${urls.projectScope}/targets`;
@@ -174,7 +185,7 @@ module('Acceptance | targets | list', function (hooks) {
     assert.dom(`[href="${urls.sshTarget}"]`).exists();
 
     await fillIn(SEARCH_INPUT_SELECTOR, instances.sshTarget.id);
-    await waitUntil(() => findAll(`[href="${urls.tcpTarget}"]`).length === 0);
+    await waitFor(`[href="${urls.tcpTarget}"]`, { count: 0 });
 
     assert.dom(`[href="${urls.sshTarget}"]`).exists();
     assert.dom(`[href="${urls.tcpTarget}"]`).doesNotExist();
@@ -189,7 +200,7 @@ module('Acceptance | targets | list', function (hooks) {
     assert.dom(`[href="${urls.sshTarget}"]`).exists();
 
     await fillIn(SEARCH_INPUT_SELECTOR, 'fake target that does not exist');
-    await waitUntil(() => findAll(NO_RESULTS_MSG_SELECTOR).length === 1);
+    await waitFor(NO_RESULTS_MSG_SELECTOR, { count: 1 });
 
     assert.dom(`[href="${urls.sshTarget}"]`).doesNotExist();
     assert.dom(`[href="${urls.tcpTarget}"]`).doesNotExist();
@@ -204,10 +215,9 @@ module('Acceptance | targets | list', function (hooks) {
     assert.dom(`[href="${urls.tcpTarget}"]`).exists();
     assert.dom(`[href="${urls.sshTarget}"]`).exists();
 
-    await click(TYPE_FILTER_DROPDOWN_SELECTOR);
-    await click(TCP_TYPE_FILTER_OPTION_SELECTOR);
+    await click(FILTER_DROPDOWN_SELECTOR('type'));
+    await click(`input[value="tcp"]`);
     await click(FILTER_APPLY_BUTTON_SELECTOR);
-    await waitUntil(() => findAll(`[href="${urls.sshTarget}"]`).length === 0);
 
     assert.dom(`[href="${urls.sshTarget}"]`).doesNotExist();
     assert.dom(`[href="${urls.tcpTarget}"]`).exists();
@@ -221,13 +231,21 @@ module('Acceptance | targets | list', function (hooks) {
     assert.dom(`[href="${urls.tcpTarget}"]`).exists();
     assert.dom(`[href="${urls.sshTarget}"]`).exists();
 
-    await click(ACTIVE_SESSIONS_FILTER_DROPDOWN_SELECTOR);
-    await click(YES_FILTER_OPTION_SELECTOR);
+    await click(FILTER_DROPDOWN_SELECTOR('active-sessions'));
+    await click(`input[value="yes"]`);
     await click(FILTER_APPLY_BUTTON_SELECTOR);
-    await waitUntil(() => findAll(NO_RESULTS_MSG_SELECTOR).length === 1);
 
-    assert.dom(`[href="${urls.sshTarget}"]`).doesNotExist();
+    assert.dom(`[href="${urls.sshTarget}"]`).exists();
     assert.dom(`[href="${urls.tcpTarget}"]`).doesNotExist();
-    assert.dom(NO_RESULTS_MSG_SELECTOR).includesText('No results found');
+  });
+
+  test('user can navigate to active sessions from targets table', async function (assert) {
+    await visit(urls.projectScope);
+
+    await click(`[href="${urls.targets}"]`);
+    await click(ACTIVE_SESSIONS_SELECTOR(instances.sshTarget.id));
+
+    assert.strictEqual(currentRouteName(), 'scopes.scope.sessions.index');
+    assert.dom(SESSIONS_ID_SELECTOR(instances.session.id)).exists();
   });
 });