From 9e0467cbf08822a23973c4cd27aad0276d011ba3 Mon Sep 17 00:00:00 2001
From: Lisbet Alvarez <107949262+lisbet-alvarez@users.noreply.github.com>
Date: Wed, 17 Jan 2024 08:37:09 -0800
Subject: [PATCH] =?UTF-8?q?refactor:=20=F0=9F=92=A1=20add=20global=20setti?=
 =?UTF-8?q?ngs=20link=20(#2093)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

 refactor: 💡 add global settings link (#2093)
---
 addons/api/mirage/factories/scope.js          | 23 ++++---
 addons/core/translations/resources/en-us.yaml |  6 ++
 ui/admin/app/components/form/scope/index.hbs  |  2 +-
 .../scopes/scope/add-storage-policy/index.js  | 13 +---
 ui/admin/app/templates/scopes/scope.hbs       | 10 +++
 ui/admin/app/templates/scopes/scope/edit.hbs  | 19 +++++-
 ui/admin/tests/acceptance/scopes/read-test.js | 62 ++++++++++++++++++-
 7 files changed, 112 insertions(+), 23 deletions(-)

diff --git a/addons/api/mirage/factories/scope.js b/addons/api/mirage/factories/scope.js
index 79dcbd872..6bedf3406 100644
--- a/addons/api/mirage/factories/scope.js
+++ b/addons/api/mirage/factories/scope.js
@@ -11,15 +11,20 @@ import generateId from '../helpers/id';
 export default factory.extend({
   type: 'global',
 
-  authorized_actions: () =>
-    permissions.authorizedActionsFor('scope') || [
-      'no-op',
-      'read',
-      'update',
-      'delete',
-      'attach-storage-policy',
-      'detach-storage-policy',
-    ],
+  authorized_actions() {
+    const authorizedActions = ['no-op', 'read', 'update'];
+
+    // Storage policies can only be attatched to global and org scopes.
+    if (this.type === 'global' || this.type === 'org') {
+      authorizedActions.push('attach-storage-policy', 'detach-storage-policy');
+    }
+
+    if (this.type === 'org' || this.type === 'project') {
+      authorizedActions.push('delete');
+    }
+
+    return permissions.authorizedActionsFor('scope') || authorizedActions;
+  },
 
   authorized_collection_actions() {
     const collectionActions = {
diff --git a/addons/core/translations/resources/en-us.yaml b/addons/core/translations/resources/en-us.yaml
index 17dd1b9f1..7e9325c6f 100644
--- a/addons/core/translations/resources/en-us.yaml
+++ b/addons/core/translations/resources/en-us.yaml
@@ -326,6 +326,12 @@ session:
     address-port: Address & port
     ssh: SSH
   shell: Shell
+global:
+  title: Global
+  description: The global scope is the outermost scope. There is always a single global scope and it cannot be deleted.
+  messages:
+    settings:
+      title: Global Settings
 org:
   title: Org
   title_plural: Orgs
diff --git a/ui/admin/app/components/form/scope/index.hbs b/ui/admin/app/components/form/scope/index.hbs
index 1f12c8f0f..3aa48c5c9 100644
--- a/ui/admin/app/components/form/scope/index.hbs
+++ b/ui/admin/app/components/form/scope/index.hbs
@@ -51,7 +51,7 @@
     {{/if}}
   </Hds::Form::Textarea::Field>
 
-  {{#if (can 'save model' @model)}}
+  {{#if (and (can 'save model' @model) (not @model.isGlobal))}}
     <form.actions
       @enableEditText={{t 'actions.edit-form'}}
       @submitText={{t 'actions.save'}}
diff --git a/ui/admin/app/routes/scopes/scope/add-storage-policy/index.js b/ui/admin/app/routes/scopes/scope/add-storage-policy/index.js
index 4dcacdcac..91d0ba0ec 100644
--- a/ui/admin/app/routes/scopes/scope/add-storage-policy/index.js
+++ b/ui/admin/app/routes/scopes/scope/add-storage-policy/index.js
@@ -17,25 +17,18 @@ export default class ScopesScopeAddStoragePolicyIndexRoute extends Route {
   // =methods
 
   /**
-   * Load polcies from global and current scope
+   * Load policies from current scope
    * @param {Model} model
    */
   async afterModel() {
     const { id: scope_id } = this.modelFor('scopes.scope');
 
-    //fetch policies from global scope
-    const globalScopePolicies = await this.store.query('policy', {
-      scope_id: 'global',
-    });
-
-    //fetch policies from org scope
+    //fetch policies from current scope
     const orgScopePolicies = await this.store.query('policy', {
       scope_id,
     });
 
-    const policyList = [...globalScopePolicies, ...orgScopePolicies];
-
-    this.policyList = policyList;
+    this.policyList = orgScopePolicies;
   }
 
   /**
diff --git a/ui/admin/app/templates/scopes/scope.hbs b/ui/admin/app/templates/scopes/scope.hbs
index c31b9319e..21562c4fe 100644
--- a/ui/admin/app/templates/scopes/scope.hbs
+++ b/ui/admin/app/templates/scopes/scope.hbs
@@ -199,6 +199,16 @@
         {{/unless}}
       </Rose::Nav::Sidebar>
 
+      {{#if (and @model.isGlobal (feature-flag 'ssh-session-recording'))}}
+        {{#if this.session.data.authenticated.isGlobal}}
+          <Rose::Nav::Sidebar @title={{t 'titles.settings'}} as |nav|>
+            <nav.link @route='scopes.scope.edit'>
+              {{t 'resources.global.messages.settings.title'}}
+            </nav.link>
+          </Rose::Nav::Sidebar>
+        {{/if}}
+      {{/if}}
+
       {{#if @model.isOrg}}
         {{#if this.session.data.authenticated.isGlobal}}
           <Rose::Nav::Sidebar @title={{t 'titles.settings'}} as |nav|>
diff --git a/ui/admin/app/templates/scopes/scope/edit.hbs b/ui/admin/app/templates/scopes/scope/edit.hbs
index e92053ac1..67ee9a020 100644
--- a/ui/admin/app/templates/scopes/scope/edit.hbs
+++ b/ui/admin/app/templates/scopes/scope/edit.hbs
@@ -3,6 +3,16 @@
   SPDX-License-Identifier: MPL-2.0
 }}
 
+{{#if @model.isGlobal}}
+  {{page-title (t 'resources.global.title')}}
+  <Breadcrumbs::Item
+    @text={{t 'resources.global.title'}}
+    @icon='globe'
+    @route='scopes.scope.edit'
+    @model={{@model.id}}
+  />
+{{/if}}
+
 <Rose::Layout::Page as |page|>
 
   <page.breadcrumbs>
@@ -10,6 +20,13 @@
   </page.breadcrumbs>
 
   <page.header>
+    {{#if @model.isGlobal}}
+      <h2>
+        {{t 'resources.global.title'}}
+        {{! TODO: Add doc link }}
+      </h2>
+      <p>{{t 'resources.global.description'}}</p>
+    {{/if}}
     {{#if @model.isOrg}}
       <h2>
         {{t 'resources.org.title'}}
@@ -43,7 +60,7 @@
     </page.navigation>
   {{/if}}
 
-  {{#if (can 'delete model' @model)}}
+  {{#if (and (can 'delete model' @model) (not @model.isGlobal))}}
     <page.actions>
       <Rose::Dropdown
         @text={{t 'actions.manage'}}
diff --git a/ui/admin/tests/acceptance/scopes/read-test.js b/ui/admin/tests/acceptance/scopes/read-test.js
index 779ca55b3..9342e9b1c 100644
--- a/ui/admin/tests/acceptance/scopes/read-test.js
+++ b/ui/admin/tests/acceptance/scopes/read-test.js
@@ -19,6 +19,15 @@ module('Acceptance | scopes | read', function (hooks) {
   setupApplicationTest(hooks);
   setupMirage(hooks);
 
+  let features;
+  let featureEdition;
+
+  const FORM_SELECTOR = 'main .rose-form';
+  const FORM_ACTIONS_SELECTOR = '.rose-form-actions';
+  const DELETE_DROPDOWN_SELECTOR =
+    '.rose-layout-page-actions .rose-dropdown-button-danger';
+  const STORAGE_POLICY_SIDEBAR = '.policy-sidebar';
+
   const instances = {
     scopes: {
       global: null,
@@ -26,6 +35,8 @@ module('Acceptance | scopes | read', function (hooks) {
     },
   };
   const urls = {
+    globalScope: null,
+    globalScopeEdit: null,
     orgScope: null,
     orgScopeEdit: null,
   };
@@ -38,8 +49,12 @@ module('Acceptance | scopes | read', function (hooks) {
       scope: { id: 'global', type: 'global' },
     });
     // Generate route URLs for resources
+    urls.globalScope = `/scopes/global/scopes`;
+    urls.globalScopeEdit = `/scopes/global/edit`;
     urls.orgScope = `/scopes/${instances.scopes.org.id}/scopes`;
     urls.orgScopeEdit = `/scopes/${instances.scopes.org.id}/edit`;
+    features = this.owner.lookup('service:features');
+    featureEdition = this.owner.lookup('service:featureEdition');
     authenticateSession({ isGlobal: true });
   });
 
@@ -51,7 +66,50 @@ module('Acceptance | scopes | read', function (hooks) {
     await a11yAudit();
 
     assert.strictEqual(currentURL(), urls.orgScopeEdit);
-    assert.dom('main .rose-form').exists();
+    assert.dom(FORM_SELECTOR).exists();
+    assert.dom(FORM_ACTIONS_SELECTOR).exists();
+    assert.dom(DELETE_DROPDOWN_SELECTOR).exists();
+  });
+
+  test('visiting global scope settings when feature flag is enabled', async function (assert) {
+    features.enable('ssh-session-recording');
+    await visit(urls.globalScope);
+    await a11yAudit();
+
+    await click(`[href="${urls.globalScopeEdit}"]`);
+    await a11yAudit();
+
+    assert.strictEqual(currentURL(), urls.globalScopeEdit);
+    assert.dom(FORM_SELECTOR).exists();
+    assert.dom(FORM_ACTIONS_SELECTOR).doesNotExist();
+    assert.dom(DELETE_DROPDOWN_SELECTOR).doesNotExist();
+  });
+
+  test('user cannot visit global scope settings when feature flag is not enabled', async function (assert) {
+    await visit(urls.globalScope);
+
+    assert.strictEqual(currentURL(), urls.globalScope);
+    assert.dom(`[href="${urls.globalScopeEdit}"]`).doesNotExist();
+  });
+
+  test('user can attatch a storage policy to a scope in enterprise edition', async function (assert) {
+    featureEdition.setEdition('enterprise', ['ssh-session-recording']);
+    await visit(urls.globalScope);
+
+    await click(`[href="${urls.globalScopeEdit}"]`);
+
+    assert.strictEqual(currentURL(), urls.globalScopeEdit);
+    assert.dom(STORAGE_POLICY_SIDEBAR).exists();
+  });
+
+  test('user can attatch a storage policy to a scope in hcp edition', async function (assert) {
+    featureEdition.setEdition('hcp', ['ssh-session-recording']);
+    await visit(urls.globalScope);
+
+    await click(`[href="${urls.globalScopeEdit}"]`);
+
+    assert.strictEqual(currentURL(), urls.globalScopeEdit);
+    assert.dom(STORAGE_POLICY_SIDEBAR).exists();
   });
 
   test('visiting org scope edit without read permission results in no form displayed', async function (assert) {
@@ -64,6 +122,6 @@ module('Acceptance | scopes | read', function (hooks) {
 
     await click(`[href="${urls.orgScopeEdit}"]`);
     assert.strictEqual(currentURL(), urls.orgScopeEdit);
-    assert.dom('main .rose-form').doesNotExist();
+    assert.dom(FORM_SELECTOR).doesNotExist();
   });
 });