From 9eccbb91db221d4505b539a5bf89074de8aeed8c Mon Sep 17 00:00:00 2001
From: Lisbet Alvarez <107949262+lisbet-alvarez@users.noreply.github.com>
Date: Thu, 9 Jan 2025 15:18:17 -0800
Subject: [PATCH] =?UTF-8?q?refactor:=20=F0=9F=92=A1=20Update=20name=20radi?=
 =?UTF-8?q?o=20option=20label=20&=20set=20toggle=20default=20to=20on=20(#2?=
 =?UTF-8?q?652)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* refactor: 💡 Update name radio option label & default toggle on
---
 addons/core/translations/en-us.yaml           |  2 +-
 .../worker-filter-generator/index.hbs         |  1 +
 .../worker-filter-generator/index.js          |  2 +-
 .../worker-filter-generator/index-test.js     | 21 ++++++++++++++-----
 4 files changed, 19 insertions(+), 7 deletions(-)

diff --git a/addons/core/translations/en-us.yaml b/addons/core/translations/en-us.yaml
index 5aabdfa9d..1850af1bf 100644
--- a/addons/core/translations/en-us.yaml
+++ b/addons/core/translations/en-us.yaml
@@ -156,5 +156,5 @@ worker-filter-generator:
     label: Name
     helper: Format a worker name
   operator:
-    matches: matches
+    matches: matches (regex)
     contains: contains
diff --git a/ui/admin/app/components/worker-filter-generator/index.hbs b/ui/admin/app/components/worker-filter-generator/index.hbs
index 8a214ddb3..761e69799 100644
--- a/ui/admin/app/components/worker-filter-generator/index.hbs
+++ b/ui/admin/app/components/worker-filter-generator/index.hbs
@@ -32,6 +32,7 @@
 <Hds::Separator />
 
 <Hds::Form::Toggle::Field
+  checked={{this.showFilterGenerator}}
   name='show_filter_generator'
   {{on 'change' this.toggleFilterGenerator}}
   as |F|
diff --git a/ui/admin/app/components/worker-filter-generator/index.js b/ui/admin/app/components/worker-filter-generator/index.js
index bd3afe7e7..470903b14 100644
--- a/ui/admin/app/components/worker-filter-generator/index.js
+++ b/ui/admin/app/components/worker-filter-generator/index.js
@@ -13,7 +13,7 @@ export default class WorkerFilterGeneratorIndexComponent extends Component {
   generatorTagType = 'tag';
   generatorNameType = 'name';
   operatorOptions = ['==', 'matches', 'contains'];
-  @tracked showFilterGenerator;
+  @tracked showFilterGenerator = true;
   @tracked selectedGeneratorType = this.generatorTagType;
   @tracked key = '';
   @tracked value = '';
diff --git a/ui/admin/tests/integration/components/worker-filter-generator/index-test.js b/ui/admin/tests/integration/components/worker-filter-generator/index-test.js
index 285bde339..c09731ba0 100644
--- a/ui/admin/tests/integration/components/worker-filter-generator/index-test.js
+++ b/ui/admin/tests/integration/components/worker-filter-generator/index-test.js
@@ -53,6 +53,10 @@ module(
         hbs`<WorkerFilterGenerator @name='ingress_worker_filter' @model={{this.model}} />`,
       );
 
+      assert.dom(FILTER_GENERATOR).isVisible();
+
+      await click(SHOW_FILTER_GENERATOR);
+
       assert.dom(FILTER_GENERATOR).isNotVisible();
 
       await click(SHOW_FILTER_GENERATOR);
@@ -65,7 +69,9 @@ module(
       await render(
         hbs`<WorkerFilterGenerator @name='ingress_worker_filter' @model={{this.model}} />`,
       );
-      await click(SHOW_FILTER_GENERATOR);
+
+      assert.dom(FILTER_GENERATOR).isVisible();
+
       await click(TAG_TYPE_OPTION);
 
       assert.dom(TAG_KEY).isVisible();
@@ -78,7 +84,9 @@ module(
       await render(
         hbs`<WorkerFilterGenerator @name='ingress_worker_filter' @model={{this.model}} />`,
       );
-      await click(SHOW_FILTER_GENERATOR);
+
+      assert.dom(FILTER_GENERATOR).isVisible();
+
       await click(TAG_TYPE_OPTION);
       await fillIn(TAG_KEY, 'key1');
       await fillIn(TAG_VALUE, 'val1');
@@ -92,7 +100,8 @@ module(
         hbs`<WorkerFilterGenerator @name='ingress_worker_filter' @model={{this.model}} />`,
       );
 
-      await click(SHOW_FILTER_GENERATOR);
+      assert.dom(FILTER_GENERATOR).isVisible();
+
       await click(NAME_TYPE_OPTION);
 
       assert.dom(NAME_OPERATOR).isVisible();
@@ -106,7 +115,8 @@ module(
         hbs`<WorkerFilterGenerator @name='ingress_worker_filter' @model={{this.model}} />`,
       );
 
-      await click(SHOW_FILTER_GENERATOR);
+      assert.dom(FILTER_GENERATOR).isVisible();
+
       await click(NAME_TYPE_OPTION);
       await fillIn(TAG_VALUE, 'val1');
       await select(NAME_OPERATOR, '==');
@@ -120,7 +130,8 @@ module(
         hbs`<WorkerFilterGenerator @name='ingress_worker_filter' @model={{this.model}} />`,
       );
 
-      await click(SHOW_FILTER_GENERATOR);
+      assert.dom(FILTER_GENERATOR).isVisible();
+
       await click(NAME_TYPE_OPTION);
       await fillIn(TAG_VALUE, 'val1');
       await select(NAME_OPERATOR, '==');