From a07cd9e1a13a0a28713afda0d203e9ea0e6957e8 Mon Sep 17 00:00:00 2001 From: Carlos Alcaide Date: Mon, 26 Jul 2021 13:09:08 -0700 Subject: [PATCH] =?UTF-8?q?refactor:=20=F0=9F=92=A1=20Allow=20external=20l?= =?UTF-8?q?inks=20just=20for=20specific=20domain?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Allow external links just for boundary.io domain. So far the only urls we want to open externally are our own documentation --- ui/desktop/electron-app/src/index.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ui/desktop/electron-app/src/index.js b/ui/desktop/electron-app/src/index.js index a08bfba96..8c303a7ee 100644 --- a/ui/desktop/electron-app/src/index.js +++ b/ui/desktop/electron-app/src/index.js @@ -167,10 +167,11 @@ app.on('ready', async () => { /* eng-disable LIMIT_NAVIGATION_JS_CHECK */ if (!url.startsWith('serve://boundary')) event.preventDefault(); }); - // Also opens links with target="_blank" in a browser window + // Opens external links in the host default browser. + // We just allow boundaryproject.io domain to open on external window (for now). mainWindow.webContents.on('new-window', (event, url) => { /* eng-disable LIMIT_NAVIGATION_JS_CHECK */ - if (!url.startsWith('serve://boundary')) { + if (url.startsWith('https://boundaryproject.io/')) { event.preventDefault(); shell.openExternal(url); }