From a6de02de07d9bd4d485109d6e88855f111d21aa0 Mon Sep 17 00:00:00 2001
From: Randall Morey <randall@randallmorey.com>
Date: Sat, 3 Oct 2020 14:11:54 -0400
Subject: [PATCH] chore: pass correct disabled args and reconsider cancel flow
 on set password

---
 .../account/password/change-password/index.hbs  |  2 +-
 .../acceptance/accounts/set-password-test.js    | 17 ++++++++++-------
 2 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/ui/core/app/components/form/account/password/change-password/index.hbs b/ui/core/app/components/form/account/password/change-password/index.hbs
index 156bc26d1..24548e843 100644
--- a/ui/core/app/components/form/account/password/change-password/index.hbs
+++ b/ui/core/app/components/form/account/password/change-password/index.hbs
@@ -44,7 +44,7 @@
   </form.input>
 
   <form.actions
-    @disabled={{this.cannotSave}}
+    @submitDisabled={{this.cannotSave}}
     @submitText={{t "actions.save"}}
     @cancelText={{t "actions.cancel"}} />
 
diff --git a/ui/core/tests/acceptance/accounts/set-password-test.js b/ui/core/tests/acceptance/accounts/set-password-test.js
index 545f4642c..d03dff3d1 100644
--- a/ui/core/tests/acceptance/accounts/set-password-test.js
+++ b/ui/core/tests/acceptance/accounts/set-password-test.js
@@ -71,13 +71,16 @@ module('Acceptance | accounts | set password', function (hooks) {
     await a11yAudit();
   });
 
-  test('can cancel setting new password', async function (assert) {
-    assert.expect(1);
-    await visit(urls.setPassword);
-    await fillIn('[name="password"]', 'update password');
-    await click('form button:not([type="submit"])');
-    assert.notOk(find('[name="password"]').textContent.trim());
-  });
+  // NOTE: since set password is a tabbed route with easy navigation away
+  // from the form, and the form does not directly operate on a model instance,
+  // a "cancel" flow doesn't make much sense.  Disabling for now.
+  // test('can cancel setting new password', async function (assert) {
+  //   assert.expect(1);
+  //   await visit(urls.setPassword);
+  //   await fillIn('[name="password"]', 'update password');
+  //   await click('form button:not([type="submit"])');
+  //   assert.notOk(find('[name="password"]').textContent.trim());
+  // });
 
   test('errors are displayed when setting password fails', async function  (assert) {
     assert.expect(1);