From adfa118ae55fa3918a48420cfb6b7534691e9fb9 Mon Sep 17 00:00:00 2001
From: Devon Anderson <devon.anderson@hashicorp.com>
Date: Fri, 5 Jan 2024 12:23:46 -0500
Subject: [PATCH] =?UTF-8?q?refactor:=20=F0=9F=92=A1=20Migrate=20`credentia?=
 =?UTF-8?q?ls-list`=20to=20`Hds::Table`=20(#2059)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* refactor: 💡 Migrate `credentials-list` to `Hds::Table`

Migrate `credentials-list` to `Hds::Table`

✅ Closes: https://hashicorp.atlassian.net/browse/ICU-11725

* refactor: 💡 Refactor table to use `B.data`

Originally the Proxy(Array) was not being taking in as a correct model
object when using the `@columns` synthax, now it seems to work perfectly
fine.

✅ Closes: https://hashicorp.atlassian.net/browse/ICU-11725
---
 .../credential-store/credentials/index.hbs    | 78 +++++++++----------
 .../credential-store/credentials/list-test.js |  2 +-
 2 files changed, 40 insertions(+), 40 deletions(-)

diff --git a/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/credentials/index.hbs b/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/credentials/index.hbs
index 587f9f3c0..89c1d3441 100644
--- a/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/credentials/index.hbs
+++ b/ui/admin/app/templates/scopes/scope/credential-stores/credential-store/credentials/index.hbs
@@ -28,46 +28,46 @@
   <page.body>
     {{#if @model}}
 
-      <Rose::Table as |table|>
-        <table.header as |header|>
-          <header.row as |row|>
-            <row.headerCell>{{t 'form.name.label'}}</row.headerCell>
-            <row.headerCell>{{t 'form.type.label'}}</row.headerCell>
-            <row.headerCell>{{t 'form.id.label'}}</row.headerCell>
-          </header.row>
-        </table.header>
-        <table.body as |body|>
-          {{#each @model as |credential|}}
-            <body.row as |row|>
-              <row.headerCell>
-                {{#if (can 'read credential' credential)}}
-                  <LinkTo
-                    @route='scopes.scope.credential-stores.credential-store.credentials.credential'
-                    @model={{credential.id}}
-                  >
-                    {{credential.displayName}}
-                  </LinkTo>
-                {{else}}
-                  {{credential.displayName}}
-                {{/if}}
-                <p>{{credential.description}}</p>
-              </row.headerCell>
-              <row.cell>
-                <CredSourceTypeBadge @model={{credential}} />
-              </row.cell>
-              <row.cell>
-                <Copyable
-                  @text={{credential.id}}
-                  @buttonText={{t 'actions.copy-to-clipboard'}}
-                  @acknowledgeText={{t 'states.copied'}}
+      <Hds::Table
+        @model={{@model}}
+        @columns={{array
+          (hash label=(t 'form.name.label'))
+          (hash label=(t 'form.type.label'))
+          (hash label=(t 'form.id.label'))
+        }}
+        @valign='middle'
+      >
+        <:body as |B|>
+          <B.Tr>
+            <B.Td>
+              {{#if (can 'read credential' B.data)}}
+                <LinkTo
+                  @route='scopes.scope.credential-stores.credential-store.credentials.credential'
+                  @model={{B.data.id}}
                 >
-                  <code>{{credential.id}}</code>
-                </Copyable>
-              </row.cell>
-            </body.row>
-          {{/each}}
-        </table.body>
-      </Rose::Table>
+                  {{B.data.displayName}}
+                </LinkTo>
+              {{else}}
+                <Hds::Text::Body @tag='p'>
+                  {{B.data.displayName}}
+                </Hds::Text::Body>
+              {{/if}}
+              <Hds::Text::Body @tag='p'>
+                {{B.data.description}}
+              </Hds::Text::Body>
+            </B.Td>
+            <B.Td>
+              <CredSourceTypeBadge @model={{B.data}} />
+            </B.Td>
+            <B.Td>
+              <Hds::Copy::Snippet
+                @color='secondary'
+                @textToCopy={{B.data.id}}
+              />
+            </B.Td>
+          </B.Tr>
+        </:body>
+      </Hds::Table>
 
     {{else}}
 
diff --git a/ui/admin/tests/acceptance/credential-store/credentials/list-test.js b/ui/admin/tests/acceptance/credential-store/credentials/list-test.js
index dad56b2b1..437374fd1 100644
--- a/ui/admin/tests/acceptance/credential-store/credentials/list-test.js
+++ b/ui/admin/tests/acceptance/credential-store/credentials/list-test.js
@@ -81,7 +81,7 @@ module('Acceptance | credential-stores | credentials | list', function (hooks) {
     await click(`[href="${urls.credentials}"]`);
     assert.strictEqual(currentURL(), urls.credentials);
     assert
-      .dom('.rose-table-body .rose-table-row')
+      .dom('tbody tr')
       .isVisible({ count: this.server.schema.credentials.all().models.length });
   });