From ae5a03250fa75be41bf5e418b709c01f92afffc2 Mon Sep 17 00:00:00 2001 From: Dharini Jeeva Date: Mon, 15 Jul 2024 10:15:55 -0700 Subject: [PATCH] =?UTF-8?q?fix:=20=F0=9F=90=9B=20add=20visuallyhidden=20to?= =?UTF-8?q?=20empty=20table=20columns=20(#2383)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- ui/admin/app/templates/scopes/scope/aliases/index.hbs | 2 +- .../app/templates/scopes/scope/auth-methods/index.hbs | 5 ++++- ui/admin/app/templates/scopes/scope/policies/index.hbs | 2 +- .../templates/scopes/scope/session-recordings/index.hbs | 2 +- .../session-recording/channels-by-connection/index.hbs | 6 +++++- .../app/templates/scopes/scope/storage-buckets/index.hbs | 2 +- .../templates/scopes/scope/projects/sessions/index.hbs | 7 ++++++- .../templates/scopes/scope/projects/targets/index.hbs | 9 +++++++-- 8 files changed, 26 insertions(+), 9 deletions(-) diff --git a/ui/admin/app/templates/scopes/scope/aliases/index.hbs b/ui/admin/app/templates/scopes/scope/aliases/index.hbs index 8a57bc039..c468a61f9 100644 --- a/ui/admin/app/templates/scopes/scope/aliases/index.hbs +++ b/ui/admin/app/templates/scopes/scope/aliases/index.hbs @@ -36,7 +36,7 @@ (hash label=(t 'resources.alias.titles.points_to')) (hash label=(t 'resources.scope.title')) (hash label=(t 'resources.alias.titles.resource_id')) - (hash label='') + (hash label=(t 'titles.actions') isVisuallyHidden=true) }} @valign='middle' > diff --git a/ui/admin/app/templates/scopes/scope/auth-methods/index.hbs b/ui/admin/app/templates/scopes/scope/auth-methods/index.hbs index c1bab7057..6c3eb4f06 100644 --- a/ui/admin/app/templates/scopes/scope/auth-methods/index.hbs +++ b/ui/admin/app/templates/scopes/scope/auth-methods/index.hbs @@ -98,7 +98,10 @@ (hash label=(t 'form.name.label')) (hash label=(t 'form.type.label')) (hash label=(t 'form.id.label')) - (hash label='') + (hash + label=(t 'resources.auth-method.titles.primary') + isVisuallyHidden=true + ) (hash label=(t 'titles.actions')) }} @density='short' diff --git a/ui/admin/app/templates/scopes/scope/policies/index.hbs b/ui/admin/app/templates/scopes/scope/policies/index.hbs index 3e0f0edf5..e3c722755 100644 --- a/ui/admin/app/templates/scopes/scope/policies/index.hbs +++ b/ui/admin/app/templates/scopes/scope/policies/index.hbs @@ -33,7 +33,7 @@ (hash label=(t 'resources.scope.title')) (hash label=(t 'resources.policy.titles.retain_for')) (hash label=(t 'resources.policy.titles.delete_after')) - (hash label='') + (hash label=(t 'titles.actions') isVisuallyHidden=true) }} @valign='middle' > diff --git a/ui/admin/app/templates/scopes/scope/session-recordings/index.hbs b/ui/admin/app/templates/scopes/scope/session-recordings/index.hbs index 01e7e327e..68660eaef 100644 --- a/ui/admin/app/templates/scopes/scope/session-recordings/index.hbs +++ b/ui/admin/app/templates/scopes/scope/session-recordings/index.hbs @@ -26,7 +26,7 @@ (hash label=(t 'resources.session-recording.form.user.label')) (hash label=(t 'resources.session-recording.form.target.label')) (hash label=(t 'resources.session-recording.form.duration.label')) - (hash label='' align='right') + (hash label=(t 'actions.view') isVisuallyHidden=true align='right') }} @valign='middle' > diff --git a/ui/admin/app/templates/scopes/scope/session-recordings/session-recording/channels-by-connection/index.hbs b/ui/admin/app/templates/scopes/scope/session-recordings/session-recording/channels-by-connection/index.hbs index 697feb6fe..aa19d71fd 100644 --- a/ui/admin/app/templates/scopes/scope/session-recordings/session-recording/channels-by-connection/index.hbs +++ b/ui/admin/app/templates/scopes/scope/session-recordings/session-recording/channels-by-connection/index.hbs @@ -109,7 +109,11 @@ ) ) (hash label=(t 'form.id.label')) - (hash label='' align='right') + (hash + label=(t 'titles.actions') + isVisuallyHidden=true + align='right' + ) }} @valign='middle' > diff --git a/ui/admin/app/templates/scopes/scope/storage-buckets/index.hbs b/ui/admin/app/templates/scopes/scope/storage-buckets/index.hbs index 6d4602c21..12abbf978 100644 --- a/ui/admin/app/templates/scopes/scope/storage-buckets/index.hbs +++ b/ui/admin/app/templates/scopes/scope/storage-buckets/index.hbs @@ -36,7 +36,7 @@ (hash label=(t 'form.id.label')) (hash label=(t 'resources.storage-bucket.form.provider.label')) (hash label=(t 'resources.storage-bucket.form.scope.label')) - (hash label='') + (hash label=(t 'titles.actions') isVisuallyHidden=true) }} @valign='middle' > diff --git a/ui/desktop/app/templates/scopes/scope/projects/sessions/index.hbs b/ui/desktop/app/templates/scopes/scope/projects/sessions/index.hbs index 838550bdd..97a391749 100644 --- a/ui/desktop/app/templates/scopes/scope/projects/sessions/index.hbs +++ b/ui/desktop/app/templates/scopes/scope/projects/sessions/index.hbs @@ -73,7 +73,12 @@ (hash label=(t 'resources.target.title')) (hash label=(t 'form.proxy_url.label')) (hash label=(t 'form.status.label')) - (hash label='' align='right' width='60px') + (hash + label=(t 'titles.actions') + isVisuallyHidden=true + align='right' + width='60px' + ) }} @valign='middle' > diff --git a/ui/desktop/app/templates/scopes/scope/projects/targets/index.hbs b/ui/desktop/app/templates/scopes/scope/projects/targets/index.hbs index 317cf1364..6bfbb7461 100644 --- a/ui/desktop/app/templates/scopes/scope/projects/targets/index.hbs +++ b/ui/desktop/app/templates/scopes/scope/projects/targets/index.hbs @@ -79,7 +79,7 @@ (hash label=(t 'resources.target.titles.active-sessions')) (hash label=(t 'form.type.label')) (hash label=(t 'resources.project.title')) - (hash label='' align='right') + (hash label=(t 'titles.actions') isVisuallyHidden=true align='right') }} @valign='middle' > @@ -214,7 +214,12 @@ (hash label=(t 'form.started.label')) (hash label=(t 'form.session_id.label')) (hash label=(t 'form.proxy_url.label')) - (hash label='' align='right' width='60px') + (hash + label=(t 'titles.actions') + isVisuallyHidden=true + align='right' + width='60px' + ) }} @valign='middle' >