From 41b3a996171542eb53db507977dfc068cc108f77 Mon Sep 17 00:00:00 2001 From: Randall Morey Date: Tue, 25 Jan 2022 09:13:09 -0500 Subject: [PATCH 1/2] =?UTF-8?q?refactor:=20=F0=9F=92=A1=20remove=20renderT?= =?UTF-8?q?emplate=20usage=20from=20roles=20resource?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../roles/role/actions/index.hbs} | 0 .../roles/role/header/index.hbs} | 0 .../roles/role/nav/index.hbs} | 0 .../app/routes/scopes/scope/roles/role.js | 24 --- .../scopes/scope/roles/role/add-principals.js | 24 --- .../routes/scopes/scope/roles/role/grants.js | 16 -- .../scopes/scope/roles/role/principals.js | 14 -- .../app/templates/scopes/scope/roles/role.hbs | 24 +-- .../scope/roles/role/add-principals.hbs | 32 +++- .../roles/role/add-principals/-header.hbs | 5 - .../scopes/scope/roles/role/grants.hbs | 47 ++++- .../scope/roles/role/grants/-header.hbs | 12 -- .../scopes/scope/roles/role/index.hbs | 34 +++- .../scopes/scope/roles/role/principals.hbs | 180 +++++++++++------- .../scope/roles/role/principals/-header.hbs | 12 -- 15 files changed, 201 insertions(+), 223 deletions(-) rename ui/admin/app/{templates/scopes/scope/roles/role/-actions.hbs => components/roles/role/actions/index.hbs} (100%) rename ui/admin/app/{templates/scopes/scope/roles/role/-header.hbs => components/roles/role/header/index.hbs} (100%) rename ui/admin/app/{templates/scopes/scope/roles/role/-navigation.hbs => components/roles/role/nav/index.hbs} (100%) delete mode 100644 ui/admin/app/templates/scopes/scope/roles/role/add-principals/-header.hbs delete mode 100644 ui/admin/app/templates/scopes/scope/roles/role/grants/-header.hbs delete mode 100644 ui/admin/app/templates/scopes/scope/roles/role/principals/-header.hbs diff --git a/ui/admin/app/templates/scopes/scope/roles/role/-actions.hbs b/ui/admin/app/components/roles/role/actions/index.hbs similarity index 100% rename from ui/admin/app/templates/scopes/scope/roles/role/-actions.hbs rename to ui/admin/app/components/roles/role/actions/index.hbs diff --git a/ui/admin/app/templates/scopes/scope/roles/role/-header.hbs b/ui/admin/app/components/roles/role/header/index.hbs similarity index 100% rename from ui/admin/app/templates/scopes/scope/roles/role/-header.hbs rename to ui/admin/app/components/roles/role/header/index.hbs diff --git a/ui/admin/app/templates/scopes/scope/roles/role/-navigation.hbs b/ui/admin/app/components/roles/role/nav/index.hbs similarity index 100% rename from ui/admin/app/templates/scopes/scope/roles/role/-navigation.hbs rename to ui/admin/app/components/roles/role/nav/index.hbs diff --git a/ui/admin/app/routes/scopes/scope/roles/role.js b/ui/admin/app/routes/scopes/scope/roles/role.js index 23ff8220c..54c98ec4c 100644 --- a/ui/admin/app/routes/scopes/scope/roles/role.js +++ b/ui/admin/app/routes/scopes/scope/roles/role.js @@ -16,28 +16,4 @@ export default class ScopesScopeRolesRoleRoute extends Route { adapterOptions: { scopeID }, }); } - - /** - * Renders the role specific templates for header, navigation, - * and actions page sections. - * @override - */ - renderTemplate() { - super.renderTemplate(...arguments); - - this.render('scopes/scope/roles/role/-header', { - into: 'scopes/scope/roles/role', - outlet: 'header', - }); - - this.render('scopes/scope/roles/role/-navigation', { - into: 'scopes/scope/roles/role', - outlet: 'navigation', - }); - - this.render('scopes/scope/roles/role/-actions', { - into: 'scopes/scope/roles/role', - outlet: 'actions', - }); - } } diff --git a/ui/admin/app/routes/scopes/scope/roles/role/add-principals.js b/ui/admin/app/routes/scopes/scope/roles/role/add-principals.js index c6dcf8b50..1d29243d7 100644 --- a/ui/admin/app/routes/scopes/scope/roles/role/add-principals.js +++ b/ui/admin/app/routes/scopes/scope/roles/role/add-principals.js @@ -28,30 +28,6 @@ export default class ScopesScopeRolesRoleAddPrincipalsRoute extends Route { }); } - /** - * Renders the add-principals-specific header template. - * Empties the actions and navigation outlets and renders a custom empty header. - * @override - */ - renderTemplate() { - super.renderTemplate(...arguments); - - this.render('scopes/scope/roles/role/add-principals/-header', { - into: 'scopes/scope/roles/role', - outlet: 'header', - }); - - this.render('-empty', { - into: 'scopes/scope/roles/role', - outlet: 'navigation', - }); - - this.render('-empty', { - into: 'scopes/scope/roles/role', - outlet: 'actions', - }); - } - // =actions /** diff --git a/ui/admin/app/routes/scopes/scope/roles/role/grants.js b/ui/admin/app/routes/scopes/scope/roles/role/grants.js index 11cfa1516..76d7c7ef3 100644 --- a/ui/admin/app/routes/scopes/scope/roles/role/grants.js +++ b/ui/admin/app/routes/scopes/scope/roles/role/grants.js @@ -10,22 +10,6 @@ export default class ScopesScopeRolesRoleGrantsRoute extends Route { @service intl; @service notify; - // =methods - - /** - * Renders the grants-specific header template. - * Empties the actions and navigation outlets and renders a custom empty header. - * @override - */ - renderTemplate() { - super.renderTemplate(...arguments); - - this.render('scopes/scope/roles/role/grants/-header', { - into: 'scopes/scope/roles/role', - outlet: 'header', - }); - } - // =actions /** diff --git a/ui/admin/app/routes/scopes/scope/roles/role/principals.js b/ui/admin/app/routes/scopes/scope/roles/role/principals.js index 6c3b38925..17172e0f8 100644 --- a/ui/admin/app/routes/scopes/scope/roles/role/principals.js +++ b/ui/admin/app/routes/scopes/scope/roles/role/principals.js @@ -45,20 +45,6 @@ export default class ScopesScopeRolesRolePrincipalsRoute extends Route { }); } - /** - * Renders the principals-specific header template. - * Empties the actions and navigation outlets and renders a custom empty header. - * @override - */ - renderTemplate() { - super.renderTemplate(...arguments); - - this.render('scopes/scope/roles/role/principals/-header', { - into: 'scopes/scope/roles/role', - outlet: 'header', - }); - } - // =actions /** diff --git a/ui/admin/app/templates/scopes/scope/roles/role.hbs b/ui/admin/app/templates/scopes/scope/roles/role.hbs index 33d5e4cdc..7d32ecb0d 100644 --- a/ui/admin/app/templates/scopes/scope/roles/role.hbs +++ b/ui/admin/app/templates/scopes/scope/roles/role.hbs @@ -1,25 +1,3 @@ {{page-title @model.displayName}} - - - - - - - - {{outlet 'header'}} - - - - {{outlet 'actions'}} - - - - {{outlet 'navigation'}} - - - - {{outlet}} - - - \ No newline at end of file +{{outlet}} \ No newline at end of file diff --git a/ui/admin/app/templates/scopes/scope/roles/role/add-principals.hbs b/ui/admin/app/templates/scopes/scope/roles/role/add-principals.hbs index 059142299..c454c543a 100644 --- a/ui/admin/app/templates/scopes/scope/roles/role/add-principals.hbs +++ b/ui/admin/app/templates/scopes/scope/roles/role/add-principals.hbs @@ -1,9 +1,27 @@ {{page-title (t 'resources.role.principal.actions.add-principals')}} - \ No newline at end of file + + + + + + + +

+ {{t 'resources.role.principal.messages.add-principals.title'}} + +

+

{{t 'resources.role.principal.messages.add-principals.description'}}

+
+ + + + + +
\ No newline at end of file diff --git a/ui/admin/app/templates/scopes/scope/roles/role/add-principals/-header.hbs b/ui/admin/app/templates/scopes/scope/roles/role/add-principals/-header.hbs deleted file mode 100644 index 8264b0ae5..000000000 --- a/ui/admin/app/templates/scopes/scope/roles/role/add-principals/-header.hbs +++ /dev/null @@ -1,5 +0,0 @@ -

- {{t 'resources.role.principal.messages.add-principals.title'}} - -

-

{{t 'resources.role.principal.messages.add-principals.description'}}

\ No newline at end of file diff --git a/ui/admin/app/templates/scopes/scope/roles/role/grants.hbs b/ui/admin/app/templates/scopes/scope/roles/role/grants.hbs index 79ccf9ede..a93aaacf7 100644 --- a/ui/admin/app/templates/scopes/scope/roles/role/grants.hbs +++ b/ui/admin/app/templates/scopes/scope/roles/role/grants.hbs @@ -1,9 +1,42 @@ {{page-title (t 'resources.role.grant.title_plural')}} - \ No newline at end of file + + + + + + + +

+ {{t 'resources.role.title'}} + +

+

{{t 'resources.role.grant.description'}}

+ + {{@model.id}} + +
+ + + + + + + + + + + + + +
\ No newline at end of file diff --git a/ui/admin/app/templates/scopes/scope/roles/role/grants/-header.hbs b/ui/admin/app/templates/scopes/scope/roles/role/grants/-header.hbs deleted file mode 100644 index 4097a2ecf..000000000 --- a/ui/admin/app/templates/scopes/scope/roles/role/grants/-header.hbs +++ /dev/null @@ -1,12 +0,0 @@ -

- {{t 'resources.role.title'}} - -

-

{{t 'resources.role.grant.description'}}

- - {{@model.id}} - \ No newline at end of file diff --git a/ui/admin/app/templates/scopes/scope/roles/role/index.hbs b/ui/admin/app/templates/scopes/scope/roles/role/index.hbs index 99dc29cc6..8edae91b9 100644 --- a/ui/admin/app/templates/scopes/scope/roles/role/index.hbs +++ b/ui/admin/app/templates/scopes/scope/roles/role/index.hbs @@ -1,6 +1,28 @@ - \ No newline at end of file + + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/ui/admin/app/templates/scopes/scope/roles/role/principals.hbs b/ui/admin/app/templates/scopes/scope/roles/role/principals.hbs index 567a95200..0dd8125f2 100644 --- a/ui/admin/app/templates/scopes/scope/roles/role/principals.hbs +++ b/ui/admin/app/templates/scopes/scope/roles/role/principals.hbs @@ -1,79 +1,113 @@ {{page-title (t 'resources.role.principal.title_plural')}} -{{#if @model.principals}} + - - - - {{t 'form.name.label'}} - {{t 'form.type.label'}} - {{t 'form.id.label'}} - {{t 'titles.actions'}} - - - - {{#each @model.principals as |principal|}} - - - {{principal.model.displayName}} - {{#if principal.model.accountName}} -
{{principal.model.accountName}} - {{/if}} -
- - {{t (concat 'resources.role.principal.types.' principal.type)}} - - - - {{principal.model.id}} - - - - {{#if (can 'removePrincipals role' @model.role)}} - - - {{t 'actions.remove'}} - - - {{/if}} - -
- {{/each}} -
-
+ + + -{{else}} - - - +

+ {{t 'resources.role.title'}} + +

+

{{t 'resources.role.principal.description'}}

+ - - {{t 'resources.role.principal.messages.welcome.description'}} - - - - {{t 'resources.role.principal.actions.add-principals'}} - -
-
+ {{@model.role.id}} + + -{{/if}} \ No newline at end of file + + + + + + + + + + {{#if @model.principals}} + + + + + {{t 'form.name.label'}} + {{t 'form.type.label'}} + {{t 'form.id.label'}} + {{t 'titles.actions'}} + + + + {{#each @model.principals as |principal|}} + + + {{principal.model.displayName}} + {{#if principal.model.accountName}} +
{{principal.model.accountName}} + {{/if}} +
+ + {{t (concat 'resources.role.principal.types.' principal.type)}} + + + + {{principal.model.id}} + + + + {{#if (can 'removePrincipals role' @model.role)}} + + + {{t 'actions.remove'}} + + + {{/if}} + +
+ {{/each}} +
+
+ + {{else}} + + + + + {{t 'resources.role.principal.messages.welcome.description'}} + + + + {{t 'resources.role.principal.actions.add-principals'}} + + + + + {{/if}} +
+ +
\ No newline at end of file diff --git a/ui/admin/app/templates/scopes/scope/roles/role/principals/-header.hbs b/ui/admin/app/templates/scopes/scope/roles/role/principals/-header.hbs deleted file mode 100644 index 3f483d4d2..000000000 --- a/ui/admin/app/templates/scopes/scope/roles/role/principals/-header.hbs +++ /dev/null @@ -1,12 +0,0 @@ -

- {{t 'resources.role.title'}} - -

-

{{t 'resources.role.principal.description'}}

- - {{@model.role.id}} - \ No newline at end of file From 2febf3ac3c3f44f432ab6e119281be024693c40d Mon Sep 17 00:00:00 2001 From: Randall Morey Date: Tue, 25 Jan 2022 09:40:30 -0500 Subject: [PATCH 2/2] =?UTF-8?q?refactor:=20=F0=9F=92=A1=20remove=20renderT?= =?UTF-8?q?emplate=20usage=20from=20groups=20resource?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../groups/group/actions/index.hbs} | 0 .../groups/group/header/index.hbs} | 0 .../groups/group/nav/index.hbs} | 0 .../app/routes/scopes/scope/groups/group.js | 23 --- .../scopes/scope/groups/group/add-members.js | 23 --- .../templates/scopes/scope/groups/group.hbs | 24 +-- .../scopes/scope/groups/group/add-members.hbs | 30 +++- .../groups/group/add-members/-header.hbs | 5 - .../scopes/scope/groups/group/index.hbs | 32 +++- .../scopes/scope/groups/group/members.hbs | 158 ++++++++++-------- 10 files changed, 142 insertions(+), 153 deletions(-) rename ui/admin/app/{templates/scopes/scope/groups/group/-actions.hbs => components/groups/group/actions/index.hbs} (100%) rename ui/admin/app/{templates/scopes/scope/groups/group/-header.hbs => components/groups/group/header/index.hbs} (100%) rename ui/admin/app/{templates/scopes/scope/groups/group/-navigation.hbs => components/groups/group/nav/index.hbs} (100%) delete mode 100644 ui/admin/app/templates/scopes/scope/groups/group/add-members/-header.hbs diff --git a/ui/admin/app/templates/scopes/scope/groups/group/-actions.hbs b/ui/admin/app/components/groups/group/actions/index.hbs similarity index 100% rename from ui/admin/app/templates/scopes/scope/groups/group/-actions.hbs rename to ui/admin/app/components/groups/group/actions/index.hbs diff --git a/ui/admin/app/templates/scopes/scope/groups/group/-header.hbs b/ui/admin/app/components/groups/group/header/index.hbs similarity index 100% rename from ui/admin/app/templates/scopes/scope/groups/group/-header.hbs rename to ui/admin/app/components/groups/group/header/index.hbs diff --git a/ui/admin/app/templates/scopes/scope/groups/group/-navigation.hbs b/ui/admin/app/components/groups/group/nav/index.hbs similarity index 100% rename from ui/admin/app/templates/scopes/scope/groups/group/-navigation.hbs rename to ui/admin/app/components/groups/group/nav/index.hbs diff --git a/ui/admin/app/routes/scopes/scope/groups/group.js b/ui/admin/app/routes/scopes/scope/groups/group.js index 0d9ad56bf..75a1c70d2 100644 --- a/ui/admin/app/routes/scopes/scope/groups/group.js +++ b/ui/admin/app/routes/scopes/scope/groups/group.js @@ -12,27 +12,4 @@ export default class ScopesScopeGroupsGroupRoute extends Route { model({ group_id }) { return this.store.findRecord('group', group_id, { reload: true }); } - - /** - * Renders the route-set specific page sections - * @override - */ - renderTemplate() { - super.renderTemplate(...arguments); - - this.render('scopes/scope/groups/group/-header', { - into: 'scopes/scope/groups/group', - outlet: 'header', - }); - - this.render('scopes/scope/groups/group/-actions', { - into: 'scopes/scope/groups/group', - outlet: 'actions', - }); - - this.render('scopes/scope/groups/group/-navigation', { - into: 'scopes/scope/groups/group', - outlet: 'navigation', - }); - } } diff --git a/ui/admin/app/routes/scopes/scope/groups/group/add-members.js b/ui/admin/app/routes/scopes/scope/groups/group/add-members.js index fda2aaaed..7629c17d9 100644 --- a/ui/admin/app/routes/scopes/scope/groups/group/add-members.js +++ b/ui/admin/app/routes/scopes/scope/groups/group/add-members.js @@ -34,29 +34,6 @@ export default class ScopesScopeGroupsGroupAddMembersRoute extends Route { }); } - /** - * Renders the route-set specific page sections - * @override - */ - renderTemplate() { - super.renderTemplate(...arguments); - - this.render('scopes/scope/groups/group/add-members/-header', { - into: 'scopes/scope/groups/group', - outlet: 'header', - }); - - this.render('-empty', { - into: 'scopes/scope/groups/group', - outlet: 'actions', - }); - - this.render('-empty', { - into: 'scopes/scope/groups/group', - outlet: 'navigation', - }); - } - // =actions /** diff --git a/ui/admin/app/templates/scopes/scope/groups/group.hbs b/ui/admin/app/templates/scopes/scope/groups/group.hbs index 837d1f984..7d32ecb0d 100644 --- a/ui/admin/app/templates/scopes/scope/groups/group.hbs +++ b/ui/admin/app/templates/scopes/scope/groups/group.hbs @@ -1,25 +1,3 @@ {{page-title @model.displayName}} - - - - - - - - {{outlet 'header'}} - - - - {{outlet 'navigation'}} - - - - {{outlet 'actions'}} - - - - {{outlet}} - - - \ No newline at end of file +{{outlet}} \ No newline at end of file diff --git a/ui/admin/app/templates/scopes/scope/groups/group/add-members.hbs b/ui/admin/app/templates/scopes/scope/groups/group/add-members.hbs index a85c01185..3013ba2f7 100644 --- a/ui/admin/app/templates/scopes/scope/groups/group/add-members.hbs +++ b/ui/admin/app/templates/scopes/scope/groups/group/add-members.hbs @@ -1,8 +1,26 @@ {{page-title (t 'resources.group.messages.add-members.title')}} - \ No newline at end of file + + + + + + + +

+ {{t 'resources.group.messages.add-members.title'}} + +

+

{{t 'resources.group.messages.add-members.description'}}

+
+ + + + + +
\ No newline at end of file diff --git a/ui/admin/app/templates/scopes/scope/groups/group/add-members/-header.hbs b/ui/admin/app/templates/scopes/scope/groups/group/add-members/-header.hbs deleted file mode 100644 index 71181a8df..000000000 --- a/ui/admin/app/templates/scopes/scope/groups/group/add-members/-header.hbs +++ /dev/null @@ -1,5 +0,0 @@ -

- {{t 'resources.group.messages.add-members.title'}} - -

-

{{t 'resources.group.messages.add-members.description'}}

\ No newline at end of file diff --git a/ui/admin/app/templates/scopes/scope/groups/group/index.hbs b/ui/admin/app/templates/scopes/scope/groups/group/index.hbs index 6a89a496d..d5da2abf3 100644 --- a/ui/admin/app/templates/scopes/scope/groups/group/index.hbs +++ b/ui/admin/app/templates/scopes/scope/groups/group/index.hbs @@ -1,5 +1,27 @@ - \ No newline at end of file + + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/ui/admin/app/templates/scopes/scope/groups/group/members.hbs b/ui/admin/app/templates/scopes/scope/groups/group/members.hbs index 9df657c32..b4c479eda 100644 --- a/ui/admin/app/templates/scopes/scope/groups/group/members.hbs +++ b/ui/admin/app/templates/scopes/scope/groups/group/members.hbs @@ -1,75 +1,97 @@ {{page-title (t 'resources.group.messages.members.title')}} -{{#if @model.members}} + - - - - {{t 'form.name.label'}} - {{t 'form.id.label'}} - {{t 'titles.actions'}} - - - - {{#each @model.members as |member|}} - - - {{member.displayName}} - {{#if member.accountName}} -
{{member.accountName}} - {{/if}} -
- - - {{member.id}} - - - - {{#if (can 'removeMembers group' @model.group)}} - - + + + + + + + + + + + + + + + + + {{#if @model.members}} + + + + + {{t 'form.name.label'}} + {{t 'form.id.label'}} + {{t 'titles.actions'}} + + + + {{#each @model.members as |member|}} + + + {{member.displayName}} + {{#if member.accountName}} +
{{member.accountName}} + {{/if}} +
+ + - {{t 'actions.remove'}} -
-
- {{/if}} -
-
- {{/each}} -
-
+ {{member.id}} + + + + {{#if (can 'removeMembers group' @model.group)}} + + + {{t 'actions.remove'}} + + + {{/if}} + + + {{/each}} + + -{{else}} + {{else}} - - - - {{t 'resources.group.messages.members.description'}} - - - - {{t 'resources.group.actions.add-members'}} - - - + + + + {{t 'resources.group.messages.members.description'}} + + + + {{t 'resources.group.actions.add-members'}} + + + -{{/if}} \ No newline at end of file + {{/if}} + + +
\ No newline at end of file