From baa607a16a348676eb9d0ddb316250f71443aed8 Mon Sep 17 00:00:00 2001 From: Randall Morey Date: Wed, 18 Nov 2020 12:23:26 -0500 Subject: [PATCH] =?UTF-8?q?refactor:=20=F0=9F=92=A1=20move=20date=20format?= =?UTF-8?q?=20helpers=20to=20core=20addon?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- addons/core/addon/.gitkeep | 0 .../core/addon}/helpers/format-date-iso-human.js | 4 ++++ .../app => addons/core/addon}/helpers/format-date-iso.js | 4 ++++ addons/core/app/helpers/format-date-iso-human.js | 1 + addons/core/app/helpers/format-date-iso.js | 1 + addons/core/tests/integration/.gitkeep | 0 .../tests/integration/helpers/format-date-iso-human-test.js | 1 - .../core}/tests/integration/helpers/format-date-iso-test.js | 1 - 8 files changed, 10 insertions(+), 2 deletions(-) delete mode 100644 addons/core/addon/.gitkeep rename {ui/admin/app => addons/core/addon}/helpers/format-date-iso-human.js (63%) rename {ui/admin/app => addons/core/addon}/helpers/format-date-iso.js (58%) create mode 100644 addons/core/app/helpers/format-date-iso-human.js create mode 100644 addons/core/app/helpers/format-date-iso.js delete mode 100644 addons/core/tests/integration/.gitkeep rename {ui/admin => addons/core}/tests/integration/helpers/format-date-iso-human-test.js (93%) rename {ui/admin => addons/core}/tests/integration/helpers/format-date-iso-test.js (93%) diff --git a/addons/core/addon/.gitkeep b/addons/core/addon/.gitkeep deleted file mode 100644 index e69de29bb..000000000 diff --git a/ui/admin/app/helpers/format-date-iso-human.js b/addons/core/addon/helpers/format-date-iso-human.js similarity index 63% rename from ui/admin/app/helpers/format-date-iso-human.js rename to addons/core/addon/helpers/format-date-iso-human.js index 00248aa5d..a0b9e5038 100644 --- a/ui/admin/app/helpers/format-date-iso-human.js +++ b/addons/core/addon/helpers/format-date-iso-human.js @@ -1,5 +1,9 @@ import { helper } from '@ember/component/helper'; +/** + * Takes a `Date` instance and returns a string formatted in human-friendly + * ISO-ish, e.g. "2020-01-01 00:00:00". + */ export default helper(function formatDateIsoHuman(params /*, hash*/) { return params[0] .toISOString() diff --git a/ui/admin/app/helpers/format-date-iso.js b/addons/core/addon/helpers/format-date-iso.js similarity index 58% rename from ui/admin/app/helpers/format-date-iso.js rename to addons/core/addon/helpers/format-date-iso.js index e65442549..a3e9cf61a 100644 --- a/ui/admin/app/helpers/format-date-iso.js +++ b/addons/core/addon/helpers/format-date-iso.js @@ -1,5 +1,9 @@ import { helper } from '@ember/component/helper'; +/** + * Takes a `Date` instance and returns a string formatted in ISO, + * e.g. "2020-01-01T00:00:00.999Z". + */ export default helper(function formatDateIso(params /*, hash*/) { return params[0].toISOString(); }); diff --git a/addons/core/app/helpers/format-date-iso-human.js b/addons/core/app/helpers/format-date-iso-human.js new file mode 100644 index 000000000..b4586dc3d --- /dev/null +++ b/addons/core/app/helpers/format-date-iso-human.js @@ -0,0 +1 @@ +export { default, formatDateIsoHuman } from 'core/helpers/format-date-iso-human'; diff --git a/addons/core/app/helpers/format-date-iso.js b/addons/core/app/helpers/format-date-iso.js new file mode 100644 index 000000000..f82d799e1 --- /dev/null +++ b/addons/core/app/helpers/format-date-iso.js @@ -0,0 +1 @@ +export { default, formatDateIso } from 'core/helpers/format-date-iso'; diff --git a/addons/core/tests/integration/.gitkeep b/addons/core/tests/integration/.gitkeep deleted file mode 100644 index e69de29bb..000000000 diff --git a/ui/admin/tests/integration/helpers/format-date-iso-human-test.js b/addons/core/tests/integration/helpers/format-date-iso-human-test.js similarity index 93% rename from ui/admin/tests/integration/helpers/format-date-iso-human-test.js rename to addons/core/tests/integration/helpers/format-date-iso-human-test.js index da705231b..35f7c06e3 100644 --- a/ui/admin/tests/integration/helpers/format-date-iso-human-test.js +++ b/addons/core/tests/integration/helpers/format-date-iso-human-test.js @@ -6,7 +6,6 @@ import { hbs } from 'ember-cli-htmlbars'; module('Integration | Helper | format-date-iso-human', function (hooks) { setupRenderingTest(hooks); - // Replace this with your real tests. test('it renders', async function (assert) { this.set('inputValue', new Date('2020-01-01T00:00:00.999Z')); diff --git a/ui/admin/tests/integration/helpers/format-date-iso-test.js b/addons/core/tests/integration/helpers/format-date-iso-test.js similarity index 93% rename from ui/admin/tests/integration/helpers/format-date-iso-test.js rename to addons/core/tests/integration/helpers/format-date-iso-test.js index 12770ef76..0914b6a3a 100644 --- a/ui/admin/tests/integration/helpers/format-date-iso-test.js +++ b/addons/core/tests/integration/helpers/format-date-iso-test.js @@ -6,7 +6,6 @@ import { hbs } from 'ember-cli-htmlbars'; module('Integration | Helper | format-date-iso', function (hooks) { setupRenderingTest(hooks); - // Replace this with your real tests. test('it renders', async function (assert) { this.set('inputValue', new Date('2020-01-01T00:00:00.999Z'));