From bdc9f863943bad037c1804fd450cda6c951e53ee Mon Sep 17 00:00:00 2001 From: Carlos Alcaide Corvo Date: Wed, 3 May 2023 10:56:24 -0700 Subject: [PATCH] Chore session recordings bits and pieces (#237) * Add the word up & down to the bytes strings * Add string duration to all the duration strings that are out of a table Co-authored-by: Zhihe Li --- addons/core/translations/resources/en-us.yaml | 3 +++ ui/admin/app/styles/app.scss | 4 +++ .../channels-by-connection/channel.hbs | 17 +++++++++--- .../channels-by-connection/index.hbs | 27 ++++++++++++++----- 4 files changed, 41 insertions(+), 10 deletions(-) diff --git a/addons/core/translations/resources/en-us.yaml b/addons/core/translations/resources/en-us.yaml index deb15d17b..32ecba57a 100644 --- a/addons/core/translations/resources/en-us.yaml +++ b/addons/core/translations/resources/en-us.yaml @@ -217,6 +217,9 @@ session-recording: title_plural: Session Recordings details: Session details related: Related + up: '{bytes} up' + down: '{bytes} down' + duration: '{time} duration' connection: title: Connection title_index: Connection {index} diff --git a/ui/admin/app/styles/app.scss b/ui/admin/app/styles/app.scss index f8a5545c7..b10796305 100644 --- a/ui/admin/app/styles/app.scss +++ b/ui/admin/app/styles/app.scss @@ -882,6 +882,10 @@ .layout-sidebar-sidebar { grid-area: sidebar; + + &-details { + margin-bottom: 3rem; + } } } diff --git a/ui/admin/app/templates/scopes/scope/session-recordings/session-recording/channels-by-connection/channel.hbs b/ui/admin/app/templates/scopes/scope/session-recordings/session-recording/channels-by-connection/channel.hbs index cc3831041..3156c9b44 100644 --- a/ui/admin/app/templates/scopes/scope/session-recordings/session-recording/channels-by-connection/channel.hbs +++ b/ui/admin/app/templates/scopes/scope/session-recordings/session-recording/channels-by-connection/channel.hbs @@ -69,7 +69,7 @@ {{! Channel details information }} -
+

{{t 'resources.session-recording.channel.details'}}

{{! Start time }} @@ -83,15 +83,24 @@ {{! Duration }} - {{format-time-duration @model.channelRecording.duration}} + {{t + 'resources.session-recording.duration' + time=(format-time-duration @model.channelRecording.duration) + }} {{! Bytes up }} - {{format-bytes-size @model.channelRecording.bytes_up}} + {{t + 'resources.session-recording.up' + bytes=(format-bytes-size @model.channelRecording.bytes_up) + }} {{! Bytes down }} - {{format-bytes-size @model.channelRecording.bytes_down}} + {{t + 'resources.session-recording.down' + bytes=(format-bytes-size @model.channelRecording.bytes_down) + }}
diff --git a/ui/admin/app/templates/scopes/scope/session-recordings/session-recording/channels-by-connection/index.hbs b/ui/admin/app/templates/scopes/scope/session-recordings/session-recording/channels-by-connection/index.hbs index 97bdb5a59..ae78f78f2 100644 --- a/ui/admin/app/templates/scopes/scope/session-recordings/session-recording/channels-by-connection/index.hbs +++ b/ui/admin/app/templates/scopes/scope/session-recordings/session-recording/channels-by-connection/index.hbs @@ -64,11 +64,17 @@ {{! Bytes up }} - {{format-bytes-size B.data.bytes_up}} + {{t + 'resources.session-recording.up' + bytes=(format-bytes-size B.data.bytes_up) + }} {{! Bytes down }} - {{format-bytes-size B.data.bytes_down}} + {{t + 'resources.session-recording.down' + bytes=(format-bytes-size B.data.bytes_down) + }} {{! Duration }} @@ -100,7 +106,7 @@ {{/each}} -
+

{{t 'resources.session-recording.details'}}

@@ -117,15 +123,24 @@ {{! Duration }} - {{format-time-duration @model.sessionRecording.duration}} + {{t + 'resources.session-recording.duration' + time=(format-time-duration @model.sessionRecording.duration) + }} {{! Bytes up }} - {{format-bytes-size @model.sessionRecording.bytes_up}} + {{t + 'resources.session-recording.up' + bytes=(format-bytes-size @model.sessionRecording.bytes_up) + }} {{! Bytes down }} - {{format-bytes-size @model.sessionRecording.bytes_down}} + {{t + 'resources.session-recording.down' + bytes=(format-bytes-size @model.sessionRecording.bytes_down) + }}