From bfdaacc2cdc4c7294f8751e46fcdfd814321f4e5 Mon Sep 17 00:00:00 2001 From: Carlos Alcaide Date: Fri, 18 Jun 2021 16:23:07 -0700 Subject: [PATCH] =?UTF-8?q?feat:=20=F0=9F=8E=B8=20Changing=20div=20for=20h?= =?UTF-8?q?2?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Changing the heading text container from a div to an h2 --- ui/desktop/app/components/card/index.hbs | 4 ++-- ui/desktop/app/styles/app.scss | 9 ++++++++- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/ui/desktop/app/components/card/index.hbs b/ui/desktop/app/components/card/index.hbs index 07debfc77..28e1f869f 100644 --- a/ui/desktop/app/components/card/index.hbs +++ b/ui/desktop/app/components/card/index.hbs @@ -1,12 +1,12 @@
{{#if @heading}} -
+

{{#if @icon}} {{/if}} {{@heading}} -

+ {{/if}} {{yield to='header'}}
diff --git a/ui/desktop/app/styles/app.scss b/ui/desktop/app/styles/app.scss index b829c2938..e314e01ce 100644 --- a/ui/desktop/app/styles/app.scss +++ b/ui/desktop/app/styles/app.scss @@ -369,12 +369,19 @@ margin-bottom: sizing.rems(m); .card-header { + align-items: center; border-bottom: sizing.rems(xxxxs) solid var(--ui-gray-subtler-3); display: flex; justify-content: flex-start; padding: sizing.rems(s); - div { + h2 { + @include type.type(s, normal); + color: var(--ui-gray-starker-1); + } + + div, + h2 { display: flex; flex-shrink: 1; width: 100%;