From c230d6da290a39991fa3d6ea6e918a4f8d450b0f Mon Sep 17 00:00:00 2001 From: Susmitha Girumala Date: Wed, 29 Jul 2020 16:02:10 -0400 Subject: [PATCH] =?UTF-8?q?chore:=20=F0=9F=A4=96=20Remove=20rose-badge=20l?= =?UTF-8?q?ight=20style=20definition?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit After discussing with designer, badge style does not need a defined "light" style. --- addons/rose/addon/components/rose/badge.stories.mdx | 6 ++---- addons/rose/addon/styles/rose/components/_badge.scss | 5 ----- addons/rose/tests/integration/components/rose/badge-test.js | 1 - 3 files changed, 2 insertions(+), 10 deletions(-) diff --git a/addons/rose/addon/components/rose/badge.stories.mdx b/addons/rose/addon/components/rose/badge.stories.mdx index 5e7bc89f9..1f91c7beb 100644 --- a/addons/rose/addon/components/rose/badge.stories.mdx +++ b/addons/rose/addon/components/rose/badge.stories.mdx @@ -10,10 +10,10 @@ import { text, select } from '@storybook/addon-knobs'; A badge component that supports icons and predefined styles. When style definition isn't supplied, a default style will be supplied. -Styles: outline, light, dark, informational, informational-outline, success, success-outline, error, error-outline, warning, warning-outline, alert, alert-outline +Styles: outline, dark, informational, informational-outline, success, success-outline, error, error-outline, warning, warning-outline, alert, alert-outline ```html - +Badge ``` @@ -28,7 +28,6 @@ Styles: outline, light, dark, informational, informational-outline, success, suc style: select('style', { 'none': 'none', 'outline': 'outline', - 'light': 'light', 'dark': 'dark', 'informational': 'informational', 'informational-outline': 'informational-outline', @@ -60,7 +59,6 @@ Styles: outline, light, dark, informational, informational-outline, success, suc default style outline default style with icon - light dark informational informational-outline diff --git a/addons/rose/addon/styles/rose/components/_badge.scss b/addons/rose/addon/styles/rose/components/_badge.scss index 7d495e55e..716c97122 100644 --- a/addons/rose/addon/styles/rose/components/_badge.scss +++ b/addons/rose/addon/styles/rose/components/_badge.scss @@ -21,11 +21,6 @@ --border-color: var(--ui-gray-starker-1); } - &.rose-badge-light { - --border-color: var(--ui-gray-subtler-5); - --background-color: var(--ui-gray-starker-5); - } - &.rose-badge-dark { --color: var(--ui-gray-subtler-6); --border-color: var(--ui-gray-starker-1); diff --git a/addons/rose/tests/integration/components/rose/badge-test.js b/addons/rose/tests/integration/components/rose/badge-test.js index 91f906f26..16e968e69 100644 --- a/addons/rose/tests/integration/components/rose/badge-test.js +++ b/addons/rose/tests/integration/components/rose/badge-test.js @@ -24,7 +24,6 @@ module('Integration | Component | rose/badge', function(hooks) { test('it styles content using @style', async function(assert) { let styles = [ 'outline', - 'light', 'dark', 'informational', 'informational-outline',