From c8737f047451fbcabde7350bd8e8c7867fe313ad Mon Sep 17 00:00:00 2001 From: venusang Date: Wed, 17 Dec 2025 14:09:28 -0800 Subject: [PATCH] =?UTF-8?q?fix:=20=F0=9F=90=9B=20add=20aria-description=20?= =?UTF-8?q?to=20edit=20User=20detail=20btn=20to=20fix=20a11y=20bug=20(#311?= =?UTF-8?q?3)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A new param @ariaDescription that was added to addons/rose edit-toggle component which now allows us to define the value of aria-description per a11y requirements. With this change, the User detail edit form button now includes a value for aria-description. ✅ Closes: FE-112 --------- Co-authored-by: Zhihe Li --- .../addon/components/rose/form/actions/edit-toggle/index.hbs | 1 + .../components/rose/form/actions/edit-toggle-test.js | 3 +++ ui/admin/app/components/form/user/index.hbs | 1 + 3 files changed, 5 insertions(+) diff --git a/addons/rose/addon/components/rose/form/actions/edit-toggle/index.hbs b/addons/rose/addon/components/rose/form/actions/edit-toggle/index.hbs index c088d3b1e..d370de843 100644 --- a/addons/rose/addon/components/rose/form/actions/edit-toggle/index.hbs +++ b/addons/rose/addon/components/rose/form/actions/edit-toggle/index.hbs @@ -8,6 +8,7 @@ {{yield to='edit'}} {{else}} `, ); assert.ok(find('button')); + assert.dom('[aria-description]').exists(); }); test('it executes a function on button click', async function (assert) { @@ -34,6 +36,7 @@ module( `, ); diff --git a/ui/admin/app/components/form/user/index.hbs b/ui/admin/app/components/form/user/index.hbs index e6ec03f92..83869f1ed 100644 --- a/ui/admin/app/components/form/user/index.hbs +++ b/ui/admin/app/components/form/user/index.hbs @@ -53,6 +53,7 @@ {{#if (can 'save model' @model)}}