From d7f090f348f564c093d681523ba691c5cfbd5ce2 Mon Sep 17 00:00:00 2001
From: Randall Morey <randall@randallmorey.com>
Date: Thu, 1 Apr 2021 10:26:59 -0400
Subject: [PATCH 1/2] =?UTF-8?q?test:=20=F0=9F=92=8D=20dedupe=20window.loca?=
 =?UTF-8?q?tion.origin?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 ui/desktop/tests/acceptance/origin-test.js | 26 ++++++++++------------
 1 file changed, 12 insertions(+), 14 deletions(-)

diff --git a/ui/desktop/tests/acceptance/origin-test.js b/ui/desktop/tests/acceptance/origin-test.js
index 68642c831..59c95ab1d 100644
--- a/ui/desktop/tests/acceptance/origin-test.js
+++ b/ui/desktop/tests/acceptance/origin-test.js
@@ -25,6 +25,7 @@ module('Acceptance | origin', function (hooks) {
   setupApplicationTest(hooks);
   setupMirage(hooks);
 
+  const currentOrigin = window.location.origin;
   let mockIPC;
   let messageHandler;
 
@@ -124,7 +125,7 @@ module('Acceptance | origin', function (hooks) {
 
     mockIPC = new MockIPC();
     messageHandler = async function (event) {
-      if (event.origin !== window.location.origin) return;
+      if (event.origin !== currentOrigin) return;
       const { method, payload } = event.data;
       if (method) {
         const response = await mockIPC.invoke(method, payload);
@@ -159,20 +160,20 @@ module('Acceptance | origin', function (hooks) {
     assert.expect(3);
     assert.notOk(mockIPC.origin);
     await visit(urls.origin);
-    await fillIn('[name="host"]', window.location.origin);
+    await fillIn('[name="host"]', currentOrigin);
     await click('[type="submit"]');
     assert.equal(currentURL(), urls.authenticate.methods.global);
-    assert.equal(mockIPC.origin, window.location.origin);
+    assert.equal(mockIPC.origin, currentOrigin);
   });
 
   test('can reset origin before authentication', async function (assert) {
     assert.expect(4);
     assert.notOk(mockIPC.origin);
     await visit(urls.origin);
-    await fillIn('[name="host"]', window.location.origin);
+    await fillIn('[name="host"]', currentOrigin);
     await click('[type="submit"]');
     assert.equal(currentURL(), urls.authenticate.methods.global);
-    assert.equal(mockIPC.origin, window.location.origin);
+    assert.equal(mockIPC.origin, currentOrigin);
     await click('.change-origin a');
     assert.equal(currentURL(), urls.origin);
   });
@@ -182,7 +183,7 @@ module('Acceptance | origin', function (hooks) {
     assert.notOk(mockIPC.origin);
     sinon.stub(this.owner.lookup('service:origin'), 'setOrigin').throws();
     await visit(urls.origin);
-    await fillIn('[name="host"]', window.location.origin);
+    await fillIn('[name="host"]', currentOrigin);
     await click('[type="submit"]');
     assert.ok(find('.rose-notification.is-error'));
   });
@@ -191,12 +192,9 @@ module('Acceptance | origin', function (hooks) {
     assert.expect(1);
     config.autoOrigin = true;
     await visit(urls.origin);
-    await fillIn('[name="host"]', window.location.origin);
+    await fillIn('[name="host"]', currentOrigin);
     await click('[type="submit"]');
-    assert.equal(
-      this.owner.lookup('controller:origin').origin,
-      window.location.origin
-    );
+    assert.equal(this.owner.lookup('controller:origin').origin, currentOrigin);
     config.autoOrigin = false;
   });
 
@@ -204,9 +202,9 @@ module('Acceptance | origin', function (hooks) {
     assert.expect(4);
     this.server.get('/targets', () => new Response(500));
     await visit(urls.origin);
-    await fillIn('[name="host"]', window.location.origin);
-    await click('[type="submit"]');
-    await click('[type="submit"]');
+    await fillIn('[name="host"]', currentOrigin);
+    await click('[type="submit"]', 'Set origin');
+    await click('[type="submit"]', 'Authenticate');
     assert.ok(currentSession().isAuthenticated);
     assert.equal(find('main section button').textContent.trim(), 'Disconnect');
     await click('main section button');

From 43528c64c201361a1ad4744130f68f91a2b626cf Mon Sep 17 00:00:00 2001
From: Randall Morey <randall@randallmorey.com>
Date: Thu, 1 Apr 2021 13:04:28 -0400
Subject: [PATCH 2/2] =?UTF-8?q?test:=20=F0=9F=92=8D=20build=20out=20autoOr?=
 =?UTF-8?q?igin=20tests?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 ui/desktop/tests/acceptance/origin-test.js | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/ui/desktop/tests/acceptance/origin-test.js b/ui/desktop/tests/acceptance/origin-test.js
index 59c95ab1d..7181d33de 100644
--- a/ui/desktop/tests/acceptance/origin-test.js
+++ b/ui/desktop/tests/acceptance/origin-test.js
@@ -188,16 +188,21 @@ module('Acceptance | origin', function (hooks) {
     assert.ok(find('.rose-notification.is-error'));
   });
 
-  test('origin set automatically in dev mode', async function (assert) {
+  test('origin set automatically when autoOrigin is true', async function (assert) {
     assert.expect(1);
     config.autoOrigin = true;
     await visit(urls.origin);
-    await fillIn('[name="host"]', currentOrigin);
-    await click('[type="submit"]');
-    assert.equal(this.owner.lookup('controller:origin').origin, currentOrigin);
+    assert.equal(find('[name="host"]').value, currentOrigin);
     config.autoOrigin = false;
   });
 
+  test('origin is *not* set automatically when autoOrigin is false', async function (assert) {
+    assert.expect(2);
+    assert.notOk(config.autoOrigin, 'autoOrigin is disabled');
+    await visit(urls.origin);
+    assert.notOk(find('[name="host"]').value, 'Origin field is empty');
+  });
+
   test('can reset origin on error', async function (assert) {
     assert.expect(4);
     this.server.get('/targets', () => new Response(500));