From 3d0be5ef483e94d4a1f489e3d8d9fc05c5045f8d Mon Sep 17 00:00:00 2001
From: Zhihe Li <zhihe.li@hashicorp.com>
Date: Tue, 17 Jan 2023 17:08:08 -0500
Subject: [PATCH] =?UTF-8?q?refactor:=20=F0=9F=92=A1=20Simplify=20template?=
 =?UTF-8?q?=20for=20confirmation=20dialog=20(#1580)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 ui/admin/app/routes/application.js     |  5 +-
 ui/admin/app/templates/application.hbs | 82 +++++++++-----------------
 2 files changed, 33 insertions(+), 54 deletions(-)

diff --git a/ui/admin/app/routes/application.js b/ui/admin/app/routes/application.js
index e29140447..44afadcf3 100644
--- a/ui/admin/app/routes/application.js
+++ b/ui/admin/app/routes/application.js
@@ -38,7 +38,10 @@ export default class ApplicationRoute extends Route {
       if (fromName !== toName && maybeModel?.hasDirtyAttributes) {
         transition.abort();
         try {
-          await this.confirm.confirm('abandon', { isAbandonConfirm: true });
+          await this.confirm.confirm(this.intl.t('questions.abandon-confirm'), {
+            title: 'titles.abandon-confirm',
+            confirm: 'actions.discard',
+          });
           maybeModel?.rollbackAttributes();
           transition.retry();
         } catch (e) {
diff --git a/ui/admin/app/templates/application.hbs b/ui/admin/app/templates/application.hbs
index 7b857e35b..13ef17580 100644
--- a/ui/admin/app/templates/application.hbs
+++ b/ui/admin/app/templates/application.hbs
@@ -91,57 +91,33 @@
 {{/if}}
 
 <PendingConfirmations as |confirmation accept deny|>
-  {{#if confirmation.options.isAbandonConfirm}}
-    <Rose::Dialog
-      @heading={{t 'titles.abandon-confirm'}}
-      @dismissButtonText={{t 'actions.cancel'}}
-      @icon='flight-icons/svg/alert-triangle-16'
-      @style='warning'
-      @modal={{true}}
-      @dismiss={{deny}}
-      as |dialog|
-    >
-      <dialog.body>
-        <p>{{t 'questions.abandon-confirm'}}</p>
-      </dialog.body>
-      <dialog.footer>
-        <Rose::Button @style='primary' {{on 'click' accept}}>
-          {{t 'actions.discard'}}
-        </Rose::Button>
-        <Rose::Button @style='secondary' {{on 'click' deny}}>
-          {{t 'actions.cancel'}}
-        </Rose::Button>
-      </dialog.footer>
-    </Rose::Dialog>
-  {{else}}
-    <Rose::Dialog
-      @heading={{if
-        confirmation.options.title
-        (t confirmation.options.title)
-        (t 'actions.confirm')
-      }}
-      @dismissButtonText={{t 'actions.cancel'}}
-      @icon='flight-icons/svg/alert-triangle-16'
-      @style='warning'
-      @modal={{true}}
-      @dismiss={{deny}}
-      as |dialog|
-    >
-      <dialog.body>
-        <p>{{confirmation.text}}</p>
-      </dialog.body>
-      <dialog.footer>
-        <Rose::Button @style='primary' {{on 'click' accept}}>
-          {{if
-            confirmation.options.confirm
-            (t confirmation.options.confirm)
-            (t 'actions.ok')
-          }}
-        </Rose::Button>
-        <Rose::Button @style='secondary' {{on 'click' deny}}>
-          {{t 'actions.cancel'}}
-        </Rose::Button>
-      </dialog.footer>
-    </Rose::Dialog>
-  {{/if}}
+  <Rose::Dialog
+    @heading={{if
+      confirmation.options.title
+      (t confirmation.options.title)
+      (t 'actions.confirm')
+    }}
+    @dismissButtonText={{t 'actions.cancel'}}
+    @icon='flight-icons/svg/alert-triangle-16'
+    @style='warning'
+    @modal={{true}}
+    @dismiss={{deny}}
+    as |dialog|
+  >
+    <dialog.body>
+      <p>{{confirmation.text}}</p>
+    </dialog.body>
+    <dialog.footer>
+      <Rose::Button @style='primary' {{on 'click' accept}}>
+        {{if
+          confirmation.options.confirm
+          (t confirmation.options.confirm)
+          (t 'actions.ok')
+        }}
+      </Rose::Button>
+      <Rose::Button @style='secondary' {{on 'click' deny}}>
+        {{t 'actions.cancel'}}
+      </Rose::Button>
+    </dialog.footer>
+  </Rose::Dialog>
 </PendingConfirmations>
\ No newline at end of file