From cf3acad084df3746d1c1f9a29751c1ac7004c829 Mon Sep 17 00:00:00 2001
From: Devon Anderson <dvonanderson@gmail.com>
Date: Tue, 15 Nov 2022 22:57:39 -0500
Subject: [PATCH] =?UTF-8?q?feat:=20=F0=9F=8E=B8=20Credential=20type=20sele?=
 =?UTF-8?q?ctor=20refactor=20(#1452)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* feat: 🎸 Credential type selector refactor

When editing a credential or viewing the details screeen, the credential
type should be displayed as a readonly text field

✅ Closes: ICU-6839

* refactor: 💡 refactored disabled argument for credential type

BREAKING CHANGE: 🧨 ICU-6839

✅ Closes: ICU-6839

* refactor: 💡 Refactored credential-type-field

Refactored credential type card ui to look more like a message element
than a disabled input

✅ Closes: ICU-6839

Co-authored-by: Randall Morey <randall@randallmorey.com>
---
 .../form/credential/ssh_private_key/index.hbs | 43 +++++++++----------
 .../credential/username_password/index.hbs    | 43 +++++++++----------
 2 files changed, 42 insertions(+), 44 deletions(-)

diff --git a/ui/admin/app/components/form/credential/ssh_private_key/index.hbs b/ui/admin/app/components/form/credential/ssh_private_key/index.hbs
index 3d430ef79..78521aa81 100644
--- a/ui/admin/app/components/form/credential/ssh_private_key/index.hbs
+++ b/ui/admin/app/components/form/credential/ssh_private_key/index.hbs
@@ -43,10 +43,10 @@
       </field.errors>
     {{/if}}
   </form.textarea>
-  <form.fieldset>
-    <:title>{{t 'form.type.label'}}</:title>
-    <:body>
-      {{#if @model.isNew}}
+  {{#if @model.isNew}}
+    <form.fieldset>
+      <:title>{{t 'form.type.label'}}</:title>
+      <:body>
         <form.radioGroup
           @name='types'
           @selectedValue={{@model.type}}
@@ -66,24 +66,23 @@
             @layout='wide'
           />
         </form.radioGroup>
-      {{else}}
-        <form.radioGroup
-          @name='types'
-          @selectedValue={{@model.type}}
-          as |radioGroup|
-        >
-          <radioGroup.card
-            @label={{t (concat 'resources.credential.types.' @model.type)}}
-            @helperText={{t (concat 'resources.credential.help.' @model.type)}}
-            @value={{@model.type}}
-            @layout='wide'
-            @disabled={{true}}
-            readonly={{true}}
-          />
-        </form.radioGroup>
-      {{/if}}
-    </:body>
-  </form.fieldset>
+      </:body>
+    </form.fieldset>
+  {{else}}
+    <form.fieldset>
+      <:title>{{t 'form.type.label'}}</:title>
+      <:description>
+        <Rose::Form::Label>
+          {{t (concat 'resources.credential.types.' @model.type)}}
+        </Rose::Form::Label>
+      </:description>
+      <:body>
+        <Rose::Form::HelperText>{{t
+            (concat 'resources.credential.help.' @model.type)
+          }}</Rose::Form::HelperText>
+      </:body>
+    </form.fieldset>
+  {{/if}}
 
   <form.input
     @name='username'
diff --git a/ui/admin/app/components/form/credential/username_password/index.hbs b/ui/admin/app/components/form/credential/username_password/index.hbs
index 6f7ea1600..193ad220b 100644
--- a/ui/admin/app/components/form/credential/username_password/index.hbs
+++ b/ui/admin/app/components/form/credential/username_password/index.hbs
@@ -43,10 +43,10 @@
       </field.errors>
     {{/if}}
   </form.textarea>
-  <form.fieldset>
-    <:title>{{t 'form.type.label'}}</:title>
-    <:body>
-      {{#if @model.isNew}}
+  {{#if @model.isNew}}
+    <form.fieldset>
+      <:title>{{t 'form.type.label'}}</:title>
+      <:body>
         <form.radioGroup
           @name='types'
           @selectedValue={{@model.type}}
@@ -66,24 +66,23 @@
             @layout='wide'
           />
         </form.radioGroup>
-      {{else}}
-        <form.radioGroup
-          @name='types'
-          @selectedValue={{@model.type}}
-          as |radioGroup|
-        >
-          <radioGroup.card
-            @label={{t (concat 'resources.credential.types.' @model.type)}}
-            @helperText={{t (concat 'resources.credential.help.' @model.type)}}
-            @value={{@model.type}}
-            @layout='wide'
-            @disabled={{true}}
-            readonly={{true}}
-          />
-        </form.radioGroup>
-      {{/if}}
-    </:body>
-  </form.fieldset>
+      </:body>
+    </form.fieldset>
+  {{else}}
+    <form.fieldset>
+      <:title>{{t 'form.type.label'}}</:title>
+      <:description>
+        <Rose::Form::Label>
+          {{t (concat 'resources.credential.types.' @model.type)}}
+        </Rose::Form::Label>
+      </:description>
+      <:body>
+        <Rose::Form::HelperText>{{t
+            (concat 'resources.credential.help.' @model.type)
+          }}</Rose::Form::HelperText>
+      </:body>
+    </form.fieldset>
+  {{/if}}
 
   <form.input
     @name='username'