refactor: 💡 update how project & target are displayed in table (#242)

* refactor: 💡 update how project & target are displayed in table

✅ Closes: ICU-9165

* refactor: 💡 update gap to use rem

* refactor: 💡 update with PR feedback

* refactor: 💡 use flex-direction column instead of display block
This commit is contained in:
Cameron Perera authored and GitHub committed 2023-05-05 13:49:57 -05:00
1 parent 1d3914e5ac
commit d08e4be0c6
3 files changed
+24 -7

No files matched your search

+9 -1
View File
@@ -901,7 +901,7 @@
// Session recording - List // Session recording - List
.session-recording-list-cell-item { .session-recording-list-cell-item {
display: flex; display: flex;
gap: sizing.rems(xs); gap: 0.5rem;
span { span {
display: flex; display: flex;
@@ -909,6 +909,14 @@
} }
} }
.session-recording-list-cell-item.target-column {
flex-direction: column;
span {
gap: 0.5rem;
}
}
// Channels by Connection // Channels by Connection
.channels-by-connection { .channels-by-connection {
&-connection-header { &-connection-header {
@@ -42,13 +42,18 @@
{{! Target }} {{! Target }}
<B.Td> <B.Td>
<div <div
class='session-recording-list-cell-item hds-font-weight-semibold' class='session-recording-list-cell-item target-column hds-font-weight-semibold'
> >
<span><FlightIcon @name='grid' /></span> <span>
<span>{{B.data.targetScopeDisplayName}}</span> <FlightIcon @name='target' />
<span class='hds-foreground-faint'>/</span> {{B.data.target.name}}
<span><FlightIcon @name='target' /></span> </span>
<span>{{B.data.target.name}}</span> <span>
<Hds::Badge
@text={{B.data.targetScopeDisplayName}}
@icon='grid'
/>
</span>
</div> </div>
</B.Td> </B.Td>
{{! Duration }} {{! Duration }}
@@ -39,8 +39,12 @@ module('Acceptance | session recordings | read', function (hooks) {
type: 'org', type: 'org',
scope: { id: 'global', type: 'global' }, scope: { id: 'global', type: 'global' },
}); });
instances.target = this.server.create('target', {
scope: instances.scopes.global,
});
instances.sessionRecording = this.server.create('session-recording', { instances.sessionRecording = this.server.create('session-recording', {
scope: instances.scopes.global, scope: instances.scopes.global,
target: instances.target.attrs,
}); });
instances.connectionRecording = this.server.create('connection-recording', { instances.connectionRecording = this.server.create('connection-recording', {
session_recording: instances.sessionRecording, session_recording: instances.sessionRecording,