From a64b52c2683d9dee5c531d0a6413cbc338cbc19f Mon Sep 17 00:00:00 2001 From: Randall Morey Date: Thu, 24 Sep 2020 14:06:23 -0400 Subject: [PATCH 01/11] =?UTF-8?q?refactor:=20=F0=9F=92=A1=20convert=20form?= =?UTF-8?q?=20error=20components=20to=20nested=20structure?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- addons/rose/addon/components/rose/form/errors.js | 10 ---------- .../rose/form/errors/index.hbs} | 0 .../{errors.stories.mdx => errors/index.stories.mdx} | 0 .../rose/addon/components/rose/form/errors/message.js | 10 ---------- .../rose/form/errors/message/index.hbs} | 0 .../{message.stories.mdx => message/index.stories.mdx} | 0 6 files changed, 20 deletions(-) delete mode 100644 addons/rose/addon/components/rose/form/errors.js rename addons/rose/addon/{templates/components/rose/form/errors.hbs => components/rose/form/errors/index.hbs} (100%) rename addons/rose/addon/components/rose/form/{errors.stories.mdx => errors/index.stories.mdx} (100%) delete mode 100644 addons/rose/addon/components/rose/form/errors/message.js rename addons/rose/addon/{templates/components/rose/form/errors/message.hbs => components/rose/form/errors/message/index.hbs} (100%) rename addons/rose/addon/components/rose/form/errors/{message.stories.mdx => message/index.stories.mdx} (100%) diff --git a/addons/rose/addon/components/rose/form/errors.js b/addons/rose/addon/components/rose/form/errors.js deleted file mode 100644 index bc13c3f56..000000000 --- a/addons/rose/addon/components/rose/form/errors.js +++ /dev/null @@ -1,10 +0,0 @@ -import Component from '@ember/component'; -import layout from '../../../templates/components/rose/form/errors'; - -/** - * A container for error messages. Yields the error message component. - */ -export default Component.extend({ - layout, - tagName: '', -}); diff --git a/addons/rose/addon/templates/components/rose/form/errors.hbs b/addons/rose/addon/components/rose/form/errors/index.hbs similarity index 100% rename from addons/rose/addon/templates/components/rose/form/errors.hbs rename to addons/rose/addon/components/rose/form/errors/index.hbs diff --git a/addons/rose/addon/components/rose/form/errors.stories.mdx b/addons/rose/addon/components/rose/form/errors/index.stories.mdx similarity index 100% rename from addons/rose/addon/components/rose/form/errors.stories.mdx rename to addons/rose/addon/components/rose/form/errors/index.stories.mdx diff --git a/addons/rose/addon/components/rose/form/errors/message.js b/addons/rose/addon/components/rose/form/errors/message.js deleted file mode 100644 index 0f59c6b06..000000000 --- a/addons/rose/addon/components/rose/form/errors/message.js +++ /dev/null @@ -1,10 +0,0 @@ -import Component from '@ember/component'; -import layout from '../../../../templates/components/rose/form/errors/message'; - -/** - * A simple, styled error message. Do not use directly. - */ -export default Component.extend({ - layout, - tagName: '', -}); diff --git a/addons/rose/addon/templates/components/rose/form/errors/message.hbs b/addons/rose/addon/components/rose/form/errors/message/index.hbs similarity index 100% rename from addons/rose/addon/templates/components/rose/form/errors/message.hbs rename to addons/rose/addon/components/rose/form/errors/message/index.hbs diff --git a/addons/rose/addon/components/rose/form/errors/message.stories.mdx b/addons/rose/addon/components/rose/form/errors/message/index.stories.mdx similarity index 100% rename from addons/rose/addon/components/rose/form/errors/message.stories.mdx rename to addons/rose/addon/components/rose/form/errors/message/index.stories.mdx From 1433e78dfd28d01fcd4804b0930a457b79644c59 Mon Sep 17 00:00:00 2001 From: Randall Morey Date: Thu, 24 Sep 2020 14:12:44 -0400 Subject: [PATCH 02/11] =?UTF-8?q?refactor:=20=F0=9F=92=A1=20convert=20form?= =?UTF-8?q?=20label=20and=20helper=20text=20to=20nested?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- addons/rose/addon/components/rose/form/helper-text.js | 7 ------- .../rose/form/helper-text/index.hbs} | 0 .../index.stories.mdx} | 0 addons/rose/addon/components/rose/form/label.js | 7 ------- .../label.hbs => components/rose/form/label/index.hbs} | 0 .../form/{label.stories.mdx => label/index.stories.mdx} | 0 6 files changed, 14 deletions(-) delete mode 100644 addons/rose/addon/components/rose/form/helper-text.js rename addons/rose/addon/{templates/components/rose/form/helper-text.hbs => components/rose/form/helper-text/index.hbs} (100%) rename addons/rose/addon/components/rose/form/{helper-text.stories.mdx => helper-text/index.stories.mdx} (100%) delete mode 100644 addons/rose/addon/components/rose/form/label.js rename addons/rose/addon/{templates/components/rose/form/label.hbs => components/rose/form/label/index.hbs} (100%) rename addons/rose/addon/components/rose/form/{label.stories.mdx => label/index.stories.mdx} (100%) diff --git a/addons/rose/addon/components/rose/form/helper-text.js b/addons/rose/addon/components/rose/form/helper-text.js deleted file mode 100644 index 399088c44..000000000 --- a/addons/rose/addon/components/rose/form/helper-text.js +++ /dev/null @@ -1,7 +0,0 @@ -import Component from '@ember/component'; -import layout from '../../../templates/components/rose/form/helper-text'; - -export default Component.extend({ - layout, - tagName: '', -}); diff --git a/addons/rose/addon/templates/components/rose/form/helper-text.hbs b/addons/rose/addon/components/rose/form/helper-text/index.hbs similarity index 100% rename from addons/rose/addon/templates/components/rose/form/helper-text.hbs rename to addons/rose/addon/components/rose/form/helper-text/index.hbs diff --git a/addons/rose/addon/components/rose/form/helper-text.stories.mdx b/addons/rose/addon/components/rose/form/helper-text/index.stories.mdx similarity index 100% rename from addons/rose/addon/components/rose/form/helper-text.stories.mdx rename to addons/rose/addon/components/rose/form/helper-text/index.stories.mdx diff --git a/addons/rose/addon/components/rose/form/label.js b/addons/rose/addon/components/rose/form/label.js deleted file mode 100644 index 1d26edc8d..000000000 --- a/addons/rose/addon/components/rose/form/label.js +++ /dev/null @@ -1,7 +0,0 @@ -import Component from '@ember/component'; -import layout from '../../../templates/components/rose/form/label'; - -export default Component.extend({ - layout, - tagName: '', -}); diff --git a/addons/rose/addon/templates/components/rose/form/label.hbs b/addons/rose/addon/components/rose/form/label/index.hbs similarity index 100% rename from addons/rose/addon/templates/components/rose/form/label.hbs rename to addons/rose/addon/components/rose/form/label/index.hbs diff --git a/addons/rose/addon/components/rose/form/label.stories.mdx b/addons/rose/addon/components/rose/form/label/index.stories.mdx similarity index 100% rename from addons/rose/addon/components/rose/form/label.stories.mdx rename to addons/rose/addon/components/rose/form/label/index.stories.mdx From ed6a08ddd73e30b91531db984756b1eb4b2962fc Mon Sep 17 00:00:00 2001 From: Randall Morey Date: Thu, 24 Sep 2020 14:47:45 -0400 Subject: [PATCH 03/11] =?UTF-8?q?refactor:=20=F0=9F=92=A1=20convert=20form?= =?UTF-8?q?=20input=20to=20nested=20structure?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- addons/rose/addon/components/rose/form/input.js | 11 ----------- .../rose/form/input/index.hbs} | 0 addons/rose/addon/components/rose/form/input/index.js | 10 ++++++++++ .../{input.stories.mdx => input/index.stories.mdx} | 0 addons/rose/addon/components/rose/form/input/input.js | 7 ------- .../rose/form/input/input/index.hbs} | 0 addons/rose/addon/utilities/component-auto-id.js | 9 +++++++++ .../rose/tests/unit/mixins/component-auto-id-test.js | 11 ----------- .../tests/unit/utilities/component-auto-id-test.js | 9 +++++++++ 9 files changed, 28 insertions(+), 29 deletions(-) delete mode 100644 addons/rose/addon/components/rose/form/input.js rename addons/rose/addon/{templates/components/rose/form/input.hbs => components/rose/form/input/index.hbs} (100%) create mode 100644 addons/rose/addon/components/rose/form/input/index.js rename addons/rose/addon/components/rose/form/{input.stories.mdx => input/index.stories.mdx} (100%) delete mode 100644 addons/rose/addon/components/rose/form/input/input.js rename addons/rose/addon/{templates/components/rose/form/input/input.hbs => components/rose/form/input/input/index.hbs} (100%) create mode 100644 addons/rose/addon/utilities/component-auto-id.js delete mode 100644 addons/rose/tests/unit/mixins/component-auto-id-test.js create mode 100644 addons/rose/tests/unit/utilities/component-auto-id-test.js diff --git a/addons/rose/addon/components/rose/form/input.js b/addons/rose/addon/components/rose/form/input.js deleted file mode 100644 index 60ae3d0f1..000000000 --- a/addons/rose/addon/components/rose/form/input.js +++ /dev/null @@ -1,11 +0,0 @@ -import Component from '@ember/component'; -import layout from '../../../templates/components/rose/form/input'; -import ComponentAutoId from '../../../mixins/component-auto-id'; - -/** - * A simple HTML `` element. - */ -export default Component.extend(ComponentAutoId, { - layout, - tagName: '', -}); diff --git a/addons/rose/addon/templates/components/rose/form/input.hbs b/addons/rose/addon/components/rose/form/input/index.hbs similarity index 100% rename from addons/rose/addon/templates/components/rose/form/input.hbs rename to addons/rose/addon/components/rose/form/input/index.hbs diff --git a/addons/rose/addon/components/rose/form/input/index.js b/addons/rose/addon/components/rose/form/input/index.js new file mode 100644 index 000000000..4fbc071f4 --- /dev/null +++ b/addons/rose/addon/components/rose/form/input/index.js @@ -0,0 +1,10 @@ +import Component from '@glimmer/component'; +import { generateComponentID } from '../../../../utilities/component-auto-id'; + +export default class RoseFormInputComponent extends Component { + + // =attributes + + id = generateComponentID(); + +} diff --git a/addons/rose/addon/components/rose/form/input.stories.mdx b/addons/rose/addon/components/rose/form/input/index.stories.mdx similarity index 100% rename from addons/rose/addon/components/rose/form/input.stories.mdx rename to addons/rose/addon/components/rose/form/input/index.stories.mdx diff --git a/addons/rose/addon/components/rose/form/input/input.js b/addons/rose/addon/components/rose/form/input/input.js deleted file mode 100644 index f20d86c82..000000000 --- a/addons/rose/addon/components/rose/form/input/input.js +++ /dev/null @@ -1,7 +0,0 @@ -import Component from '@ember/component'; -import layout from '../../../../templates/components/rose/form/input/input'; - -export default Component.extend({ - layout, - tagName: '', -}); diff --git a/addons/rose/addon/templates/components/rose/form/input/input.hbs b/addons/rose/addon/components/rose/form/input/input/index.hbs similarity index 100% rename from addons/rose/addon/templates/components/rose/form/input/input.hbs rename to addons/rose/addon/components/rose/form/input/input/index.hbs diff --git a/addons/rose/addon/utilities/component-auto-id.js b/addons/rose/addon/utilities/component-auto-id.js new file mode 100644 index 000000000..de91ecf92 --- /dev/null +++ b/addons/rose/addon/utilities/component-auto-id.js @@ -0,0 +1,9 @@ +import { v1 } from 'ember-uuid'; + +/** + * A function that generates a component ID, based on UUID. + * @return {string} + */ +export function generateComponentID() { + return `component-${v1()}`; +} diff --git a/addons/rose/tests/unit/mixins/component-auto-id-test.js b/addons/rose/tests/unit/mixins/component-auto-id-test.js deleted file mode 100644 index a047b3e7b..000000000 --- a/addons/rose/tests/unit/mixins/component-auto-id-test.js +++ /dev/null @@ -1,11 +0,0 @@ -import EmberObject from '@ember/object'; -import ComponentAutoIdMixin from 'rose/mixins/component-auto-id'; -import { module, test } from 'qunit'; - -module('Unit | Mixin | component-auto-id', function () { - test('it generates an ID and assigns it to the object', function (assert) { - let ComponentAutoIdObject = EmberObject.extend(ComponentAutoIdMixin); - let subject = ComponentAutoIdObject.create(); - assert.ok(subject.id); - }); -}); diff --git a/addons/rose/tests/unit/utilities/component-auto-id-test.js b/addons/rose/tests/unit/utilities/component-auto-id-test.js new file mode 100644 index 000000000..3da16b9d0 --- /dev/null +++ b/addons/rose/tests/unit/utilities/component-auto-id-test.js @@ -0,0 +1,9 @@ +import { generateComponentID } from 'rose/utilities/component-auto-id'; +import { module, test } from 'qunit'; + +module('Unit | Utility | component-auto-id', function () { + test('it generates an ID', function (assert) { + const id = generateComponentID(); + assert.ok(id); + }); +}); From 1c967b5142b50c4228281e0a4c5917081bb49a50 Mon Sep 17 00:00:00 2001 From: Randall Morey Date: Thu, 24 Sep 2020 14:57:28 -0400 Subject: [PATCH 04/11] =?UTF-8?q?refactor:=20=F0=9F=92=A1=20convert=20text?= =?UTF-8?q?area=20component=20to=20nested=20structure?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- addons/rose/addon/components/rose/form/textarea.js | 12 ------------ .../rose/form/textarea/index.hbs} | 0 .../addon/components/rose/form/textarea/index.js | 10 ++++++++++ .../index.stories.mdx} | 0 .../addon/components/rose/form/textarea/textarea.js | 7 ------- .../rose/form/textarea/textarea/index.hbs} | 0 6 files changed, 10 insertions(+), 19 deletions(-) delete mode 100644 addons/rose/addon/components/rose/form/textarea.js rename addons/rose/addon/{templates/components/rose/form/textarea.hbs => components/rose/form/textarea/index.hbs} (100%) create mode 100644 addons/rose/addon/components/rose/form/textarea/index.js rename addons/rose/addon/components/rose/form/{textarea.stories.mdx => textarea/index.stories.mdx} (100%) delete mode 100644 addons/rose/addon/components/rose/form/textarea/textarea.js rename addons/rose/addon/{templates/components/rose/form/textarea/textarea.hbs => components/rose/form/textarea/textarea/index.hbs} (100%) diff --git a/addons/rose/addon/components/rose/form/textarea.js b/addons/rose/addon/components/rose/form/textarea.js deleted file mode 100644 index 8ca045e84..000000000 --- a/addons/rose/addon/components/rose/form/textarea.js +++ /dev/null @@ -1,12 +0,0 @@ -import Component from '@ember/component'; -import layout from '../../../templates/components/rose/form/textarea'; -import ComponentAutoId from '../../../mixins/component-auto-id'; - -/** - * A `