From dbdd1f982aa100f1f0df39fc9ca0c681756cac0b Mon Sep 17 00:00:00 2001 From: Randall Morey Date: Wed, 23 Sep 2020 17:13:49 -0400 Subject: [PATCH] =?UTF-8?q?refactor:=20=F0=9F=92=A1=20convert=20form=20act?= =?UTF-8?q?ions=20component=20to=20nested=20structure?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../rose/form/actions/index.hbs} | 0 .../rose/form/{actions.js => actions/index.js} | 15 ++++++++------- .../index.stories.mdx} | 0 3 files changed, 8 insertions(+), 7 deletions(-) rename addons/rose/addon/{templates/components/rose/form/actions.hbs => components/rose/form/actions/index.hbs} (100%) rename addons/rose/addon/components/rose/form/{actions.js => actions/index.js} (60%) rename addons/rose/addon/components/rose/form/{actions.stories.mdx => actions/index.stories.mdx} (100%) diff --git a/addons/rose/addon/templates/components/rose/form/actions.hbs b/addons/rose/addon/components/rose/form/actions/index.hbs similarity index 100% rename from addons/rose/addon/templates/components/rose/form/actions.hbs rename to addons/rose/addon/components/rose/form/actions/index.hbs diff --git a/addons/rose/addon/components/rose/form/actions.js b/addons/rose/addon/components/rose/form/actions/index.js similarity index 60% rename from addons/rose/addon/components/rose/form/actions.js rename to addons/rose/addon/components/rose/form/actions/index.js index 4bfcbea85..f8d5bb76e 100644 --- a/addons/rose/addon/components/rose/form/actions.js +++ b/addons/rose/addon/components/rose/form/actions/index.js @@ -1,5 +1,5 @@ -import Component from '@ember/component'; -import layout from '../../../templates/components/rose/form/actions'; +import Component from '@glimmer/component'; +import { computed } from '@ember/object'; /** * A set of two form action buttons for submit and cancel. @@ -13,12 +13,13 @@ import layout from '../../../templates/components/rose/form/actions'; * @showCancel={{true}} * @cancel=(fn @cancel) /> */ -export default Component.extend({ - layout, - tagName: '', +export default class RoseFormActionsComponent extends Component { /** * @type {boolean} */ - showCancel: true, -}); + @computed('args.showCancel') + get showCancel() { + return this.args.showCancel ?? true; + } +} diff --git a/addons/rose/addon/components/rose/form/actions.stories.mdx b/addons/rose/addon/components/rose/form/actions/index.stories.mdx similarity index 100% rename from addons/rose/addon/components/rose/form/actions.stories.mdx rename to addons/rose/addon/components/rose/form/actions/index.stories.mdx