From dc68dfad85ee9bdc4ac18a93b43d52b385b53397 Mon Sep 17 00:00:00 2001
From: Susmitha Girumala <susmitha@hashicorp.com>
Date: Tue, 15 Sep 2020 11:00:00 -0400
Subject: [PATCH] test: Add missing account serializer test

Delete account password attribute in mirage to mimic API exactly
---
 addons/api/tests/unit/models/account-test.js  | 11 ------
 .../tests/unit/serializers/account-test.js    | 38 +++++++++++++++++++
 ui/core/mirage/serializers/account.js         |  1 +
 3 files changed, 39 insertions(+), 11 deletions(-)
 create mode 100644 addons/api/tests/unit/serializers/account-test.js

diff --git a/addons/api/tests/unit/models/account-test.js b/addons/api/tests/unit/models/account-test.js
index 4237ae6b6..dcd3fe8bb 100644
--- a/addons/api/tests/unit/models/account-test.js
+++ b/addons/api/tests/unit/models/account-test.js
@@ -4,21 +4,10 @@ import { setupTest } from 'ember-qunit';
 module('Unit | Model | account', function(hooks) {
   setupTest(hooks);
 
-  // Replace this with your real tests.
   test('it exists', function(assert) {
     let store = this.owner.lookup('service:store');
     let model = store.createRecord('account', {});
     assert.ok(model);
   });
 
-  test('it contains attributes', function(assert) {
-    let store = this.owner.lookup('service:store');
-    let model = store.createRecord('account', {
-      type: 'password',
-      attributes: {
-        login_name: 'loginname'
-      }
-    });
-    assert.equal(model.attributes.login_name, 'loginname');
-  });
 });
diff --git a/addons/api/tests/unit/serializers/account-test.js b/addons/api/tests/unit/serializers/account-test.js
new file mode 100644
index 000000000..9ab5b521c
--- /dev/null
+++ b/addons/api/tests/unit/serializers/account-test.js
@@ -0,0 +1,38 @@
+import { module, test } from 'qunit';
+import { setupTest } from 'ember-qunit';
+
+module('Unit | Serializer | account', function(hooks) {
+  setupTest(hooks);
+
+  test('it serializes account', function (assert) {
+    assert.expect(1);
+    const store = this.owner.lookup('service:store');
+    const serializer = store.serializerFor('account');
+    const record = store.createRecord('account', {
+      type: 'password',
+      name: 'Name',
+      description: 'Description',
+      attributes: {
+        login_name: 'Login Name',
+        password: 'Password',
+      },
+      auth_method_id: '1',
+      version: 1
+    });
+    const snapshot = record._createSnapshot();
+    snapshot.adapterOptions = {};
+    const serializedRecord = serializer.serialize(snapshot);
+    assert.deepEqual(serializedRecord, {
+      type: 'password',
+      name: 'Name',
+      description: 'Description',
+      attributes: {
+        login_name: 'Login Name',
+        password: 'Password',
+      },
+      auth_method_id: '1',
+      version: 1
+    });
+  });
+
+});
diff --git a/ui/core/mirage/serializers/account.js b/ui/core/mirage/serializers/account.js
index 7c6186756..85d38851b 100644
--- a/ui/core/mirage/serializers/account.js
+++ b/ui/core/mirage/serializers/account.js
@@ -6,6 +6,7 @@ export default ApplicationSerializer.extend({
   _hashForModel(model) {
     const json = ApplicationSerializer.prototype._hashForModel.apply(this, arguments);
     json.auth_method_id = model.authMethodId;
+    delete json.attributes?.password;
     return json;
   }
 });