From dea4a62955ab13fa5318f59441fa3211cd3f51e9 Mon Sep 17 00:00:00 2001 From: Cameron Perera Date: Wed, 4 Sep 2024 15:44:42 -0500 Subject: [PATCH] =?UTF-8?q?test:=20=F0=9F=92=8D=20add=20TODO=20for=20a11y?= =?UTF-8?q?=20violations=20(#2471)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../acceptance/accounts/change-password-test.js | 5 +++++ .../tests/acceptance/roles/global-scope-test.js | 10 ++++++++++ ui/admin/tests/acceptance/roles/org-scope-test.js | 5 +++++ ui/admin/tests/acceptance/scopes/read-test.js | 5 +++++ .../acceptance/session-recordings/read-test.js | 5 +++++ ui/admin/tests/acceptance/targets/workers-test.js | 5 +++++ ui/admin/tests/acceptance/workers/read-test.js | 5 +++++ .../acceptance/projects/sessions/index-test.js | 5 +++++ .../acceptance/projects/targets/index-test.js | 5 +++++ ui/desktop/tests/acceptance/scopes-test.js | 15 +++++++++++++++ 10 files changed, 65 insertions(+) diff --git a/ui/admin/tests/acceptance/accounts/change-password-test.js b/ui/admin/tests/acceptance/accounts/change-password-test.js index 798611dd9..e7264dcc3 100644 --- a/ui/admin/tests/acceptance/accounts/change-password-test.js +++ b/ui/admin/tests/acceptance/accounts/change-password-test.js @@ -77,6 +77,11 @@ module('Acceptance | accounts | change password', function (hooks) { test('can change password for account', async function (assert) { assert.expect(2); + // TODO: Failing due to a11y violation while in dark mode. + // Investigating issue with styles not properly + // being applied during test. + const session = this.owner.lookup('service:session'); + session.set('data.theme', 'light'); this.server.post( '/accounts/:idMethod', (_, { params: { idMethod }, requestBody }) => { diff --git a/ui/admin/tests/acceptance/roles/global-scope-test.js b/ui/admin/tests/acceptance/roles/global-scope-test.js index cad8a9eee..5e0a2dea4 100644 --- a/ui/admin/tests/acceptance/roles/global-scope-test.js +++ b/ui/admin/tests/acceptance/roles/global-scope-test.js @@ -114,6 +114,11 @@ module('Acceptance | roles | global-scope', function (hooks) { }); test('visiting role scopes', async function (assert) { + // TODO: Failing due to a11y violation while in dark mode. + // Investigating issue with styles not properly + // being applied during test. + const session = this.owner.lookup('service:session'); + session.set('data.theme', 'light'); await visit(urls.role); await click(`[href="${urls.roleScopes}"]`); @@ -394,6 +399,11 @@ module('Acceptance | roles | global-scope', function (hooks) { }); test('user can save custom scopes to add on manage custom scopes page', async function (assert) { + // TODO: Failing due to a11y violation while in dark mode. + // Investigating issue with styles not properly + // being applied during test. + const session = this.owner.lookup('service:session'); + session.set('data.theme', 'light'); instances.role.update({ grant_scope_ids: [] }); await visit(urls.role); diff --git a/ui/admin/tests/acceptance/roles/org-scope-test.js b/ui/admin/tests/acceptance/roles/org-scope-test.js index 0eb05581f..601fae735 100644 --- a/ui/admin/tests/acceptance/roles/org-scope-test.js +++ b/ui/admin/tests/acceptance/roles/org-scope-test.js @@ -107,6 +107,11 @@ module('Acceptance | roles | org-scope', function (hooks) { }); test('visiting role scopes', async function (assert) { + // TODO: Failing due to a11y violation while in dark mode. + // Investigating issue with styles not properly + // being applied during test. + const session = this.owner.lookup('service:session'); + session.set('data.theme', 'light'); await visit(urls.role); await click(`[href="${urls.roleScopes}"]`); diff --git a/ui/admin/tests/acceptance/scopes/read-test.js b/ui/admin/tests/acceptance/scopes/read-test.js index e7e05acbd..4ae6d78c9 100644 --- a/ui/admin/tests/acceptance/scopes/read-test.js +++ b/ui/admin/tests/acceptance/scopes/read-test.js @@ -74,6 +74,11 @@ module('Acceptance | scopes | read', function (hooks) { }); test('visiting global scope settings when feature flag is enabled', async function (assert) { + // TODO: Failing due to a11y violation while in dark mode. + // Investigating issue with styles not properly + // being applied during test. + const session = this.owner.lookup('service:session'); + session.set('data.theme', 'light'); features.enable('ssh-session-recording'); await visit(urls.globalScope); await a11yAudit(); diff --git a/ui/admin/tests/acceptance/session-recordings/read-test.js b/ui/admin/tests/acceptance/session-recordings/read-test.js index ea61e0487..1deae5fda 100644 --- a/ui/admin/tests/acceptance/session-recordings/read-test.js +++ b/ui/admin/tests/acceptance/session-recordings/read-test.js @@ -68,6 +68,11 @@ module('Acceptance | session-recordings | read', function (hooks) { }); test('visiting a session recording', async function (assert) { + // TODO: Failing due to a11y violation while in dark mode. + // Investigating issue with styles not properly + // being applied during test. + const session = this.owner.lookup('service:session'); + session.set('data.theme', 'light'); featuresService.enable('ssh-session-recording'); // Visit session recordings await visit(urls.sessionRecordings); diff --git a/ui/admin/tests/acceptance/targets/workers-test.js b/ui/admin/tests/acceptance/targets/workers-test.js index 2dd2ab515..e7ebb8f3d 100644 --- a/ui/admin/tests/acceptance/targets/workers-test.js +++ b/ui/admin/tests/acceptance/targets/workers-test.js @@ -80,6 +80,11 @@ module('Acceptance | targets | workers', function (hooks) { }); test('visiting target workers', async function (assert) { + // TODO: Failing due to a11y violation while in dark mode. + // Investigating issue with styles not properly + // being applied during test. + const session = this.owner.lookup('service:session'); + session.set('data.theme', 'light'); await visit(urls.target); await click(`[href="${urls.targetWorkers}"]`); diff --git a/ui/admin/tests/acceptance/workers/read-test.js b/ui/admin/tests/acceptance/workers/read-test.js index 7b16e896f..a4943d039 100644 --- a/ui/admin/tests/acceptance/workers/read-test.js +++ b/ui/admin/tests/acceptance/workers/read-test.js @@ -58,6 +58,11 @@ module('Acceptance | workers | read', function (hooks) { }); test('visiting worker', async function (assert) { + // TODO: Failing due to a11y violation while in dark mode. + // Investigating issue with styles not properly + // being applied during test. + const session = this.owner.lookup('service:session'); + session.set('data.theme', 'light'); await visit(urls.workers); await a11yAudit(); diff --git a/ui/desktop/tests/acceptance/projects/sessions/index-test.js b/ui/desktop/tests/acceptance/projects/sessions/index-test.js index 28293aa0e..8fd3986a9 100644 --- a/ui/desktop/tests/acceptance/projects/sessions/index-test.js +++ b/ui/desktop/tests/acceptance/projects/sessions/index-test.js @@ -196,6 +196,11 @@ module('Acceptance | projects | sessions | index', function (hooks) { }); test('visiting sessions without targets is OK', async function (assert) { + // TODO: Failing due to a11y violation while in dark mode. + // Investigating issue with styles not properly + // being applied during test. + const session = this.owner.lookup('service:session'); + session.set('data.theme', 'light'); instances.session.update({ targetId: undefined }); const sessionsCount = this.server.schema.sessions.all().models.length; await visit(urls.projects); diff --git a/ui/desktop/tests/acceptance/projects/targets/index-test.js b/ui/desktop/tests/acceptance/projects/targets/index-test.js index 9133cf360..b74aec8fa 100644 --- a/ui/desktop/tests/acceptance/projects/targets/index-test.js +++ b/ui/desktop/tests/acceptance/projects/targets/index-test.js @@ -175,6 +175,11 @@ module('Acceptance | projects | targets | index', function (hooks) { }); test('visiting targets index', async function (assert) { + // TODO: Failing due to a11y violation while in dark mode. + // Investigating issue with styles not properly + // being applied during test. + const session = this.owner.lookup('service:session'); + session.set('data.theme', 'light'); const targetsCount = getTargetCount(); await visit(urls.projects); diff --git a/ui/desktop/tests/acceptance/scopes-test.js b/ui/desktop/tests/acceptance/scopes-test.js index a5745d3b6..9e12af156 100644 --- a/ui/desktop/tests/acceptance/scopes-test.js +++ b/ui/desktop/tests/acceptance/scopes-test.js @@ -157,6 +157,11 @@ module('Acceptance | scopes', function (hooks) { }); test('visiting global scope', async function (assert) { + // TODO: Failing due to a11y violation while in dark mode. + // Investigating issue with styles not properly + // being applied during test. + const session = this.owner.lookup('service:session'); + session.set('data.theme', 'light'); assert.expect(1); await visit(urls.scopes.global); @@ -170,6 +175,11 @@ module('Acceptance | scopes', function (hooks) { // In order to resolve this, we might hoist authentication routes up from // under scopes. test('visiting global scope is not successful when the global scope cannot be fetched', async function (assert) { + // TODO: Failing due to a11y violation while in dark mode. + // Investigating issue with styles not properly + // being applied during test. + const session = this.owner.lookup('service:session'); + session.set('data.theme', 'light'); assert.expect(1); this.server.get('/scopes/:id', ({ scopes }, { params: { id } }) => { const scope = scopes.find(id); @@ -184,6 +194,11 @@ module('Acceptance | scopes', function (hooks) { }); test('visiting org scope', async function (assert) { + // TODO: Failing due to a11y violation while in dark mode. + // Investigating issue with styles not properly + // being applied during test. + const session = this.owner.lookup('service:session'); + session.set('data.theme', 'light'); assert.expect(1); await visit(urls.scopes.org);