From df609dcf2c3a664583697f302683292f241632ac Mon Sep 17 00:00:00 2001 From: Zhihe Li Date: Fri, 20 May 2022 12:53:52 -0400 Subject: [PATCH] =?UTF-8?q?refactor:=20=F0=9F=92=A1=20Update=20deprecated?= =?UTF-8?q?=20new=20window=20handler=20(#1111)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ✅ Closes: ICU-4037 --- ui/desktop/electron-app/src/index.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/ui/desktop/electron-app/src/index.js b/ui/desktop/electron-app/src/index.js index 35540da6b..8ba949175 100644 --- a/ui/desktop/electron-app/src/index.js +++ b/ui/desktop/electron-app/src/index.js @@ -115,12 +115,13 @@ const createWindow = (partition, closeWindowCB) => { // Opens external links in the host default browser. // We just allow boundaryproject.io domain to open on external window (for now). - browserWindow.webContents.on('new-window', (event, url) => { - /* eng-disable LIMIT_NAVIGATION_JS_CHECK */ - event.preventDefault(); + browserWindow.webContents.setWindowOpenHandler(({ url }) => { if (url.startsWith('https://boundaryproject.io/')) { shell.openExternal(url); } + + // Prevent opening of a browser window in electron + return { action: 'deny' }; }); browserWindow.on('unresponsive', () => {