From e60d11eddd109d34935060a0a67fd86ade83fd62 Mon Sep 17 00:00:00 2001
From: NatashaKab <133793701+NatashaKab@users.noreply.github.com>
Date: Fri, 14 Jul 2023 15:39:57 -0400
Subject: [PATCH] Icu 10178 use hds table in groups list view (#1768)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* chore: 🤖 Retire rose form textarea

✅ Closes: ICU-9425

* refactor: 💡 Added the disabled feature requested by Dharini

* refactor: 💡 Rose tables to HDS tables in Users

* refactor: 💡 Removed implementation of rose tables in users

* refactor: 💡 use hds table in groups list view

* refactor: 💡 Removed the group list class Dharini mentioned

* refactor: 💡 Resolved the conflicts in user list table and group

---------

Co-authored-by: Dharini Jeeva <dharini@hashicorp.com>
---
 .../templates/scopes/scope/groups/index.hbs   | 68 +++++++++----------
 .../templates/scopes/scope/users/index.hbs    |  1 -
 2 files changed, 32 insertions(+), 37 deletions(-)

diff --git a/ui/admin/app/templates/scopes/scope/groups/index.hbs b/ui/admin/app/templates/scopes/scope/groups/index.hbs
index 205b36c26..bda145550 100644
--- a/ui/admin/app/templates/scopes/scope/groups/index.hbs
+++ b/ui/admin/app/templates/scopes/scope/groups/index.hbs
@@ -31,42 +31,38 @@
 
     {{#if @model}}
 
-      <Rose::Table as |table|>
-        <table.header as |header|>
-          <header.row as |row|>
-            <row.headerCell>{{t 'form.name.label'}}</row.headerCell>
-            <row.headerCell>{{t 'form.id.label'}}</row.headerCell>
-          </header.row>
-        </table.header>
-        <table.body as |body|>
-          {{#each @model as |group|}}
-            <body.row as |row|>
-              <row.headerCell>
-                {{#if (can 'read model' group)}}
-                  <LinkTo
-                    @route='scopes.scope.groups.group'
-                    @model={{group.id}}
-                  >
-                    {{group.displayName}}
-                  </LinkTo>
-                {{else}}
-                  {{group.displayName}}
-                {{/if}}
-                <p>{{group.description}}</p>
-              </row.headerCell>
-              <row.cell>
-                <Copyable
-                  @text={{group.id}}
-                  @buttonText={{t 'actions.copy-to-clipboard'}}
-                  @acknowledgeText={{t 'states.copied'}}
-                >
-                  <code>{{group.id}}</code>
-                </Copyable>
-              </row.cell>
-            </body.row>
-          {{/each}}
-        </table.body>
-      </Rose::Table>
+      <Hds::Table
+        @model={{@model}}
+        @columns={{array
+          (hash label=(t 'form.name.label'))
+          (hash label=(t 'form.id.label'))
+        }}
+        @valign='middle'
+      >
+        <:body as |B|>
+          <B.Tr>
+            <B.Td>
+              {{#if (can 'read group' B.data)}}
+                <LinkTo @route='scopes.scope.groups.group' @model={{B.data.id}}>
+                  {{B.data.displayName}}
+                </LinkTo>
+              {{else}}
+                {{B.data.displayName}}
+              {{/if}}
+              <p>{{B.data.description}}</p>
+            </B.Td>
+            <B.Td>
+              <Copyable
+                @text={{B.data.id}}
+                @buttonText={{t 'actions.copy-to-clipboard'}}
+                @acknowledgeText={{t 'states.copied'}}
+              >
+                <code>{{B.data.id}}</code>
+              </Copyable>
+            </B.Td>
+          </B.Tr>
+        </:body>
+      </Hds::Table>
 
     {{else}}
 
diff --git a/ui/admin/app/templates/scopes/scope/users/index.hbs b/ui/admin/app/templates/scopes/scope/users/index.hbs
index 47ceeea25..ce7a5a5b8 100644
--- a/ui/admin/app/templates/scopes/scope/users/index.hbs
+++ b/ui/admin/app/templates/scopes/scope/users/index.hbs
@@ -34,7 +34,6 @@
     {{#if @model}}
 
       <Hds::Table
-        class='users-list-table'
         @model={{@model}}
         @columns={{array
           (hash label=(t 'form.name.label'))