From eac4ebe2db0e57ddf45bb7d691bc923871565855 Mon Sep 17 00:00:00 2001
From: Randall Morey <randall@randallmorey.com>
Date: Tue, 22 Sep 2020 16:37:31 -0400
Subject: [PATCH] chore: add helper text to certain form fields

---
 ui/core/app/components/form/host/index.hbs        | 3 +++
 ui/core/app/components/form/role/grants/index.hbs | 4 ++--
 ui/core/app/components/form/role/index.hbs        | 2 ++
 ui/core/app/components/form/target/index.hbs      | 3 +++
 ui/core/translations/form/en-us.yaml              | 5 +++++
 5 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/ui/core/app/components/form/host/index.hbs b/ui/core/app/components/form/host/index.hbs
index 7c0fcb8ef..af2ddf471 100644
--- a/ui/core/app/components/form/host/index.hbs
+++ b/ui/core/app/components/form/host/index.hbs
@@ -18,6 +18,7 @@
     @value={{@model.name}}
     @label={{t "form.name.label"}}
     @error={{@model.errors.name}}
+    @helperText={{t "form.name.help"}}
     readonly={{false}}
   as |field|>
     {{#if @model.errors.name}}
@@ -35,6 +36,7 @@
     @value={{@model.description}}
     @label={{t "form.description.label"}}
     @error={{@model.errors.description}}
+    @helperText={{t "form.description.help"}}
     disabled={{@model.isSaving}}
     readonly={{false}}
   as |field|>
@@ -53,6 +55,7 @@
     @value={{@model.attributes.address}}
     @label={{t "form.address.label"}}
     @error={{@model.errors.name}}
+    @helperText={{t "form.address.help"}}
     readonly={{false}}
   as |field|>
     {{#if @model.errors.name}}
diff --git a/ui/core/app/components/form/role/grants/index.hbs b/ui/core/app/components/form/role/grants/index.hbs
index 9cd980868..d4fc71207 100644
--- a/ui/core/app/components/form/role/grants/index.hbs
+++ b/ui/core/app/components/form/role/grants/index.hbs
@@ -17,7 +17,7 @@
           <input.label>{{t "titles.new-grant"}}</input.label>
         </item.key>
         <item.cell>
-          <input.field />
+          <input.field title={{t "form.grant.help"}} />
         </item.cell>
         <item.cell>
           <Rose::Button
@@ -66,7 +66,7 @@
             <input.label>{{t "form.grant.label"}}</input.label>
           </item.key>
           <item.cell>
-            <input.field />
+            <input.field title={{t "form.grant.help"}} />
           </item.cell>
         </form.input>
         <item.cell>
diff --git a/ui/core/app/components/form/role/index.hbs b/ui/core/app/components/form/role/index.hbs
index 0bcc6df4c..a35279612 100644
--- a/ui/core/app/components/form/role/index.hbs
+++ b/ui/core/app/components/form/role/index.hbs
@@ -12,6 +12,7 @@
     @value={{@model.name}}
     @label={{t "form.name.label"}}
     @error={{@model.errors.name}}
+    @helperText={{t "form.name.help"}}
     readonly={{false}}
   as |field|>
     {{#if @model.errors.name}}
@@ -29,6 +30,7 @@
     @value={{@model.description}}
     @label={{t "form.description.label"}}
     @error={{@model.errors.description}}
+    @helperText={{t "form.description.help"}}
     disabled={{@model.isSaving}}
     readonly={{false}}
   as |field|>
diff --git a/ui/core/app/components/form/target/index.hbs b/ui/core/app/components/form/target/index.hbs
index 7cc431613..f061923bf 100644
--- a/ui/core/app/components/form/target/index.hbs
+++ b/ui/core/app/components/form/target/index.hbs
@@ -18,6 +18,7 @@
     @value={{@model.name}}
     @label={{t "form.name.label"}}
     @error={{@model.errors.name}}
+    @helperText={{t "form.name.help"}}
   as |field|>
     {{#if @model.errors.name}}
       <field.errors as |errors|>
@@ -34,6 +35,7 @@
     @value={{@model.description}}
     @label={{t "form.description.label"}}
     @error={{@model.errors.description}}
+    @helperText={{t "form.description.help"}}
   as |field|>
     {{#if @model.errors.description}}
       <field.errors as |errors|>
@@ -51,6 +53,7 @@
     @value={{@model.attributes.default_port}}
     @label={{t "form.default_port.label"}}
     @error={{@model.errors.default_port}}
+    @helperText={{t "form.default_port.help"}}
     min="0"
     step="1"
   as |field|>
diff --git a/ui/core/translations/form/en-us.yaml b/ui/core/translations/form/en-us.yaml
index ff2030cff..1c271aaa9 100644
--- a/ui/core/translations/form/en-us.yaml
+++ b/ui/core/translations/form/en-us.yaml
@@ -2,18 +2,23 @@ id:
   label: ID
 name:
   label: Name
+  help: Optional name for identification purposes
 description:
   label: Description
+  help: Optional description for identification purposes
 type:
   label: Type
+  help: The type of the resource, to help differentiate schemas
 login_name:
   label: Username
 password:
   label: Password
 grant:
   label: Grant
+  help: A permissions grant string for a role
 address:
   label: Address
+  help: An IP, host name, or other routable address
 default_port:
   label: Default Port
 current_password: