From ee3c550809930d00b13afb11a89f936609a2b29c Mon Sep 17 00:00:00 2001 From: Randall Morey Date: Sun, 6 Nov 2022 17:44:06 -0800 Subject: [PATCH] =?UTF-8?q?chore:=20=F0=9F=A4=96=20improve=20targets/new?= =?UTF-8?q?=20titling=20-=20icu-6719=20(#1416)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ✅ Closes: icu-6719 --- addons/core/translations/resources/en-us.yaml | 2 ++ .../app/controllers/scopes/scope/targets/new.js | 15 +++++++++++++++ .../app/templates/scopes/scope/targets/index.hbs | 2 +- .../app/templates/scopes/scope/targets/new.hbs | 3 ++- 4 files changed, 20 insertions(+), 2 deletions(-) diff --git a/addons/core/translations/resources/en-us.yaml b/addons/core/translations/resources/en-us.yaml index d8ac7e65c..4b6d6bf24 100644 --- a/addons/core/translations/resources/en-us.yaml +++ b/addons/core/translations/resources/en-us.yaml @@ -289,6 +289,8 @@ target: title: Target Connection Details proxy_url: title: Proxy URL + titles: + new: New Target actions: create: New Target delete: Delete Target diff --git a/ui/admin/app/controllers/scopes/scope/targets/new.js b/ui/admin/app/controllers/scopes/scope/targets/new.js index bd048a0ef..03410dcd2 100644 --- a/ui/admin/app/controllers/scopes/scope/targets/new.js +++ b/ui/admin/app/controllers/scopes/scope/targets/new.js @@ -1,7 +1,22 @@ import Controller from '@ember/controller'; +import { inject as service } from '@ember/service'; export default class ScopesScopeTargetsNewController extends Controller { + // =services + + @service intl; + // =attributes queryParams = ['type']; + + // =attributes + + /** + * Translated roles breadcrumb + * @type {string} + */ + get breadCrumb() { + return this.intl.t('resources.target.titles.new'); + } } diff --git a/ui/admin/app/templates/scopes/scope/targets/index.hbs b/ui/admin/app/templates/scopes/scope/targets/index.hbs index 41b74500d..94fb019e6 100644 --- a/ui/admin/app/templates/scopes/scope/targets/index.hbs +++ b/ui/admin/app/templates/scopes/scope/targets/index.hbs @@ -18,7 +18,7 @@ {{#if (can 'create model' this.scope collection='targets')}} {{#if @model}} {{t - 'titles.new' + 'resources.target.titles.new' }} {{/if}} {{/if}} diff --git a/ui/admin/app/templates/scopes/scope/targets/new.hbs b/ui/admin/app/templates/scopes/scope/targets/new.hbs index 285da36b2..58d9e0d43 100644 --- a/ui/admin/app/templates/scopes/scope/targets/new.hbs +++ b/ui/admin/app/templates/scopes/scope/targets/new.hbs @@ -8,9 +8,10 @@

- {{t 'titles.new'}} + {{t 'resources.target.titles.new'}}

+

{{t 'resources.target.description'}}