refactor: 💡 remove renderTemplate usage from creds resources

2022-01-25 10:18:10 -05:00
1 parent bc9526f008
commit ef018aac59
@@ -0,0 +1,13 @@
+import Controller from '@ember/controller';
+
+export default class ScopesScopeCredentialStoresCredentialStoreCredentialLibrariesCredentialLibraryController extends Controller {
+  // =attributes
+
+  /**
+   * A model breadcrumb
+   * @type {string}
+   */
+  get breadCrumb() {
+    return this.model.displayName;
+  }
+}
@@ -0,0 +1,18 @@
+import Controller from '@ember/controller';
+import { inject as service } from '@ember/service';
+
+export default class ScopesScopeCredentialStoresNewController extends Controller {
+  // =services
+
+  @service intl;
+
+  // =attributes
+
+  /**
+   * Breadcrumb for new route
+   * @type {string}
+   */
+  get breadCrumb() {
+    return this.intl.t('titles.new');
+  }
+}
@@ -8,27 +8,4 @@ export default class ScopesScopeCredentialStoresCredentialStoreRoute extends Rou
  async model({ credential_store_id }) {
    return this.store.findRecord('credential-store', credential_store_id);
  }
-
-  /**
-   * Render credential store header, navigation and actions page sections.
-   * @override
-   */
-  renderTemplate() {
-    super.renderTemplate(...arguments);
-
-    this.render('scopes/scope/credential-stores/credential-store/-header', {
-      into: 'scopes/scope/credential-stores/credential-store',
-      outlet: 'header',
-    });
-
-    this.render('scopes/scope/credential-stores/credential-store/-navigation', {
-      into: 'scopes/scope/credential-stores/credential-store',
-      outlet: 'navigation',
-    });
-
-    this.render('scopes/scope/credential-stores/credential-store/-actions', {
-      into: 'scopes/scope/credential-stores/credential-store',
-      outlet: 'actions',
-    });
-  }
 }
@@ -81,7 +81,7 @@ export default class ScopesScopeCredentialStoresCredentialStoreCredentialLibrari
  @confirm('questions.delete-confirm')
  @notifyError(({ message }) => message, { catch: true })
  @notifySuccess('notifications.delete-success')
-  async delete(credentialLibrary) {
+  async deleteCredentialLibrary(credentialLibrary) {
    await credentialLibrary.destroyRecord();
    await this.router.replaceWith(
      'scopes.scope.credential-stores.credential-store.credential-libraries'
@@ -14,36 +14,4 @@ export default class ScopesScopeCredentialStoresCredentialStoreCredentialLibrari
      reload: true,
    });
  }
-
-  /**
-   * Renders the credential library specific templates for header, navigation, and action page sections.
-   * @override
-   */
-  renderTemplate() {
-    super.renderTemplate(...arguments);
-
-    this.render(
-      'scopes/scope/credential-stores/credential-store/credential-libraries/credential-library/-header',
-      {
-        into: 'scopes/scope/credential-stores/credential-store',
-        outlet: 'header',
-      }
-    );
-
-    this.render(
-      'scopes/scope/credential-stores/credential-store/credential-libraries/credential-library/-navigation',
-      {
-        into: 'scopes/scope/credential-stores/credential-store',
-        outlet: 'navigation',
-      }
-    );
-
-    this.render(
-      'scopes/scope/credential-stores/credential-store/credential-libraries/credential-library/-actions',
-      {
-        into: 'scopes/scope/credential-stores/credential-store',
-        outlet: 'actions',
-      }
-    );
-  }
 }
@@ -16,31 +16,4 @@ export default class ScopesScopeCredentialStoresCredentialStoreCredentialLibrari
      credential_store_id,
    });
  }
-
-  /**
-   * Renders new credential library specific templates for header, navigation,
-   * and action page sections.
-   * @override
-   */
-  renderTemplate() {
-    super.renderTemplate(...arguments);
-
-    this.render(
-      'scopes/scope/credential-stores/credential-store/credential-libraries/new/-header',
-      {
-        into: 'scopes/scope/credential-stores/credential-store',
-        outlet: 'header',
-      }
-    );
-
-    this.render('_empty', {
-      into: 'scopes/scope/credential-stores/credential-store',
-      outlet: 'navigation',
-    });
-
-    this.render('_empty', {
-      into: 'scopes/scope/credential-stores/credential-store',
-      outlet: 'actions',
-    });
-  }
 }
@@ -1,24 +1,3 @@
 {{page-title @model.displayName}}

-<Rose::Layout::Page as |page|>
-
-  <page.breadcrumbs>
-    <BreadCrumbs />
-  </page.breadcrumbs>
-
-  <page.header>
-    {{outlet 'header'}}
-  </page.header>
-
-  <page.navigation>
-    {{outlet 'navigation'}}
-  </page.navigation>
-
-  <page.actions>
-    {{outlet 'actions'}}
-  </page.actions>
-
-  <page.body>
 {{outlet}}
-  </page.body>
-</Rose::Layout::Page>
@@ -1,15 +0,0 @@
-{{#if (can 'delete model' @model)}}
-  <Rose::Dropdown
-    @text={{t 'actions.manage'}}
-    @dropdownRight={{true}}
-    as |dropdown|
-  >
-    <dropdown.button
-      @style='danger'
-      @disabled={{@model.canSave}}
-      {{on 'click' (route-action 'delete' @model)}}
-    >
-      {{t 'resources.credential-library.actions.delete'}}
-    </dropdown.button>
-  </Rose::Dropdown>
-{{/if}}
@@ -1,12 +0,0 @@
-<h2>
-  {{t 'resources.credential-library.title'}}
-  <DocLink @doc='credential-library' @iconSize='large' />
-</h2>
-<p>{{t 'resources.credential-library.description'}}</p>
-<Copyable
-  @text={{@model.id}}
-  @buttonText={{t 'actions.copy-to-clipboard'}}
-  @acknowledgeText={{t 'states.copied'}}
->
-  <code>{{@model.id}}</code>
-</Copyable>
@@ -1,7 +0,0 @@
-<Rose::Nav::Tabs as |nav|>
-  <nav.link
-    @route='scopes.scope.credential-stores.credential-store.credential-libraries.credential-library.index'
-  >
-    {{t 'titles.details'}}
-  </nav.link>
-</Rose::Nav::Tabs>
@@ -1,5 +1,57 @@
+<Rose::Layout::Page as |page|>
+
+  <page.breadcrumbs>
+    <BreadCrumbs />
+  </page.breadcrumbs>
+
+  <page.header>
+    <h2>
+      {{t 'resources.credential-library.title'}}
+      <DocLink @doc='credential-library' @iconSize='large' />
+    </h2>
+    <p>{{t 'resources.credential-library.description'}}</p>
+    <Copyable
+      @text={{@model.id}}
+      @buttonText={{t 'actions.copy-to-clipboard'}}
+      @acknowledgeText={{t 'states.copied'}}
+    >
+      <code>{{@model.id}}</code>
+    </Copyable>
+  </page.header>
+
+  <page.navigation>
+    <Rose::Nav::Tabs as |nav|>
+      <nav.link
+        @route='scopes.scope.credential-stores.credential-store.credential-libraries.credential-library.index'
+      >
+        {{t 'titles.details'}}
+      </nav.link>
+    </Rose::Nav::Tabs>
+  </page.navigation>
+
+  <page.actions>
+    {{#if (can 'delete model' @model)}}
+      <Rose::Dropdown
+        @text={{t 'actions.manage'}}
+        @dropdownRight={{true}}
+        as |dropdown|
+      >
+        <dropdown.button
+          @style='danger'
+          @disabled={{@model.canSave}}
+          {{on 'click' (route-action 'deleteCredentialLibrary' @model)}}
+        >
+          {{t 'resources.credential-library.actions.delete'}}
+        </dropdown.button>
+      </Rose::Dropdown>
+    {{/if}}
+  </page.actions>
+
+  <page.body>
    <Form::CredentialLibrary
      @model={{@model}}
      @submit={{route-action 'save' @model}}
      @cancel={{route-action 'cancel' @model}}
    />
+  </page.body>
+</Rose::Layout::Page>
@@ -1,3 +1,26 @@
+<Rose::Layout::Page as |page|>
+
+  <page.breadcrumbs>
+    <BreadCrumbs />
+  </page.breadcrumbs>
+
+  <page.header>
+    <CredentialStores::CredentialStore::Header
+      @model={{this.credentialStore}}
+    />
+  </page.header>
+
+  <page.navigation>
+    <CredentialStores::CredentialStore::Nav @model={{this.credentialStore}} />
+  </page.navigation>
+
+  <page.actions>
+    <CredentialStores::CredentialStore::Actions
+      @model={{this.credentialStore}}
+    />
+  </page.actions>
+
+  <page.body>
    {{#if @model}}

      <Rose::Table as |table|>
@@ -27,7 +50,8 @@
              <row.cell>
                <Rose::Badge>{{t
                    (concat
-                  'resources.credential-library.types.' credentialLibrary.type
+                      'resources.credential-library.types.'
+                      credentialLibrary.type
                    )
                  }}</Rose::Badge>
              </row.cell>
@@ -100,3 +124,5 @@
      </Rose::Layout::Centered>

    {{/if}}
+  </page.body>
+</Rose::Layout::Page>
@@ -1,7 +1,22 @@
 {{page-title (t 'titles.new')}}

+<Rose::Layout::Page as |page|>
+
+  <page.breadcrumbs>
+    <BreadCrumbs />
+  </page.breadcrumbs>
+
+  <page.header>
+    <h2>
+      {{t 'titles.new'}}
+    </h2>
+  </page.header>
+
+  <page.body>
    <Form::CredentialLibrary
      @model={{@model}}
      @submit={{route-action 'save' @model}}
      @cancel={{route-action 'cancel' @model}}
    />
+  </page.body>
+</Rose::Layout::Page>
@@ -1,3 +0,0 @@
-<h2>
-  {{t 'titles.new'}}
-</h2>
@@ -1,5 +1,26 @@
+<Rose::Layout::Page as |page|>
+
+  <page.breadcrumbs>
+    <BreadCrumbs />
+  </page.breadcrumbs>
+
+  <page.header>
+    <CredentialStores::CredentialStore::Header @model={{@model}} />
+  </page.header>
+
+  <page.navigation>
+    <CredentialStores::CredentialStore::Nav @model={{@model}} />
+  </page.navigation>
+
+  <page.actions>
+    <CredentialStores::CredentialStore::Actions @model={{@model}} />
+  </page.actions>
+
+  <page.body>
    <Form::CredentialStore
      @model={{@model}}
      @submit={{route-action 'save' @model}}
      @cancel={{route-action 'cancel' @model}}
    />
+  </page.body>
+</Rose::Layout::Page>