From f14346d3a47fb9ca07e72af74d287dccfabe75fe Mon Sep 17 00:00:00 2001
From: Carlos Alcaide <me@calcaide.com>
Date: Fri, 4 Jun 2021 13:38:24 -0700
Subject: [PATCH] Add uni test for dialog detail and fix lint errors

---
 .../app/components/dialog-detail/index.hbs    | 20 ++++++++--------
 .../scopes/scope/projects/targets.hbs         | 10 +++++---
 .../components/dialog-detail-test.js          | 24 +++++++++++--------
 3 files changed, 31 insertions(+), 23 deletions(-)

diff --git a/ui/desktop/app/components/dialog-detail/index.hbs b/ui/desktop/app/components/dialog-detail/index.hbs
index df3ca1b50..a37cc4273 100644
--- a/ui/desktop/app/components/dialog-detail/index.hbs
+++ b/ui/desktop/app/components/dialog-detail/index.hbs
@@ -8,14 +8,16 @@
   @modal={{true}}
   as |dialog|
 >
-  {{yield (hash
-    notification=(component 'rose/notification' class='connection-dialog-notification')
-  )}}
+  {{yield
+    (hash
+      notification=(component
+        'rose/notification' class='connection-dialog-notification'
+      )
+    )
+  }}
 
   <dialog.body>
-    {{yield (hash
-      body=(component 'rose/anonymous')
-    )}}
+    {{yield (hash body=(component 'rose/anonymous'))}}
     {{!--
     <Rose::Separator />
     <h3>Credentials</h3>
@@ -108,10 +110,8 @@
         <div>Code</div>
       </div>
     </div>--}}
-  </dialog.body> 
+  </dialog.body>
   <dialog.footer>
-    {{yield (hash
-      footer=(component 'rose/anonymous')
-    )}}
+    {{yield (hash footer=(component 'rose/anonymous'))}}
   </dialog.footer>
 </Rose::Dialog>
\ No newline at end of file
diff --git a/ui/desktop/app/templates/scopes/scope/projects/targets.hbs b/ui/desktop/app/templates/scopes/scope/projects/targets.hbs
index 43ef98abf..a38ea78ee 100644
--- a/ui/desktop/app/templates/scopes/scope/projects/targets.hbs
+++ b/ui/desktop/app/templates/scopes/scope/projects/targets.hbs
@@ -5,7 +5,11 @@
     {{#if session.started_desktop_client}}
       {{#unless session.acknowledged}}
         <DialogDetail
-          @heading={{concat (t 'resources.target.host-set.detail.title') ': ' session.id}}
+          @heading={{concat
+            (t 'resources.target.host-set.detail.title')
+            ': '
+            session.id
+          }}
           @dismiss={{route-action 'acknowledge' session}}
           @dismissButtonText={{t 'actions.ok'}}
           as |dialogDetail|
@@ -13,7 +17,7 @@
           <dialogDetail.notification
             @style='success'
             @heading={{t 'resources.target.messages.connection-success'}}
-          ></dialogDetail.notification>
+          />
 
           <dialogDetail.body>
             <h3>{{t 'resources.target.host-set.detail.proxy_url'}}</h3>
@@ -45,7 +49,7 @@
               </Rose::Button>
             </div>
             <div>
-            {{! <Rose::LinkButton
+              {{! <Rose::LinkButton
               @route='index'
               @style='inline-link-action'
               @iconRight='chevron-right'
diff --git a/ui/desktop/tests/integration/components/dialog-detail-test.js b/ui/desktop/tests/integration/components/dialog-detail-test.js
index b4c7c7ffc..d3a617ffb 100644
--- a/ui/desktop/tests/integration/components/dialog-detail-test.js
+++ b/ui/desktop/tests/integration/components/dialog-detail-test.js
@@ -1,26 +1,30 @@
 import { module, test } from 'qunit';
 import { setupRenderingTest } from 'ember-qunit';
-import { render } from '@ember/test-helpers';
+import { render, find } from '@ember/test-helpers';
 import { hbs } from 'ember-cli-htmlbars';
 
 module('Integration | Component | dialog-detail', function (hooks) {
   setupRenderingTest(hooks);
 
-  test.skip('it renders', async function (assert) {
-    // Set any properties with this.set('myProperty', 'value');
-    // Handle any actions with this.set('myAction', function(val) { ... });
-
+  test('it renders', async function (assert) {
     await render(hbs`<DialogDetail />`);
+    assert.ok(find('.connection-dialog'));
+  });
 
-    assert.equal(this.element.textContent.trim(), '');
-
-    // Template block usage:
+  test('it renders with content', async function (assert) {
     await render(hbs`
       <DialogDetail>
-        template block text
+        <dialogDetail.notification />
+        <dialogDetail.body>
+          <h2>Test</h2>
+        </dialogDetail.body>
+        <dialogDetail.footer></dialogDetail.footer>
       </DialogDetail>
     `);
 
-    assert.equal(this.element.textContent.trim(), 'template block text');
+    assert.ok(find('.connection-dialog'));
+    assert.ok(find('.rose-dialog-header'));
+    assert.ok(find('.rose-dialog-body'));
+    assert.ok(find('.rose-dialog-footer'));
   });
 });