From f738e716579eed11b3e4d6ec485c6b120e944593 Mon Sep 17 00:00:00 2001 From: hashicc <191911133+hashicc@users.noreply.github.com> Date: Mon, 9 Jun 2025 10:26:02 -0400 Subject: [PATCH] =?UTF-8?q?chore:=20=F0=9F=A4=96=20explicitly=20require=20?= =?UTF-8?q?managing=20pnpm=20"built=20dependencies"=20(#2873)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit pnpm by default refuses to run install scripts, some packages require these and others are use install scripts as a way to provide messages. Instead of a pnpm warning this commit ensures that the package that is detected with an install script must be either listed in ignoredBuiltDependencies or onlyBuiltDependencies. Running pnpm install will fail until a package has been categorized As part of this commit the packages that were previously listed as warnings have been categorized under ignoredBuiltDependencies since their install scripts are not required for the functionality of the package --- package.json | 10 ++++++++-- pnpm-workspace.yaml | 1 + ui/desktop/electron-app/package.json | 1 + ui/desktop/electron-app/pnpm-workspace.yaml | 3 ++- 4 files changed, 12 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index cb0ddd19a..19292d560 100755 --- a/package.json +++ b/package.json @@ -48,7 +48,13 @@ "node-gyp": "^10.0.0", "ansi-html": "^0.0.9", "fireworm>async": "^2.6.4" - } + }, + "ignoredBuiltDependencies": [ + "@parcel/watcher", + "core-js", + "tesseract.js" + ], + "onlyBuiltDependencies": [] }, "config": { "commitizen": { @@ -59,4 +65,4 @@ "node": "20.* || 22.*" }, "packageManager": "pnpm@10.8.1" -} +} \ No newline at end of file diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml index 26baf6ea2..04f73bd28 100644 --- a/pnpm-workspace.yaml +++ b/pnpm-workspace.yaml @@ -1,3 +1,4 @@ +strictDepBuilds: true packages: - addons/* - ui/* diff --git a/ui/desktop/electron-app/package.json b/ui/desktop/electron-app/package.json index 3743a78fa..4d5914a57 100644 --- a/ui/desktop/electron-app/package.json +++ b/ui/desktop/electron-app/package.json @@ -44,6 +44,7 @@ "unzipper": "^0.11.5" }, "pnpm": { + "ignoredBuiltDependencies": [], "onlyBuiltDependencies": [ "electron", "electron-winstaller", diff --git a/ui/desktop/electron-app/pnpm-workspace.yaml b/ui/desktop/electron-app/pnpm-workspace.yaml index 3f29b57b5..ce0bf0906 100644 --- a/ui/desktop/electron-app/pnpm-workspace.yaml +++ b/ui/desktop/electron-app/pnpm-workspace.yaml @@ -1,3 +1,4 @@ +strictDepBuilds: true +nodeLinker: hoisted packages: - . -nodeLinker: hoisted