Chore/cleanup filter attribute (#1500)
* refactor: 💡 Rename attributes called filter * refactor: 💡 Remove adapter handling of old attribute errors * refactor: 💡 Check for undefined in serializer instead of falsy
This commit is contained in:
1 parent
b1f14e5c62
commit
f8429b15e9
11 files changed
+160
-53
No files matched your search
@@ -221,7 +221,7 @@
|
||||
<form.input
|
||||
@type='text'
|
||||
@name='filters'
|
||||
@value={{@model.filter}}
|
||||
@value={{@model.filter_string}}
|
||||
/>
|
||||
</row.cell>
|
||||
<row.cell @shrink={{true}}>
|
||||
@@ -233,7 +233,10 @@
|
||||
false
|
||||
(if form.isEditable false true)
|
||||
}}
|
||||
{{on 'click' (fn @addStringItem 'filters' @model.filter)}}
|
||||
{{on
|
||||
'click'
|
||||
(fn @addStringItem 'filters' @model.filter_string)
|
||||
}}
|
||||
>
|
||||
{{t 'actions.add'}}
|
||||
</Rose::Button>
|
||||
|
||||
@@ -168,18 +168,18 @@
|
||||
<form.textarea
|
||||
@name='filter'
|
||||
@type='filter'
|
||||
@value={{@model.filter}}
|
||||
@value={{@model.filter_string}}
|
||||
@label={{t 'resources.host-set.form.filter.label'}}
|
||||
@helperText={{t 'resources.host-set.form.filter.azure.help'}}
|
||||
@linkText={{t 'actions.learn-more'}}
|
||||
@error={{@model.errors.description}}
|
||||
@error={{@model.errors.filter_string}}
|
||||
disabled={{@model.isSaving}}
|
||||
readonly={{false}}
|
||||
as |field|
|
||||
>
|
||||
{{#if @model.errors.filter}}
|
||||
{{#if @model.errors.filter_string}}
|
||||
<field.errors as |errors|>
|
||||
{{#each @model.errors.filter as |error|}}
|
||||
{{#each @model.errors.filter_string as |error|}}
|
||||
<errors.message>{{error.message}}</errors.message>
|
||||
{{/each}}
|
||||
</field.errors>
|
||||
|
||||
@@ -54,15 +54,15 @@
|
||||
<form.input
|
||||
@name='filter'
|
||||
@type='text'
|
||||
@value={{@model.filter}}
|
||||
@value={{@model.filter_string}}
|
||||
@label={{t 'form.filter.label'}}
|
||||
@error={{@model.errors.attributes_filter}}
|
||||
@error={{@model.errors.filter_string}}
|
||||
@helperText={{t 'form.filter.help'}}
|
||||
as |field|
|
||||
>
|
||||
{{#if @model.errors.attributes_filter}}
|
||||
{{#if @model.errors.filter_string}}
|
||||
<field.errors as |errors|>
|
||||
{{#each @model.errors.attributes_filter as |error|}}
|
||||
{{#each @model.errors.filter_string as |error|}}
|
||||
<errors.message>{{error.message}}</errors.message>
|
||||
{{/each}}
|
||||
</field.errors>
|
||||
|
||||
Reference in new issue
Block a user