From f9411794c433409b25f3f28fc9eb217d34e1e87c Mon Sep 17 00:00:00 2001
From: Michael Li <michael.li@hashicorp.com>
Date: Fri, 14 Feb 2025 11:10:53 -0500
Subject: [PATCH] test(e2e): Remove attempt to delete session recording due to
 UI change (#2687)

This test attempted to delete a session recording when the policy did not allow it. However, there was a UI change to remove that option entirely, so we are removing the check.
---
 .../tests/session-recording-aws-ent.spec.js   | 23 -------------------
 .../tests/session-recording-minio-ent.spec.js | 23 -------------------
 2 files changed, 46 deletions(-)

diff --git a/e2e-tests/admin/tests/session-recording-aws-ent.spec.js b/e2e-tests/admin/tests/session-recording-aws-ent.spec.js
index 0d4113631..741cb678f 100644
--- a/e2e-tests/admin/tests/session-recording-aws-ent.spec.js
+++ b/e2e-tests/admin/tests/session-recording-aws-ent.spec.js
@@ -163,24 +163,6 @@ test(
       await page.locator('div.session-recording-player').hover();
       await page.locator('.ap-playback-button').click();
 
-      // Try to delete session recording: expect failure
-      await page.getByRole('link', { name: 'Orgs', exact: true }).click();
-      await page
-        .getByRole('navigation', { name: 'General' })
-        .getByRole('link', { name: 'Session Recordings', exact: true })
-        .click();
-      await page
-        .getByRole('row', { name: targetName })
-        .getByRole('link', { name: 'View' })
-        .click();
-      await page.getByText('Manage').click();
-      await page.getByRole('button', { name: 'Delete recording' }).click();
-      await page.getByRole('button', { name: 'OK', exact: true }).click();
-      await expect(
-        page.getByRole('alert').getByText('Error', { exact: true }),
-      ).toBeVisible();
-      await page.getByRole('button', { name: 'Dismiss' }).click();
-
       // Edit storage policy: do not protect from deletion
       await page.getByRole('link', { name: 'Orgs', exact: true }).click();
       await expect(page.getByRole('heading', { name: 'Orgs' })).toBeVisible();
@@ -207,11 +189,6 @@ test(
       ).toBeVisible();
       await page.getByRole('button', { name: 'Dismiss' }).click();
 
-      // BUG? After the error trying to delete the session recording, subsequent
-      // actions result in an error. Reloading the page fixes the issue. This is a
-      // temporary workaround.
-      await page.reload();
-
       // Re-apply storage policy to the session recording and delete
       await page.getByRole('link', { name: 'Orgs', exact: true }).click();
       await page
diff --git a/e2e-tests/admin/tests/session-recording-minio-ent.spec.js b/e2e-tests/admin/tests/session-recording-minio-ent.spec.js
index 2eaa88a27..3240720db 100644
--- a/e2e-tests/admin/tests/session-recording-minio-ent.spec.js
+++ b/e2e-tests/admin/tests/session-recording-minio-ent.spec.js
@@ -171,24 +171,6 @@ test(
       await page.locator('div.session-recording-player').hover();
       await page.locator('.ap-playback-button').click();
 
-      // Try to delete session recording: expect failure
-      await page.getByRole('link', { name: 'Orgs', exact: true }).click();
-      await page
-        .getByRole('navigation', { name: 'General' })
-        .getByRole('link', { name: 'Session Recordings', exact: true })
-        .click();
-      await page
-        .getByRole('row', { name: targetName })
-        .getByRole('link', { name: 'View' })
-        .click();
-      await page.getByText('Manage').click();
-      await page.getByRole('button', { name: 'Delete recording' }).click();
-      await page.getByRole('button', { name: 'OK', exact: true }).click();
-      await expect(
-        page.getByRole('alert').getByText('Error', { exact: true }),
-      ).toBeVisible();
-      await page.getByRole('button', { name: 'Dismiss' }).click();
-
       // Edit storage policy: do not protect from deletion
       await page.getByRole('link', { name: 'Orgs', exact: true }).click();
       await expect(page.getByRole('heading', { name: 'Orgs' })).toBeVisible();
@@ -215,11 +197,6 @@ test(
       ).toBeVisible();
       await page.getByRole('button', { name: 'Dismiss' }).click();
 
-      // BUG? After the error trying to delete the session recording, subsequent
-      // actions result in an error. Reloading the page fixes the issue. This is a
-      // temporary workaround.
-      await page.reload();
-
       // Re-apply storage policy to the session recording and delete
       await page.getByRole('link', { name: 'Orgs', exact: true }).click();
       await page