From 6ba9ffc3af49538a166ebd9c0b9565652c4fc899 Mon Sep 17 00:00:00 2001 From: Susmitha Girumala Date: Thu, 11 Nov 2021 17:58:08 -0500 Subject: [PATCH] chore: Managed groups edit integration fix --- addons/api/addon/serializers/managed-group.js | 9 ++++++++- addons/api/app/serializers/managed-group.js | 1 + .../auth-methods/auth-method/managed-groups.js | 15 +++++++++++---- .../managed-groups/managed-group/-actions.hbs | 2 +- .../managed-groups/managed-group/index.hbs | 6 +++++- 5 files changed, 26 insertions(+), 7 deletions(-) create mode 100644 addons/api/app/serializers/managed-group.js diff --git a/addons/api/addon/serializers/managed-group.js b/addons/api/addon/serializers/managed-group.js index cb03236af..f42fc78d2 100644 --- a/addons/api/addon/serializers/managed-group.js +++ b/addons/api/addon/serializers/managed-group.js @@ -1,3 +1,10 @@ import ApplicationSerializer from './application'; -export default class ManagedGroupSerializer extends ApplicationSerializer {} +export default class ManagedGroupSerializer extends ApplicationSerializer { + // =properties + + /** + * @type {boolean} + */ + serializeScopeID = false; +} diff --git a/addons/api/app/serializers/managed-group.js b/addons/api/app/serializers/managed-group.js new file mode 100644 index 000000000..799590738 --- /dev/null +++ b/addons/api/app/serializers/managed-group.js @@ -0,0 +1 @@ +export { default } from 'api/serializers/managed-group'; diff --git a/ui/admin/app/routes/scopes/scope/auth-methods/auth-method/managed-groups.js b/ui/admin/app/routes/scopes/scope/auth-methods/auth-method/managed-groups.js index 737dc4728..770d1357e 100644 --- a/ui/admin/app/routes/scopes/scope/auth-methods/auth-method/managed-groups.js +++ b/ui/admin/app/routes/scopes/scope/auth-methods/auth-method/managed-groups.js @@ -56,9 +56,16 @@ export default class ScopesScopeAuthMethodsAuthMethodManagedGroupsRoute extends ) async save(managedGroup) { await managedGroup.save(); - await this.transitionTo( - 'scopes.scope.auth-methods.auth-method.managed-groups' - ); + if (this.can.can('read model', managedGroup)) { + await this.transitionTo( + 'scopes.scope.auth-methods.auth-method.managed-groups.managed-group', + managedGroup + ); + } else { + await this.transitionTo( + 'scopes.scope.auth-methods.auth-method.managed-groups' + ); + } this.refresh(); } @@ -71,7 +78,7 @@ export default class ScopesScopeAuthMethodsAuthMethodManagedGroupsRoute extends @confirm('questions.delete-confirm') @notifyError(({ message }) => message, { catch: true }) @notifySuccess('notifications.delete-success') - async deleteManagedGroup(managedGroup) { + async delete(managedGroup) { await managedGroup.destroyRecord(); await this.replaceWith( 'scopes.scope.auth-methods.auth-method.managed-groups' diff --git a/ui/admin/app/templates/scopes/scope/auth-methods/auth-method/managed-groups/managed-group/-actions.hbs b/ui/admin/app/templates/scopes/scope/auth-methods/auth-method/managed-groups/managed-group/-actions.hbs index 98a51d476..3340d97f2 100644 --- a/ui/admin/app/templates/scopes/scope/auth-methods/auth-method/managed-groups/managed-group/-actions.hbs +++ b/ui/admin/app/templates/scopes/scope/auth-methods/auth-method/managed-groups/managed-group/-actions.hbs @@ -7,7 +7,7 @@ {{t 'resources.managed-group.actions.delete'}} diff --git a/ui/admin/app/templates/scopes/scope/auth-methods/auth-method/managed-groups/managed-group/index.hbs b/ui/admin/app/templates/scopes/scope/auth-methods/auth-method/managed-groups/managed-group/index.hbs index 19ab29fcb..bcaa893ac 100644 --- a/ui/admin/app/templates/scopes/scope/auth-methods/auth-method/managed-groups/managed-group/index.hbs +++ b/ui/admin/app/templates/scopes/scope/auth-methods/auth-method/managed-groups/managed-group/index.hbs @@ -1 +1,5 @@ - \ No newline at end of file + \ No newline at end of file