Lisbet Alvarez
3ba93927fe
* empty commit
* Add missing copyright headers
* chore: 🤖 update copywrite config file with correct year
* Add missing copyright headers
* empty commit (gh action merge checks are stuck)
471 lines
14 KiB
JavaScript
471 lines
14 KiB
JavaScript
/**
|
|
* Copyright IBM Corp. 2021, 2026
|
|
* SPDX-License-Identifier: BUSL-1.1
|
|
*/
|
|
|
|
import { module, test } from 'qunit';
|
|
import { click, currentURL, fillIn, visit } from '@ember/test-helpers';
|
|
import { setupApplicationTest } from 'admin/tests/helpers';
|
|
import { setupSqlite } from 'api/test-support/helpers/sqlite';
|
|
import { setupIntl } from 'ember-intl/test-support';
|
|
import { Response } from 'miragejs';
|
|
import * as commonSelectors from 'admin/tests/helpers/selectors';
|
|
import * as selectors from './selectors';
|
|
import { setRunOptions } from 'ember-a11y-testing/test-support';
|
|
import { TYPE_TARGET_RDP, TYPE_TARGET_SSH } from 'api/models/target';
|
|
|
|
module('Acceptance | targets | update', function (hooks) {
|
|
setupApplicationTest(hooks);
|
|
setupSqlite(hooks);
|
|
setupIntl(hooks, 'en-us');
|
|
|
|
let featuresService;
|
|
|
|
const instances = {
|
|
scopes: {
|
|
org: null,
|
|
project: null,
|
|
},
|
|
target: null,
|
|
rdpTarget: null,
|
|
sshTarget: null,
|
|
};
|
|
const urls = {
|
|
projectScope: null,
|
|
targets: null,
|
|
target: null,
|
|
rdpTarget: null,
|
|
sshTarget: null,
|
|
};
|
|
|
|
hooks.beforeEach(async function () {
|
|
featuresService = this.owner.lookup('service:features');
|
|
// Generate resources
|
|
instances.scopes.org = this.server.create('scope', {
|
|
type: 'org',
|
|
scope: { id: 'global', type: 'global' },
|
|
});
|
|
instances.scopes.project = this.server.create('scope', {
|
|
type: 'project',
|
|
scope: { id: instances.scopes.org.id, type: 'org' },
|
|
});
|
|
instances.target = this.server.create('target', {
|
|
scope: instances.scopes.project,
|
|
});
|
|
instances.rdpTarget = this.server.create('target', {
|
|
type: TYPE_TARGET_RDP,
|
|
scope: instances.scopes.project,
|
|
injected_application_credential_source_ids: [],
|
|
});
|
|
instances.sshTarget = this.server.create('target', {
|
|
type: TYPE_TARGET_SSH,
|
|
scope: instances.scopes.project,
|
|
injected_application_credential_source_ids: [],
|
|
});
|
|
// Generate route URLs for resources
|
|
urls.projectScope = `/scopes/${instances.scopes.project.id}`;
|
|
urls.targets = `${urls.projectScope}/targets`;
|
|
urls.target = `${urls.targets}/${instances.target.id}`;
|
|
urls.rdpTarget = `${urls.targets}/${instances.rdpTarget.id}`;
|
|
urls.sshTarget = `${urls.targets}/${instances.sshTarget.id}`;
|
|
});
|
|
|
|
test('can save changes to existing target', async function (assert) {
|
|
setRunOptions({
|
|
rules: {
|
|
'color-contrast': {
|
|
// [ember-a11y-ignore]: axe rule "color-contrast" automatically ignored on 2025-08-01
|
|
enabled: false,
|
|
},
|
|
},
|
|
});
|
|
|
|
await visit(urls.targets);
|
|
assert.notEqual(instances.target.name, 'random string');
|
|
assert.notEqual(instances.target.worker_filter, 'random filter');
|
|
|
|
await click(commonSelectors.HREF(urls.target));
|
|
await click(commonSelectors.EDIT_BTN, 'Activate edit mode');
|
|
await fillIn(commonSelectors.FIELD_NAME, commonSelectors.FIELD_NAME_VALUE);
|
|
await click(commonSelectors.SAVE_BTN);
|
|
|
|
assert.strictEqual(currentURL(), urls.target);
|
|
assert.strictEqual(
|
|
this.server.schema.targets.first().name,
|
|
commonSelectors.FIELD_NAME_VALUE,
|
|
);
|
|
});
|
|
|
|
test('can cancel changes to existing target', async function (assert) {
|
|
setRunOptions({
|
|
rules: {
|
|
'color-contrast': {
|
|
// [ember-a11y-ignore]: axe rule "color-contrast" automatically ignored on 2025-08-01
|
|
enabled: false,
|
|
},
|
|
},
|
|
});
|
|
|
|
await visit(urls.targets);
|
|
|
|
await click(commonSelectors.HREF(urls.target));
|
|
await click(commonSelectors.EDIT_BTN, 'Activate edit mode');
|
|
await fillIn(commonSelectors.FIELD_NAME, commonSelectors.FIELD_NAME_VALUE);
|
|
await click(commonSelectors.CANCEL_BTN);
|
|
|
|
assert.notEqual(instances.target.name, commonSelectors.FIELD_NAME_VALUE);
|
|
assert.dom(commonSelectors.FIELD_NAME).hasValue(instances.target.name);
|
|
});
|
|
|
|
test('saving an existing target with invalid fields displays error messages', async function (assert) {
|
|
setRunOptions({
|
|
rules: {
|
|
'color-contrast': {
|
|
// [ember-a11y-ignore]: axe rule "color-contrast" automatically ignored on 2025-08-01
|
|
enabled: false,
|
|
},
|
|
},
|
|
});
|
|
|
|
await visit(urls.targets);
|
|
this.server.patch('/targets/:id', () => {
|
|
return new Response(
|
|
400,
|
|
{},
|
|
{
|
|
status: 400,
|
|
code: 'invalid_argument',
|
|
message: 'The request was invalid.',
|
|
details: {
|
|
request_fields: [
|
|
{
|
|
name: 'name',
|
|
description: 'Name is required.',
|
|
},
|
|
],
|
|
},
|
|
},
|
|
);
|
|
});
|
|
await visit(urls.targets);
|
|
|
|
await click(commonSelectors.HREF(urls.target));
|
|
await click(commonSelectors.EDIT_BTN, 'Activate edit mode');
|
|
await fillIn(commonSelectors.FIELD_NAME, commonSelectors.FIELD_NAME_VALUE);
|
|
await click(commonSelectors.SAVE_BTN);
|
|
|
|
assert
|
|
.dom(commonSelectors.ALERT_TOAST_BODY)
|
|
.hasText('The request was invalid.');
|
|
assert.dom(selectors.FIELD_NAME_ERROR).hasText('Name is required.');
|
|
});
|
|
|
|
test('can discard unsaved target changes via dialog', async function (assert) {
|
|
setRunOptions({
|
|
rules: {
|
|
'color-contrast': {
|
|
// [ember-a11y-ignore]: axe rule "color-contrast" automatically ignored on 2025-08-01
|
|
enabled: false,
|
|
},
|
|
},
|
|
});
|
|
|
|
const confirmService = this.owner.lookup('service:confirm');
|
|
confirmService.enabled = true;
|
|
assert.notEqual(instances.target.name, commonSelectors.FIELD_NAME_VALUE);
|
|
await visit(urls.targets);
|
|
|
|
await click(commonSelectors.HREF(urls.target));
|
|
await click(commonSelectors.EDIT_BTN, 'Activate edit mode');
|
|
await fillIn(commonSelectors.FIELD_NAME, commonSelectors.FIELD_NAME_VALUE);
|
|
|
|
assert.strictEqual(currentURL(), urls.target);
|
|
|
|
await click(commonSelectors.HREF(urls.targets));
|
|
|
|
assert.dom(commonSelectors.MODAL_WARNING).isVisible();
|
|
|
|
await click(commonSelectors.MODAL_WARNING_CONFIRM_BTN);
|
|
|
|
assert.strictEqual(currentURL(), urls.targets);
|
|
assert.notEqual(
|
|
this.server.schema.targets.first().name,
|
|
commonSelectors.FIELD_NAME_VALUE,
|
|
);
|
|
});
|
|
|
|
test('can click cancel on discard dialog box for unsaved target changes', async function (assert) {
|
|
setRunOptions({
|
|
rules: {
|
|
'color-contrast': {
|
|
// [ember-a11y-ignore]: axe rule "color-contrast" automatically ignored on 2025-08-01
|
|
enabled: false,
|
|
},
|
|
},
|
|
});
|
|
|
|
const confirmService = this.owner.lookup('service:confirm');
|
|
confirmService.enabled = true;
|
|
assert.notEqual(instances.target.name, commonSelectors.FIELD_NAME_VALUE);
|
|
await visit(urls.targets);
|
|
|
|
await click(commonSelectors.HREF(urls.target));
|
|
await click(commonSelectors.EDIT_BTN, 'Activate edit mode');
|
|
await fillIn(commonSelectors.FIELD_NAME, commonSelectors.FIELD_NAME_VALUE);
|
|
|
|
assert.strictEqual(currentURL(), urls.target);
|
|
|
|
await click(commonSelectors.HREF(urls.targets));
|
|
|
|
assert.dom(commonSelectors.MODAL_WARNING).isVisible();
|
|
|
|
await click(commonSelectors.MODAL_WARNING_CANCEL_BTN);
|
|
|
|
assert.strictEqual(currentURL(), urls.target);
|
|
assert.notEqual(
|
|
this.server.schema.targets.first().name,
|
|
commonSelectors.FIELD_NAME_VALUE,
|
|
);
|
|
});
|
|
|
|
test('cannot make changes to an existing target without proper authorization', async function (assert) {
|
|
setRunOptions({
|
|
rules: {
|
|
'color-contrast': {
|
|
// [ember-a11y-ignore]: axe rule "color-contrast" automatically ignored on 2025-08-01
|
|
enabled: false,
|
|
},
|
|
},
|
|
});
|
|
|
|
await visit(urls.targets);
|
|
instances.target.authorized_actions =
|
|
instances.target.authorized_actions.filter((item) => item !== 'update');
|
|
|
|
await click(commonSelectors.HREF(urls.target));
|
|
|
|
assert.dom(commonSelectors.EDIT_BTN).doesNotExist();
|
|
});
|
|
|
|
test('saving address with existing host sources brings up confirmation modal and removes host sources', async function (assert) {
|
|
setRunOptions({
|
|
rules: {
|
|
'color-contrast': {
|
|
// [ember-a11y-ignore]: axe rule "color-contrast" automatically ignored on 2025-08-01
|
|
enabled: false,
|
|
},
|
|
},
|
|
});
|
|
|
|
featuresService.enable('ssh-target');
|
|
featuresService.enable('target-network-address');
|
|
const confirmService = this.owner.lookup('service:confirm');
|
|
confirmService.enabled = true;
|
|
this.server.createList(
|
|
'host-catalog',
|
|
8,
|
|
{ scope: instances.scopes.project },
|
|
'withChildren',
|
|
);
|
|
this.server.createList(
|
|
'credential-store',
|
|
3,
|
|
{ scope: instances.scopes.project },
|
|
'withAssociations',
|
|
);
|
|
const target = this.server.create(
|
|
'target',
|
|
{ scope: instances.scopes.project },
|
|
'withAssociations',
|
|
);
|
|
assert.true(this.server.schema.targets.find(target.id).hostSets.length > 0);
|
|
|
|
const url = `${urls.targets}/${target.id}`;
|
|
await visit(urls.targets);
|
|
|
|
await click(commonSelectors.HREF(url));
|
|
|
|
await click(commonSelectors.EDIT_BTN, 'Activate edit mode');
|
|
await fillIn(selectors.FIELD_ADDRESS, selectors.FIELD_ADDRESS_VALUE);
|
|
await click(commonSelectors.SAVE_BTN);
|
|
|
|
assert.dom(commonSelectors.MODAL_WARNING).isVisible();
|
|
|
|
await click(commonSelectors.MODAL_WARNING_CONFIRM_BTN);
|
|
|
|
assert.strictEqual(
|
|
this.server.schema.targets.find(target.id).address,
|
|
selectors.FIELD_ADDRESS_VALUE,
|
|
);
|
|
assert.strictEqual(
|
|
this.server.schema.targets.find(target.id).hostSets.length,
|
|
0,
|
|
);
|
|
});
|
|
|
|
test('saving address with existing host sources brings up confirmation modal and can cancel', async function (assert) {
|
|
setRunOptions({
|
|
rules: {
|
|
'color-contrast': {
|
|
// [ember-a11y-ignore]: axe rule "color-contrast" automatically ignored on 2025-08-01
|
|
enabled: false,
|
|
},
|
|
},
|
|
});
|
|
|
|
featuresService.enable('ssh-target');
|
|
featuresService.enable('target-network-address');
|
|
const confirmService = this.owner.lookup('service:confirm');
|
|
confirmService.enabled = true;
|
|
this.server.createList(
|
|
'host-catalog',
|
|
8,
|
|
{ scope: instances.scopes.project },
|
|
'withChildren',
|
|
);
|
|
this.server.createList(
|
|
'credential-store',
|
|
3,
|
|
{ scope: instances.scopes.project },
|
|
'withAssociations',
|
|
);
|
|
const target = this.server.create(
|
|
'target',
|
|
{ scope: instances.scopes.project },
|
|
'withAssociations',
|
|
);
|
|
assert.true(this.server.schema.targets.find(target.id).hostSets.length > 0);
|
|
|
|
const url = `${urls.targets}/${target.id}`;
|
|
await visit(urls.targets);
|
|
|
|
await click(commonSelectors.HREF(url));
|
|
await click(commonSelectors.EDIT_BTN, 'Activate edit mode');
|
|
await fillIn(selectors.FIELD_ADDRESS, selectors.FIELD_ADDRESS_VALUE);
|
|
await click(commonSelectors.SAVE_BTN);
|
|
|
|
assert.dom(commonSelectors.MODAL_WARNING).isVisible();
|
|
|
|
await click(commonSelectors.MODAL_WARNING_CANCEL_BTN);
|
|
|
|
assert.strictEqual(
|
|
this.server.schema.targets.find(target.id).address,
|
|
undefined,
|
|
);
|
|
assert.true(this.server.schema.targets.find(target.id).hostSets.length > 0);
|
|
});
|
|
|
|
test('can save changes to existing rdp target', async function (assert) {
|
|
setRunOptions({
|
|
rules: {
|
|
'color-contrast': {
|
|
// [ember-a11y-ignore]: axe rule "color-contrast" automatically ignored on 2025-08-26
|
|
enabled: false,
|
|
},
|
|
},
|
|
});
|
|
|
|
featuresService.enable('rdp-target');
|
|
featuresService.enable('ssh-target');
|
|
|
|
await visit(urls.targets);
|
|
|
|
await click(commonSelectors.HREF(urls.rdpTarget));
|
|
|
|
assert
|
|
.dom(selectors.ALERT_INJECTED_APPLICATION_CREDENTIAL)
|
|
.exists('Injected application credential alert is displayed');
|
|
assert
|
|
.dom(selectors.ALERT_INJECTED_APPLICATION_CREDENTIAL_ADD_BTN)
|
|
.hasAttribute(
|
|
'href',
|
|
`${urls.rdpTarget}/add-injected-application-credential-sources`,
|
|
);
|
|
|
|
await click(commonSelectors.EDIT_BTN, 'Activate edit mode');
|
|
await fillIn(commonSelectors.FIELD_NAME, commonSelectors.FIELD_NAME_VALUE);
|
|
await click(commonSelectors.SAVE_BTN);
|
|
|
|
assert.strictEqual(currentURL(), urls.rdpTarget);
|
|
assert.strictEqual(
|
|
this.server.schema.targets.where({ type: TYPE_TARGET_RDP }).models[0]
|
|
.name,
|
|
commonSelectors.FIELD_NAME_VALUE,
|
|
);
|
|
});
|
|
|
|
test('displays add injected credentials alert for ssh target', async function (assert) {
|
|
setRunOptions({
|
|
rules: {
|
|
'color-contrast': {
|
|
// [ember-a11y-ignore]: axe rule "color-contrast" automatically ignored on 2025-08-26
|
|
enabled: false,
|
|
},
|
|
},
|
|
});
|
|
|
|
featuresService.enable('ssh-target');
|
|
|
|
await visit(urls.targets);
|
|
|
|
await click(commonSelectors.HREF(urls.sshTarget));
|
|
|
|
assert
|
|
.dom(selectors.ALERT_INJECTED_APPLICATION_CREDENTIAL)
|
|
.exists('Injected application credential alert is displayed');
|
|
|
|
await click(selectors.ALERT_INJECTED_APPLICATION_CREDENTIAL_ADD_BTN);
|
|
|
|
assert.strictEqual(
|
|
currentURL(),
|
|
`${urls.sshTarget}/add-injected-application-credential-sources`,
|
|
);
|
|
});
|
|
|
|
test('it shows additional helper text in field labels for rdp targets', async function (assert) {
|
|
setRunOptions({
|
|
rules: {
|
|
'color-contrast': {
|
|
enabled: false,
|
|
},
|
|
},
|
|
});
|
|
|
|
featuresService.enable('rdp-target');
|
|
|
|
const staticDefaultClientPortHelperText =
|
|
'The local proxy port on which to listen by default when a session is started on a client.';
|
|
const staticMaxConnectionsHelperText =
|
|
'The maximum number of connections allowed per session. For unlimited, specify "-1".';
|
|
|
|
setRunOptions({
|
|
rules: {
|
|
'color-contrast': {
|
|
enabled: false,
|
|
},
|
|
},
|
|
});
|
|
|
|
await visit(urls.target);
|
|
|
|
assert
|
|
.dom(selectors.FIELD_DEFAULT_CLIENT_PORT_HELPER_TEXT)
|
|
.hasText(staticDefaultClientPortHelperText);
|
|
assert
|
|
.dom(selectors.FIELD_MAX_CONNECTIONS_HELPER_TEXT)
|
|
.hasText(staticMaxConnectionsHelperText);
|
|
|
|
await visit(urls.rdpTarget);
|
|
assert
|
|
.dom(selectors.FIELD_DEFAULT_CLIENT_PORT_HELPER_TEXT)
|
|
.hasText(
|
|
`${staticDefaultClientPortHelperText} Note: Windows OS prevents port 3389 from being used.`,
|
|
);
|
|
assert
|
|
.dom(selectors.FIELD_MAX_CONNECTIONS_HELPER_TEXT)
|
|
.hasText(
|
|
`${staticMaxConnectionsHelperText} Note: The Windows Remote Desktop Connection client requires a connection limit of 2 or higher`,
|
|
);
|
|
});
|
|
});
|