(fix) added more context to error details for cli command (#2170)

* (test) added more context to error details for cli commands

* (fix) refactor solution to utilize custom error type casting

* (test) added api unit test to validate InvalidArgumentError return message

* Update internal/types/subtypes/error.go

Co-authored-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>

* (refactor) rename InvalidArgumentError into UnknownSubtypeIDError

Co-authored-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>

internal/tests/api/accounts/account_test.go

@@ -398,5 +398,14 @@ func TestErrorsOidc(t *testing.T) {
 		accounts.WithPasswordAccountLoginName("foo"),
 	)
 	require.Error(err)
-	require.JSONEq(err.Error(), `{"kind":"InvalidArgument", "message":"Error in provided request.", "details":{"request_fields":[{"name":"attributes", "description":"Attribute fields do not match the expected format."}]}}`)
+	require.JSONEq(err.Error(), `{
+		"details": {
+			"request_fields": [{
+				"description": "Attribute fields do not match the expected format.",
+				"name": "attributes"
+			}]
+		},
+		"kind": "InvalidArgument",
+		"message": "Error in provided request."
+	}`)
 }

internal/tests/api/authmethods/authmethod_test.go

@@ -362,4 +362,20 @@ func TestErrors(t *testing.T) {
 	apiErr = api.AsServerError(err)
 	require.NotNil(apiErr)
 	assert.EqualValues(http.StatusBadRequest, apiErr.Response().StatusCode())
+
+	// Passing in a invalid authentication method sub-type should return an  error
+	_, err = amClient.Authenticate(tc.Context(), "ampwd_1234567890", "login", map[string]interface{}{
+		"login_name": "admin",
+		"password":   "password",
+	})
+	require.Error(err)
+	apiErr = api.AsServerError(err)
+	require.NotNil(apiErr)
+	assert.Len(apiErr.Details.RequestFields, 1)
+	assert.EqualValues(apiErr.Details.RequestFields, []*api.FieldError{
+		{
+			Name:        "attributes",
+			Description: "unknown subtype in ID: ampwd_1234567890",
+		},
+	})
 }