Linter fixes PR 3 (#4415)

* Linter fixes

* fix(bsr): update test to register TEST protocol once

---------

Co-authored-by: Damian Debkowski <damian.debkowski@hashicorp.com>

internal/clientcache/cmd/daemon/logfile_test.go

@@ -98,8 +98,9 @@ func TestRotation(t *testing.T) {
 	// write 1 mb and see it all contained in a single log file
 	toWrite := make([]byte, 1024)
 	for i := 0; i < 1024; i++ {
-		rand.Read(toWrite)
-		_, err := l.Write(toWrite)
+		_, err := rand.Read(toWrite)
+		require.NoError(t, err)
+		_, err = l.Write(toWrite)
 		require.NoError(t, err)
 	}
 	ret, err := os.ReadDir(dir)
@@ -121,8 +122,9 @@ func TestRotation(t *testing.T) {
 
 	// write another 1 mb and see a third log file is created
 	for i := 0; i < 1024; i++ {
-		rand.Read(toWrite)
-		_, err := l.Write(toWrite)
+		_, err := rand.Read(toWrite)
+		require.NoError(t, err)
+		_, err = l.Write(toWrite)
 		require.NoError(t, err)
 	}
 	ret, err = os.ReadDir(dir)
@@ -131,8 +133,9 @@ func TestRotation(t *testing.T) {
 
 	// and a 4th (3 backups plus the cache.log file)
 	for i := 0; i < 1024; i++ {
-		rand.Read(toWrite)
-		_, err := l.Write(toWrite)
+		_, err := rand.Read(toWrite)
+		require.NoError(t, err)
+		_, err = l.Write(toWrite)
 		require.NoError(t, err)
 	}
 

internal/clientcache/cmd/daemon/pidfile_nonwindows.go

@@ -45,7 +45,7 @@ func writePidFile(ctx context.Context, pidFile string) (pidCleanup, error) {
 	if err := l.Lock(); err != nil {
 		return closeAndDeleteFileFn, errors.Wrap(ctx, err, op)
 	}
-	// Now that we have aquired the lock and verified we own the pid file
+	// Now that we have acquired the lock and verified we own the pid file
 	// we can remove it always when cleaning up.
 	unlockAndCleanFn := func() error {
 		return l.Remove()