From 3b83184700131cfe4d9fe16bcf523aae0a373a6d Mon Sep 17 00:00:00 2001 From: Jeff Mitchell Date: Thu, 18 Nov 2021 09:32:32 -0500 Subject: [PATCH] Add missing read only check on secrets hmac field in handler (#1729) --- .../handlers/host_catalogs/host_catalog_service.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/internal/servers/controller/handlers/host_catalogs/host_catalog_service.go b/internal/servers/controller/handlers/host_catalogs/host_catalog_service.go index 16f6e2a61..4c3140a72 100644 --- a/internal/servers/controller/handlers/host_catalogs/host_catalog_service.go +++ b/internal/servers/controller/handlers/host_catalogs/host_catalog_service.go @@ -819,6 +819,9 @@ func validateCreateRequest(req *pbs.CreateHostCatalogRequest) error { if !handlers.ValidId(handlers.Id(req.GetItem().GetScopeId()), scope.Project.Prefix()) { badFields[globals.ScopeIdField] = "This field must be a valid project scope id." } + if req.GetItem().GetSecretsHmac() != "" { + badFields[globals.SecretsHmacField] = "This is a read only field." + } switch host.SubtypeFromType(req.GetItem().GetType()) { case static.Subtype: case plugin.Subtype: @@ -843,6 +846,9 @@ func validateCreateRequest(req *pbs.CreateHostCatalogRequest) error { func validateUpdateRequest(req *pbs.UpdateHostCatalogRequest) error { return handlers.ValidateUpdateRequest(req, req.GetItem(), func() map[string]string { badFields := map[string]string{} + if req.GetItem().GetSecretsHmac() != "" { + badFields[globals.SecretsHmacField] = "This is a read only field." + } switch host.SubtypeFromId(req.GetId()) { case static.Subtype: if req.GetItem().GetType() != "" && host.SubtypeFromType(req.GetItem().GetType()) != static.Subtype {