From 546550fa4f3b31a4d9daa5290b8217890f241863 Mon Sep 17 00:00:00 2001 From: Hugo <10965479+hugoghx@users.noreply.github.com> Date: Mon, 27 Oct 2025 16:55:04 +0000 Subject: [PATCH] docs(credential/vault): Clarify LdapCredentialLibrary issuing cred type --- internal/credential/vault/ldap_credential_library.go | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/internal/credential/vault/ldap_credential_library.go b/internal/credential/vault/ldap_credential_library.go index 03de8b99e..3e2251b3d 100644 --- a/internal/credential/vault/ldap_credential_library.go +++ b/internal/credential/vault/ldap_credential_library.go @@ -15,16 +15,18 @@ import ( var _ credential.Library = (*LdapCredentialLibrary)(nil) -// LdapCredentialLibrary is a credential library that issues -// ldap credentials using the vault ldap secret engine. +// LdapCredentialLibrary is a credential library that issues ldap credentials +// using the vault ldap secret engine. This credential library always issues +// username/password/domain credentials. type LdapCredentialLibrary struct { *store.LdapCredentialLibrary tableName string `gorm:"-"` } -// NewLdapCredentialLibrary creates a new in memory LdapCredentialLibrary -// for a Vault backend at vaultPath assigned to storeId. -// Name and description are the only valid options. All other options are ignored. +// NewLdapCredentialLibrary creates a new in memory LdapCredentialLibrary for a +// Vault backend at vaultPath assigned to storeId. This credential library +// always issues username/password/domain credentials. WithName and +// WithDescription are the only valid options. All other options are ignored. func NewLdapCredentialLibrary(storeId string, vaultPath string, opt ...Option) (*LdapCredentialLibrary, error) { const op = "vault.NewLdapCredentialLibrary" opts := getOpts(opt...)