From 58cc322c638892ce655c34316f124cffd4fd6a60 Mon Sep 17 00:00:00 2001
From: Bharath Gajjala <120367134+bgajjala8@users.noreply.github.com>
Date: Tue, 3 Dec 2024 05:47:51 -0800
Subject: [PATCH] Refactor redundant append operations in test setup (#5211)

* Refactor redundant append operations in test setup

- Simplified code by removing unnecessary if-else conditions in the wantUserIds and wantGroupIds blocks.

Fixes #5205

* chore: fmt fix
---
 internal/iam/repository_principal_role_test.go | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/internal/iam/repository_principal_role_test.go b/internal/iam/repository_principal_role_test.go
index cd0f0e2cf..f2c24563a 100644
--- a/internal/iam/repository_principal_role_test.go
+++ b/internal/iam/repository_principal_role_test.go
@@ -141,20 +141,12 @@ func TestRepository_AddPrincipalRoles(t *testing.T) {
 				if tt.args.wantUserIds {
 					userIds = createUsersFn(orgs)
 					u := TestUser(t, repo, staticOrg.PublicId)
-					if roleId == orgRole.PublicId {
-						userIds = append(userIds, u.PublicId)
-					} else {
-						userIds = append(userIds, u.PublicId)
-					}
+					userIds = append(userIds, u.PublicId)
 				}
 				if tt.args.wantGroupIds {
 					groupIds = createGrpsFn(orgs, projects)
 					g := TestGroup(t, conn, staticProj.PublicId)
-					if roleId == projRole.PublicId {
-						groupIds = append(groupIds, g.PublicId)
-					} else {
-						groupIds = append(groupIds, g.PublicId)
-					}
+					groupIds = append(groupIds, g.PublicId)
 				}
 				if len(tt.args.specificUserIds) > 0 {
 					userIds = tt.args.specificUserIds