Refactor names to avoid stutter (#1)
Since client code uses the package name as a prefix when referring to the package contents, the names for those contents need not repeat the package name. - Rename base.BaseCommand to base.Command - Rename base.BaseServer to base.Server - Rename config.DevConfig() to config.Dev() - Rename config.LoadConfigFile() to config.LoadFile() - Rename config.NewConfig() to config.New() - Rename config.ParseConfig() to config.Parse() - Rename controller.ControllerCommand to controller.Command - Rename controller.NewController() to controller.New() - Rename dev.DevCommand to dev.Command - Rename listener.ListenerFactory to listener.Factory - Rename listener.NewListener() to listener.New() - Rename version.GetVersion() to version.Get() - Rename version.VersionInfo to version.Info See: - https://golang.org/doc/effective_go.html#package-names - https://blog.golang.org/package-names#TOC_3. - https://github.com/golang/go/wiki/CodeReviewComments#package-names
This commit is contained in:
1 parent
39c629631f
commit
5e5a56cac0
14 files changed
+91
-91
No files matched your search
@@ -27,7 +27,7 @@ const (
|
||||
// a string.
|
||||
var reRemoveWhitespace = regexp.MustCompile(`[\s]+`)
|
||||
|
||||
type BaseCommand struct {
|
||||
type Command struct {
|
||||
UI cli.Ui
|
||||
Address string
|
||||
Context context.Context
|
||||
@@ -47,7 +47,7 @@ type BaseCommand struct {
|
||||
flagOutputCurlString bool
|
||||
}
|
||||
|
||||
func (c *BaseCommand) SetAddress(addr string) {
|
||||
func (c *Command) SetAddress(addr string) {
|
||||
c.Address = addr
|
||||
}
|
||||
|
||||
@@ -62,7 +62,7 @@ const (
|
||||
|
||||
// FlagSet creates the flags for this command. The result is cached on the
|
||||
// command to save performance on future calls.
|
||||
func (c *BaseCommand) FlagSet(bit FlagSetBit) *FlagSets {
|
||||
func (c *Command) FlagSet(bit FlagSetBit) *FlagSets {
|
||||
c.flagsOnce.Do(func() {
|
||||
set := NewFlagSets(c.UI)
|
||||
|
||||
|
||||
Reference in new issue
Block a user