Don't return an empty resource if there was an apiErr (#294)

This commit is contained in:
Jeff Mitchell authored and GitHub committed 2020-08-20 17:31:38 -04:00
1 parent b24fc185a7
commit 627a353ccb
11 files changed
+198 -66

No files matched your search

+15 -5
View File
@@ -58,7 +58,9 @@ func (c *AccountsClient) Create(ctx context.Context, authMethodId string, opt ..
if err != nil {
return nil, nil, fmt.Errorf("error decoding Create response: %w", err)
}
if apiErr != nil {
return nil, apiErr, nil
}
return target, apiErr, nil
}
@@ -92,7 +94,9 @@ func (c *AccountsClient) Read(ctx context.Context, authMethodId string, accountI
if err != nil {
return nil, nil, fmt.Errorf("error decoding Read response: %w", err)
}
if apiErr != nil {
return nil, apiErr, nil
}
return target, apiErr, nil
}
@@ -143,7 +147,9 @@ func (c *AccountsClient) Update(ctx context.Context, authMethodId string, accoun
if err != nil {
return nil, nil, fmt.Errorf("error decoding Update response: %w", err)
}
if apiErr != nil {
return nil, apiErr, nil
}
return target, apiErr, nil
}
@@ -180,7 +186,9 @@ func (c *AccountsClient) Delete(ctx context.Context, authMethodId string, accoun
if err != nil {
return false, nil, fmt.Errorf("error decoding Delete response: %w", err)
}
if apiErr != nil {
return false, apiErr, nil
}
return target.Existed, apiErr, nil
}
@@ -213,6 +221,8 @@ func (c *AccountsClient) List(ctx context.Context, authMethodId string, opt ...O
if err != nil {
return nil, nil, fmt.Errorf("error decoding List response: %w", err)
}
if apiErr != nil {
return nil, apiErr, nil
}
return target.Items, apiErr, nil
}
+15 -5
View File
@@ -59,7 +59,9 @@ func (c *AuthMethodsClient) Create(ctx context.Context, resourceType string, opt
if err != nil {
return nil, nil, fmt.Errorf("error decoding Create response: %w", err)
}
if apiErr != nil {
return nil, apiErr, nil
}
return target, apiErr, nil
}
@@ -89,7 +91,9 @@ func (c *AuthMethodsClient) Read(ctx context.Context, authMethodId string, opt .
if err != nil {
return nil, nil, fmt.Errorf("error decoding Read response: %w", err)
}
if apiErr != nil {
return nil, apiErr, nil
}
return target, apiErr, nil
}
@@ -137,7 +141,9 @@ func (c *AuthMethodsClient) Update(ctx context.Context, authMethodId string, ver
if err != nil {
return nil, nil, fmt.Errorf("error decoding Update response: %w", err)
}
if apiErr != nil {
return nil, apiErr, nil
}
return target, apiErr, nil
}
@@ -170,7 +176,9 @@ func (c *AuthMethodsClient) Delete(ctx context.Context, authMethodId string, opt
if err != nil {
return false, nil, fmt.Errorf("error decoding Delete response: %w", err)
}
if apiErr != nil {
return false, apiErr, nil
}
return target.Existed, apiErr, nil
}
@@ -199,6 +207,8 @@ func (c *AuthMethodsClient) List(ctx context.Context, opt ...Option) ([]*AuthMet
if err != nil {
return nil, nil, fmt.Errorf("error decoding List response: %w", err)
}
if apiErr != nil {
return nil, apiErr, nil
}
return target.Items, apiErr, nil
}