chore(targets): remove deprecated credential libraries on target resources (#1533)

internal/proto/controller/api/resources/targets/v1/target.proto

@@ -47,23 +47,6 @@ message CredentialSource {
   string credential_type = 70; // @gotags: `class:"public"`
 }
 
-message CredentialLibrary {
-  // The ID of the Credential Library.
-  string id = 10; // @gotags: `class:"public"`
-
-  // Output only.  The name of the Credential Library.
-  string name = 20; // @gotags: `class:"public"`
-
-  // Output only. The description of the Credential Library.
-  string description = 30; // @gotags: `class:"public"`
-
-  // Output only. The Credential Store to which this Credential Library belongs.
-  string credential_store_id = 40 [json_name = "credential_store_id"]; // @gotags: `class:"public"`
-
-  // Output only. The type of the credential library.
-  string type = 60; // @gotags: `class:"public"`
-}
-
 // The actual secret for a session credential.
 message SessionSecret {
   // Output only. The base64-encoded value representing the raw bytes from the
@@ -79,15 +62,16 @@ message SessionCredential {
   // Output only. The credential source information.
   CredentialSource credential_source = 1;
 
-  // Output only. The library which generated this credential. Deprecated: use credential_source instead.
-  CredentialLibrary credential_library = 10 [deprecated = true];
-
   // Output only. The secret of this credential base64 encoded.
   SessionSecret secret = 20;
 
   // Output only. The fields of the strongly typed credential, empty if the credential type of the
   // credential source is unspecified.
   google.protobuf.Struct credential = 40;
+
+  // Deprecated fields
+  reserved "credential_library";
+  reserved 10;
 }
 
 // Target contains all fields related to a Target resource
@@ -174,17 +158,6 @@ message Target {
     }
   ]; // @gotags: `class:"public"`
 
-  // Output only. The IDs of the application credential library ids associated with this Target. Deprecated: use application_credential_source_ids instead.
-  repeated string application_credential_library_ids = 150 [
-    json_name = "application_credential_library_ids",
-    deprecated = true
-  ]; // @gotags: `class:"public"`
-  // Output only. The application credential libraries associated with this Target. Deprecated: use application_credential_sources instead.
-  repeated CredentialLibrary application_credential_libraries = 180 [
-    json_name = "application_credential_libraries",
-    deprecated = true
-  ];
-
   // Output only. The IDs of the application credential source ids associated with this Target.
   repeated string application_credential_source_ids = 400 [json_name = "application_credential_source_ids"]; // @gotags: `class:"public"`
   // Output only. The application credential sources associated with this Target.
@@ -210,6 +183,10 @@ message Target {
 
   // Output only. The available actions on this resource for this user.
   repeated string authorized_actions = 300 [json_name = "authorized_actions"]; // @gotags: `class:"public"`
+
+  // Deprecated fields
+  reserved "application_credential_library_ids", "application_credential_libraries";
+  reserved 150, 180;
 }
 
 // TcpTargetAttributes contains attributes relevant to Targets of type "tcp"

internal/proto/controller/api/services/v1/target_service.proto

@@ -203,63 +203,6 @@ service TargetService {
     };
   }
 
-  // AddTargetCredentialLibraries adds Credential Libraries to this Target.
-  // The provided request must include the Target ID to which the Credential
-  // Libraries will be added. All Credential Libraries added to the provided
-  // Target must be a child of a Store that is in the same scope as this
-  // Target. If the scope or Target IDs are missing, malformed, or reference
-  // non-existing resources, an error is returned. An error is returned if a
-  // Credential Library is attempted to be added to a target that is already
-  // present on the Target.
-  rpc AddTargetCredentialLibraries(AddTargetCredentialLibrariesRequest) returns (AddTargetCredentialLibrariesResponse) {
-    option (google.api.http) = {
-      post: "/v1/targets/{id}:add-credential-libraries"
-      body: "*"
-      response_body: "item"
-    };
-    option (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_operation) = {
-      summary: "Deprecated: use AddTargetCredentialSources instead."
-    };
-    option deprecated = true;
-  }
-
-  // SetTargetCredentialLibraries sets the Target's Credential Libraries.
-  // Any existing Credential Libraries on the Target are deleted if they are
-  // not included in this request. The provided request must include the scope,
-  // and the Target ID on which the Credential Libraries will be set.  All
-  // Credential Libraries in the request must be a child of a Store that is
-  // in the same scope as the provided Target. If any IDs are missing,
-  // malformed, or references a non-existing resource, an error is returned.
-  rpc SetTargetCredentialLibraries(SetTargetCredentialLibrariesRequest) returns (SetTargetCredentialLibrariesResponse) {
-    option (google.api.http) = {
-      post: "/v1/targets/{id}:set-credential-libraries"
-      body: "*"
-      response_body: "item"
-    };
-    option (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_operation) = {
-      summary: "Deprecated: use SetTargetCredentialSources instead."
-    };
-    option deprecated = true;
-  }
-
-  // RemoveTargetCredentialLibraries removes the Credential Libraries from the
-  // specified Target. The provided request must include the Target ID for the
-  // Target from which the Credential Libraries will be removed. If the ID is
-  // missing, or malformed, an error is returned.  An error is returned if a
-  // Credential Library is attempted to be removed from the Target when the
-  // Target does not have the Credential Library.
-  rpc RemoveTargetCredentialLibraries(RemoveTargetCredentialLibrariesRequest) returns (RemoveTargetCredentialLibrariesResponse) {
-    option (google.api.http) = {
-      post: "/v1/targets/{id}:remove-credential-libraries"
-      body: "*"
-      response_body: "item"
-    };
-    option (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_operation) = {
-      summary: "Deprecated: use RemoveTargetCredentialSources instead."
-    };
-    option deprecated = true;
-  }
-
   // AddTargetCredentialSources adds Credential Sources to this Target.
   // The provided request must include the Target ID to which the Credential
   // Sources will be added. All Credential Sources added to the provided
@@ -430,45 +373,6 @@ message RemoveTargetHostSourcesResponse {
   api.resources.targets.v1.Target item = 1;
 }
 
-message AddTargetCredentialLibrariesRequest {
-  string id = 1; // @gotags: `class:"public"`
-  // Version is used to ensure this resource has not changed.
-  // The mutation will fail if the version does not match the latest known good version.
-  uint32 version = 2; // @gotags: `class:"public"`
-  repeated string application_credential_library_ids = 3 [json_name = "application_credential_library_ids"]; // @gotags: `class:"public"`
-}
-
-message AddTargetCredentialLibrariesResponse {
-  api.resources.targets.v1.Target item = 1;
-}
-
-// Sets the values for application_credential_library_ids.  If any
-// credential_library_id field that is not set in the request will result in
-// those fields being cleared.
-message SetTargetCredentialLibrariesRequest {
-  string id = 1; // @gotags: `class:"public"`
-  // Version is used to ensure this resource has not changed.
-  // The mutation will fail if the version does not match the latest known good version.
-  uint32 version = 2; // @gotags: `class:"public"`
-  repeated string application_credential_library_ids = 3 [json_name = "application_credential_library_ids"]; // @gotags: `class:"public"`
-}
-
-message SetTargetCredentialLibrariesResponse {
-  api.resources.targets.v1.Target item = 1;
-}
-
-message RemoveTargetCredentialLibrariesRequest {
-  string id = 1; // @gotags: `class:"public"`
-  // Version is used to ensure this resource has not changed.
-  // The mutation will fail if the version does not match the latest known good version.
-  uint32 version = 2; // @gotags: `class:"public"`
-  repeated string application_credential_library_ids = 3 [json_name = "application_credential_library_ids"]; // @gotags: `class:"public"`
-}
-
-message RemoveTargetCredentialLibrariesResponse {
-  api.resources.targets.v1.Target item = 1;
-}
-
 message AddTargetCredentialSourcesRequest {
   string id = 1; // @gotags: `class:"public"`
   // Version is used to ensure this resource has not changed.