From 6f886976e4c410c29063ca8dacd6ec093d051a52 Mon Sep 17 00:00:00 2001
From: Michael Gaffney <mgaffney@users.noreply.github.com>
Date: Tue, 11 Aug 2020 14:15:19 -0400
Subject: [PATCH] Add not null constraint to wt_version domain (#254)

---
 internal/db/migrations/postgres.gen.go        | 27 ++++++++++---------
 .../postgres/01_domain_types.up.sql           |  9 ++++---
 internal/db/migrations/postgres/06_iam.up.sql |  8 +++---
 .../migrations/postgres/10_static_host.up.sql |  6 ++---
 .../postgres/12_auth_password.up.sql          |  4 +--
 5 files changed, 28 insertions(+), 26 deletions(-)

diff --git a/internal/db/migrations/postgres.gen.go b/internal/db/migrations/postgres.gen.go
index ef25bdb3a..d0de1ef35 100644
--- a/internal/db/migrations/postgres.gen.go
+++ b/internal/db/migrations/postgres.gen.go
@@ -111,10 +111,11 @@ is
 
 
 create domain wt_version as bigint
-default 1 
-check(
-  value > 0
-);
+  default 1
+  not null
+  check(
+   value > 0
+  );
 comment on domain wt_version is
 'standard column for row version';
 
@@ -548,7 +549,7 @@ create table iam_scope (
 
     -- version allows optimistic locking of the role when modifying the role
     -- itself and when modifying dependent items like principal roles.
-    version wt_version not null default 1
+    version wt_version
   );
 
 create table iam_scope_global (
@@ -727,7 +728,7 @@ create table iam_user (
     scope_id wt_scope_id not null references iam_scope(public_id) on delete cascade on update cascade,
     unique(name, scope_id),
     disabled boolean not null default false,
-    version wt_version not null default 1,
+    version wt_version,
 
     -- The order of columns is important for performance. See:
     -- https://dba.stackexchange.com/questions/58970/enforcing-constraints-two-tables-away/58972#58972
@@ -857,7 +858,7 @@ create table iam_role (
     grant_scope_id wt_scope_id not null references iam_scope(public_id) on delete cascade on update cascade,
     unique(name, scope_id),
     disabled boolean not null default false,
-    version wt_version not null default 1,
+    version wt_version,
 
     -- add unique index so a composite fk can be declared.
     unique(scope_id, public_id)
@@ -969,7 +970,7 @@ create table iam_group (
     disabled boolean not null default false,
     -- version allows optimistic locking of the group when modifying the group
     -- itself and when modifying dependent items like group members. 
-    version wt_version not null default 1,
+    version wt_version,
 
     -- add unique index so a composite fk can be declared.
     unique(scope_id, public_id)
@@ -1351,7 +1352,7 @@ begin;
     description text,
     create_time wt_timestamp,
     update_time wt_timestamp,
-    version wt_version not null default 1,
+    version wt_version,
     unique(scope_id, name)
   );
 
@@ -1393,7 +1394,7 @@ begin;
     ),
     create_time wt_timestamp,
     update_time wt_timestamp,
-    version wt_version not null default 1,
+    version wt_version,
     unique(static_host_catalog_id, name)
   );
 
@@ -1429,7 +1430,7 @@ begin;
     description text,
     create_time wt_timestamp,
     update_time wt_timestamp,
-    version wt_version not null default 1,
+    version wt_version,
     unique(static_host_catalog_id, name)
   );
 
@@ -1725,7 +1726,7 @@ begin;
     update_time wt_timestamp,
     min_user_name_length int not null default 3,
     min_password_length int not null default 8,
-    version wt_version not null default 1,
+    version wt_version,
     foreign key (scope_id, public_id)
       references auth_method (scope_id, public_id)
       on delete cascade
@@ -1761,7 +1762,7 @@ begin;
         and
         length(user_name) > 0
       ),
-    version wt_version not null default 1,
+    version wt_version,
     foreign key (scope_id, auth_method_id)
       references auth_password_method (scope_id, public_id)
       on delete cascade
diff --git a/internal/db/migrations/postgres/01_domain_types.up.sql b/internal/db/migrations/postgres/01_domain_types.up.sql
index 1acd44586..45b2387a8 100644
--- a/internal/db/migrations/postgres/01_domain_types.up.sql
+++ b/internal/db/migrations/postgres/01_domain_types.up.sql
@@ -80,10 +80,11 @@ is
 
 
 create domain wt_version as bigint
-default 1 
-check(
-  value > 0
-);
+  default 1
+  not null
+  check(
+   value > 0
+  );
 comment on domain wt_version is
 'standard column for row version';
 
diff --git a/internal/db/migrations/postgres/06_iam.up.sql b/internal/db/migrations/postgres/06_iam.up.sql
index 14d7e55a3..bebbe7c27 100644
--- a/internal/db/migrations/postgres/06_iam.up.sql
+++ b/internal/db/migrations/postgres/06_iam.up.sql
@@ -43,7 +43,7 @@ create table iam_scope (
 
     -- version allows optimistic locking of the role when modifying the role
     -- itself and when modifying dependent items like principal roles.
-    version wt_version not null default 1
+    version wt_version
   );
 
 create table iam_scope_global (
@@ -222,7 +222,7 @@ create table iam_user (
     scope_id wt_scope_id not null references iam_scope(public_id) on delete cascade on update cascade,
     unique(name, scope_id),
     disabled boolean not null default false,
-    version wt_version not null default 1,
+    version wt_version,
 
     -- The order of columns is important for performance. See:
     -- https://dba.stackexchange.com/questions/58970/enforcing-constraints-two-tables-away/58972#58972
@@ -352,7 +352,7 @@ create table iam_role (
     grant_scope_id wt_scope_id not null references iam_scope(public_id) on delete cascade on update cascade,
     unique(name, scope_id),
     disabled boolean not null default false,
-    version wt_version not null default 1,
+    version wt_version,
 
     -- add unique index so a composite fk can be declared.
     unique(scope_id, public_id)
@@ -464,7 +464,7 @@ create table iam_group (
     disabled boolean not null default false,
     -- version allows optimistic locking of the group when modifying the group
     -- itself and when modifying dependent items like group members. 
-    version wt_version not null default 1,
+    version wt_version,
 
     -- add unique index so a composite fk can be declared.
     unique(scope_id, public_id)
diff --git a/internal/db/migrations/postgres/10_static_host.up.sql b/internal/db/migrations/postgres/10_static_host.up.sql
index 064d4faf9..64d6939bf 100644
--- a/internal/db/migrations/postgres/10_static_host.up.sql
+++ b/internal/db/migrations/postgres/10_static_host.up.sql
@@ -10,7 +10,7 @@ begin;
     description text,
     create_time wt_timestamp,
     update_time wt_timestamp,
-    version wt_version not null default 1,
+    version wt_version,
     unique(scope_id, name)
   );
 
@@ -52,7 +52,7 @@ begin;
     ),
     create_time wt_timestamp,
     update_time wt_timestamp,
-    version wt_version not null default 1,
+    version wt_version,
     unique(static_host_catalog_id, name)
   );
 
@@ -88,7 +88,7 @@ begin;
     description text,
     create_time wt_timestamp,
     update_time wt_timestamp,
-    version wt_version not null default 1,
+    version wt_version,
     unique(static_host_catalog_id, name)
   );
 
diff --git a/internal/db/migrations/postgres/12_auth_password.up.sql b/internal/db/migrations/postgres/12_auth_password.up.sql
index 0b76005e7..42e10fe22 100644
--- a/internal/db/migrations/postgres/12_auth_password.up.sql
+++ b/internal/db/migrations/postgres/12_auth_password.up.sql
@@ -66,7 +66,7 @@ begin;
     update_time wt_timestamp,
     min_user_name_length int not null default 3,
     min_password_length int not null default 8,
-    version wt_version not null default 1,
+    version wt_version,
     foreign key (scope_id, public_id)
       references auth_method (scope_id, public_id)
       on delete cascade
@@ -102,7 +102,7 @@ begin;
         and
         length(user_name) > 0
       ),
-    version wt_version not null default 1,
+    version wt_version,
     foreign key (scope_id, auth_method_id)
       references auth_password_method (scope_id, public_id)
       on delete cascade